From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5928 invoked by alias); 19 Feb 2020 23:35:51 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 5920 invoked by uid 89); 19 Feb 2020 23:35:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=joesomewherenet, joe@somewhere.net, H*c:alternative, HX-HELO:sk:mail-oi X-HELO: mail-oi1-f174.google.com Received: from mail-oi1-f174.google.com (HELO mail-oi1-f174.google.com) (209.85.167.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 23:35:49 +0000 Received: by mail-oi1-f174.google.com with SMTP id q84so25681398oic.4 for ; Wed, 19 Feb 2020 15:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kyu/t+G0Yr3qHBzl+wPfyGp+jTR5bpSFqXoO76w8UOE=; b=VhX/kc3BrihxARTdjv+VwD4LxbZUxl4/gkSn4PqfROY8yeJRd76GP6Gdiec7Fvb+Ja twzznBb9vLJp6O9YA1ulfspSQ5Y6utnurdftXPTZsF6gvqVWQKCPLBjF6VeEby6YP7uA OD9a0bdKRqQPW3L8JQiql+FksXdpcblKt14LHxHvgx31HICP4Yqnzc194nvCaFiotaSw EIqtlUDfcLWVQamGiQoc+d17tXzxPdr0otX9zK3eYcjbEemgj4Zfz80J7cO5eWsZDL8I HVveu7NmNSpA/kCVKXMt/Hqyj0/FgbLZmG29G3kZgbQiGnJK3F6w9pqFa6RwkogDi/5O uubQ== MIME-Version: 1.0 References: <20200214201441.146590-1-rupprecht@google.com> <20200219090334.GR5570@bubble.grove.modra.org> <20200219225503.GV5570@bubble.grove.modra.org> In-Reply-To: <20200219225503.GV5570@bubble.grove.modra.org> From: Eric Christopher Date: Wed, 19 Feb 2020 23:35:00 -0000 Message-ID: Subject: Re: Committing patches for other people To: Alan Modra Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00487.txt.bz2 Ah yes that's a very good point. On Wed, Feb 19, 2020, 2:55 PM Alan Modra wrote: > On Wed, Feb 19, 2020 at 01:58:20PM -0800, Eric Christopher wrote: > > I've gone ahead and committed this for Jordan. > > OK, but I'll note that when not using "git am" to commit other > people's patches you should take steps to properly attribute > authorship. > git commit --amend --author="Joe Bloe " > > As it is, "git blame" shows > 741cb83912f (Eric Christopher 2020-02-19 13:55:25 -0800 > for objdump.c lines changed by Jordan's patch. > > None of this matters very much at the moment, but if we are to move > away from ChangeLogs then we will need to learn better habits. > > -- > Alan Modra > Australia Development Lab, IBM >