From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 21E1F385843A for ; Tue, 8 Mar 2022 06:25:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21E1F385843A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.unc.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.unc.edu Received: by mail-ej1-x634.google.com with SMTP id gb39so36835713ejc.1 for ; Mon, 07 Mar 2022 22:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.unc.edu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YmDJYLQxNt+DGv31Kxv4NcgBZbXoHrVFW0z/EwiW0bw=; b=EIKyc4zKPFdqh5SrNTfJq20oJJtpCg176sZkKpNmM3mcDvruFpsqunnzkprknXZF3B 2ZrvNE/KyKBMawCdBO0nWPg7yjgFKFaaQUoSStwRFATH9x1VIGmW1BpZH3ZnZbs/1vqN /1od/MKyDlrGGHAzlKAfCk93xDX6lFCw39W8/XhQtq9/gEu3i9dZqn57uDM+YUV//cUn BOCQKocEDC0r943XJPq/7sAzFgf2E1sxLsJtilwhNDfubdMpOm47HdjmucK1DZEQU6qo Ypnl1C+ISUb9i+oHXOOTmB6Xr+6Hx/dMx6hyVr/lMPBIpc38WOokHp0TJxG/s566mZ1D g2CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YmDJYLQxNt+DGv31Kxv4NcgBZbXoHrVFW0z/EwiW0bw=; b=idEExctdO//NabspB1iJfzVOI+hsWGH/JDKRMm2/Bmh5gq5edwkr25CfWq8fBz8TVt 7hJBR9ror+sr8L7lID2RIuGvNOZ2eyNThThxj6swJ24U53ZHYIDQZcAv2H4rO7sER0yD uB4FZYjZidczzODKuII4nZlhZA6A29MkmhXTBcf27S3ZhDmKnGUSZD6mdilgILQi4Usr 8Su3kmR0mvyVysgKe0OhcYznAUd6GKEFp2w5Z6+f6jyGA0wdwB7mLt+1Uiec3mimvSzG koNrWZi3jCDS9lYk7QmRfFfy7wHbRHBQ1ZA6ggdPIHNWbiqPPYp8ExHxWTX2jVzq1JKG SHkA== X-Gm-Message-State: AOAM531flpdQvPS0DlmO7WevSSp9PaJTGWEV6QvnHM0yjw84k6iz/MPa L6g4wY8zyU8dQmxfZAQLHxaCl8g5nVce99PDuUMrueuYi8RnEX9U X-Google-Smtp-Source: ABdhPJx71E2SJxpi/JQgdfm14VVVyVIfvBg6RIKR5//Ce0mTO5QTagOjZ0HGnKBwm1780YwZFapB3vFmK9nmhQVaYww= X-Received: by 2002:a17:906:32d8:b0:6ce:d850:f79 with SMTP id k24-20020a17090632d800b006ced8500f79mr11538159ejk.414.1646720758109; Mon, 07 Mar 2022 22:25:58 -0800 (PST) MIME-Version: 1.0 References: <20220307151833.22389-1-sagarmp@cs.unc.edu> In-Reply-To: From: Sagar Patel Date: Tue, 8 Mar 2022 01:25:47 -0500 Message-ID: Subject: Re: [PATCH] MIPS/opcodes: Fix alias annotation for negate instructions To: "Maciej W. Rozycki" Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 06:26:00 -0000 On Mon, Mar 7, 2022 at 3:46 PM Maciej W. Rozycki wrote: > On Mon, 7 Mar 2022, Sagar Patel wrote: > Please do not include updates to ChangeLog files with the diff as they > will almost surely cause a conflict right away. Instead please just put > entries intended for ChangeLog files within the change description, as you > correctly did, and then the committer will produce actual ChangeLog file > entries from that text. Oh, that makes way more sense. I'll drop the changes to the ChangeLog files. > This might be overly pedantic, but with any test case I suggest putting > the absolute minimum there so as not to make someone in the future wonder > what the specific requirement was for one option or another (possibly I > shouldn't have used `.set noat' and $1 either, but let's leave it as it > is). I agree. I can remove the use of `.set noat' in the two new test sources. Should I do that? > It looks perfect otherwise and once your paperwork has been sorted I will > push either your change as posted with amendments made for the two pieces > above or any v2 if you prefer to make one yourself. Just to keep you in the loop, I sent in the request for the paperwork. I'll let you know if I don't hear back soon. I'll send a v2 with the requested changes. Thank you for the review. ---Sagar Patel