From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 2405E3858412 for ; Mon, 7 Mar 2022 07:13:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2405E3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.unc.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.unc.edu Received: by mail-ed1-x530.google.com with SMTP id f8so18504460edf.10 for ; Sun, 06 Mar 2022 23:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.unc.edu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XvXioyTj7ulEshWU6g1hbp4CweeVKykFbLwO+IwHLy8=; b=TkZRzVq8d/On4l12qeypJKKcA7EcUxZmVdciAaZrDXsklg8z93u7iMEm10UNSPoE7l GoAyaeprwHvGULCOHcSVtq7ITG1M4r24kTMKjHer6i86jLUTtX58FnHwOBh0Dbcn7tcG ihWxfLmettEKdBxr8VOV3Xz2s+sIP4MCzXshVvLSzw8cv3XHzHG38fCOB6/DsZQ7wW2o Dr+Wy/1W3zHoJd9C3TJtD8MfG4MwV0xe5O9wmjsJwlDHhUxnJrok/gx4cjNEwm56KszD NM7yBdmwB1TILGcvPeIWcXPglWAjAmbCZVh4tCqXUOzcdvsCZy7hnaRRLtt2I5NYFRaw hWjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XvXioyTj7ulEshWU6g1hbp4CweeVKykFbLwO+IwHLy8=; b=IcHR0vD6OKMb0D30ci+qEaLOahMVZOfT4tUiV7unv7NyZeaaSJ0wYRS9RCZ/WtAzBL YICV7LuYt/CE7/ZKJLWbR7/WL5kFIx7knsRYkG1aWPJvYQPWQE/W1R/WBeCo16da4ryF +5mXFGYflNQlcOTKwlbs/1N8qCEeCaxlMcejL4rS7mE2NTHJjpuwQMi0NM0pPvhjvg2W ZGqzlWIP9UyIHZeelz4J3KlBJxXBiY0XtYFGsEDybJPoMbqsHhbpkFVSw3q5QV7IUpLQ 6UjRV4zS2j/zcqEdrlEsGlwjkM6FvG2Sm9ca6RIq+9vun2UkU2QQbUm+bAMAPhKfNB3V WeWA== X-Gm-Message-State: AOAM531RsUulusoM4m089hTeib0on+58PAVOuXXrAoVszYY3RAwzZWLG aQLOaEOy5RnExlrSUKlhkdrn+6zDSm8iqy3PqanRBw== X-Google-Smtp-Source: ABdhPJwqJ/eSsq9UQ+y7aWTymvACP5ISIii/IBruap2fkpNV/O2EZJJLEb84Ftspi7i8yTKnK1WCoqtehttPchJPQMA= X-Received: by 2002:a50:da8b:0:b0:415:a122:d7ad with SMTP id q11-20020a50da8b000000b00415a122d7admr9803821edj.123.1646637230143; Sun, 06 Mar 2022 23:13:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Sagar Patel Date: Mon, 7 Mar 2022 02:13:39 -0500 Message-ID: Subject: Re: [committed v2] MIPS/opcodes: Fix alias annotation for branch instructions To: "Maciej W. Rozycki" Cc: Nick Clifton , Chenghua Xu , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 07:13:53 -0000 On Sun, Mar 6, 2022 at 1:33 PM Maciej W. Rozycki wrote: > > Last but not least your change does not include a testsuite update and > yet it does not cause regressions with testing despite the semantic > change. That means we don't have this area covered. > > Here's what I have committed then, addressing the issues listed above. > I have added the missing ChangeLog entry too and rewritten the change > heading and description accordingly. Thanks for explaining how to format future patches. I didn't think to update the test suite (since I didn't know it existed). I'll update the ChangeLog, and include it in the commit message in the future. > NB I can see you have not contributed before and your patch is very > small, affecting 4 lines of code only, which qualifies as not a legally > significant change. If you wish to continue contributing to binutils > project however, then please consider getting a copyright assignment > signed with FSF, as this will allow you to make changes beyond the limit > of ~15 lines of code total, which these 4 lines count against too. Nick, > the head binutils maintainer (cc-ed), will get you introduced if you would > like to follow this path. I have another patch that has a larger diff teed up, so I guess I'll need to look into copyright assignment. Is there an easy way to assign copyright as changes are submitted, instead of assigning it for all future changes? It would be great if this project could drop the copyright assignment requirement like gcc [1]. This would certainly reduce friction in the process of contributing. (I know you're probably not the person that makes these decisions. Just putting this out there.) > Again, thank you for your contribution, your input is valuable. Thank you! I appreciate your guidance :) [1]: https://lwn.net/Articles/857791/ ---Sagar Patel