From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id 5CB2B3858D35 for ; Tue, 23 May 2023 06:45:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CB2B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-561c1436c75so93563097b3.1 for ; Mon, 22 May 2023 23:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684824325; x=1687416325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WIDaIE4fZRvecUahLz+tiaNnk69Tb6QsMZOVAWiFflk=; b=S1n9mG9tYFApcyYtBJNpVmTgU3y2cCJIDWm7v6Vb7YCVd3sWOyk/8axQ6xGh8+Ue9n H6IjEemAUH4OX71a7eHBqIx7MLf3FMU1KGi0/ikNtJsEIvVEjf2q2JZoZi+Q8I4X9fsN R3v8rtZ6XUZpJeGPDSqjEs+iS+EKmUTYOwOYr6G2VepIhTukCV0kyIj5I95WHSsNGnsw QgeaNhILehZ8A5rAYKGTz0JyS8XadNDdXoKngxiVwy4ixab0Dvg/oJsd7LD2qUOxwaHq p901MbM3Fwm7V7VSkcA3R8Uya1HPL6GYIqKnAWy3i2Qfq6dHB0H08WBdzD6CHxbL2z2Q esog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684824325; x=1687416325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WIDaIE4fZRvecUahLz+tiaNnk69Tb6QsMZOVAWiFflk=; b=JJMJat7vRUvKzIFs1ekc8Jov11qvcGc8sVh2HrPdUlkKUtOe5VWcW49GVGzew8bV8S wWRfrsXdBgSEyci7qZEfaFccbrNk/Lv58eqEaX0XFMzmI7ezFB2cwLC4x8GYdTreJ/F6 2lg/zzpd2TFrVEQNGi6bmcvJmf74SJnfUNBE0SQ9/c7V6a7zINkE+EZlgqZyuSVhbRnk 3m0ONyO1D6yr/t5imCKn7wpAefGt4L8jOAtOu6G88Uva0O7uTPb7/xYtruEQmnRHnxsJ KlaIFjPYisGY86SFi+ucaqMh4UEiLFkN2f/KA9ZsVY60HLYr0lluwYv1nR9bhCaqHVHT mioA== X-Gm-Message-State: AC+VfDyQSGZBCou534f3KVs0CAPLk6Dj0WpuCUE0Rh2rPDSmjCHLjuSi qsFiAyt7pj6E6IAJpwQNkezpl6Rw3pYrCO899os= X-Google-Smtp-Source: ACHHUZ53K4IzTEce3mIswRVCsOtucO0zGU5Yzc1f/0a46+3wXJq9WV1Y0m4Rx8+UB41NZvXKWe4+qhdXSW/lfZhjSUo= X-Received: by 2002:a81:494c:0:b0:561:afca:5b4d with SMTP id w73-20020a81494c000000b00561afca5b4dmr13810191ywa.3.1684824324733; Mon, 22 May 2023 23:45:24 -0700 (PDT) MIME-Version: 1.0 References: <20230522142036.199490-1-jun.zhang@intel.com> <8571942b-3cc7-077f-4b41-bec547ab2dfd@suse.com> In-Reply-To: <8571942b-3cc7-077f-4b41-bec547ab2dfd@suse.com> From: Hongtao Liu Date: Tue, 23 May 2023 14:45:13 +0800 Message-ID: Subject: Re: [PATCH v3] Support Intel FRED LKGS To: Jan Beulich Cc: "Zhang, Jun" , hjl.tools@gmail.com, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 23, 2023 at 2:27=E2=80=AFPM Jan Beulich wro= te: > > On 23.05.2023 07:52, Hongtao Liu wrote: > > On Mon, May 22, 2023 at 10:47=E2=80=AFPM Jan Beulich via Binutils > > wrote: > >> > >> On 22.05.2023 16:20, Zhang, Jun wrote: > >>> This patch is the third version about Intel FRED and LKGS instruction= s. > >>> please help to review. > >>> > >>> Jan,I am new comer, this is my first patch for binutils. > >>> Maybe we need senior engineer to fix Ew. > >> > >> Well, okay, I'll try to deal with that myself then. What I'm puzzled b= y > >> though is what this v3 is intended to change / correct comparing to v2= . > >> The one small request about ... > >> > >>> --- a/opcodes/i386-opc.tbl > >>> +++ b/opcodes/i386-opc.tbl > >>> @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|Che= ckOperandSize|NoSuf, { Reg32|Reg64 > >>> axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, = { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > >>> > >>> // RAO-INT instructions end. > >>> + > >>> +// LKGS instructions. > >> > >> ... using singular here and ... > >> > >>> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64= , { Reg16|Reg32|Reg64 } > >>> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf= |No_qSuf, { Word|Unspecified|BaseIndex } > >>> + > >>> +// LKGS instructions end. > >> > >> ... here was not fulfilled, in any event. Plus that wouldn't require > >> re-posting, but simply correcting before/while committing. In case > >> you don't have commit access (you didn't say so, though) I'm sure > >> H.J. or I could make this small adjustment while committing for you. > >> But you'd need to let us know ... > > Push to trunk on behalf of jun. > > As said on the build failure thread: The three generated headers also > need updating. oops, I've pushed the wrong patch, pushed again(the one with regenerated headers). > > Jan --=20 BR, Hongtao