From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 47D743858D35 for ; Tue, 23 May 2023 05:52:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47D743858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-ba81031424dso10535700276.2 for ; Mon, 22 May 2023 22:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684821159; x=1687413159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lsvJdVJWV6bdgqCRQtXi2b9+3P7Nb3vCRRLA1L3UeS0=; b=SPmXaSbxzJYUgw3WQwZH1naQC/3GV52VpNSUtDteeaTyF94Nhu/VmNeCuupXeFIEKe sXOnZv34czLKLPKZDpZpY+wAz6db2aDhDOcI+GNplHdS8sXmM9PKe/tNTt+YpRiVn6tv kCGm+YgQYaw1KjGd9XKbLUL7Mk2Rdr12TGnGyaHTGabJAyc5MtjILpTVc7idNmcTkMem kL/ZjRHEsOSWZP59VPqYMUDtcWcgyh8qpQ/41zzpMITwOIb42mxIkV3Q4xA08eOxVQw0 SpW/Q0SeDzDPLhYezQA5BkH1u1BKcXTLHDwwwpbtruToDMqbSHR0X2/WORir5iiGQrLd /wlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684821159; x=1687413159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsvJdVJWV6bdgqCRQtXi2b9+3P7Nb3vCRRLA1L3UeS0=; b=VaqLerfGVZMVk8svJl7ve4P1WMZmP/fkxRYMkELyoeBSE+H3kR/K/Alj9ODWmCEbRX 5QHHkOfjPBK6A80Gi7DteP2TbWMa1YxoCZpAzIsd13kJ6kA7Euxfl/fyZfpE6fRhmwTs FHwk8D92wZf2u+Gl//0Tee6G0V5KJ34xf0Gt+a8GopiJa64c44CG0YxrOeCnGldhpzBJ 0lk5fIB4nfdHGZp/Sc6KIhmAedwrcg4/bZy6XMAjcsz/maMJC6qhTTqAHXB9KT1ETos5 BvgIJN/iqIyfqxxLvdaw3+gTnce/J1cD84G8+avDYuvtD4YaNJff62TJxtHanZC7gzJE sbjg== X-Gm-Message-State: AC+VfDzQGLw18NJvXNr7KaaD3bFJ2eW1F0xKA27BLFfQE0uCuxFMnZuV NkiI0bysZ+og0UYw73OhTHCFt0qvFlalAP9+THKnx3OMZfk= X-Google-Smtp-Source: ACHHUZ6KNrLvJJ/ngxaXZF0Bb0l8L1Wbu6SE3yL/+BtM8CKuqwgpRtq3GQTDH58OO5bs40PtQRozyQBMRGeyYR7xqwg= X-Received: by 2002:a25:c74e:0:b0:ba8:2c58:be73 with SMTP id w75-20020a25c74e000000b00ba82c58be73mr14083308ybe.32.1684821159547; Mon, 22 May 2023 22:52:39 -0700 (PDT) MIME-Version: 1.0 References: <20230522142036.199490-1-jun.zhang@intel.com> In-Reply-To: From: Hongtao Liu Date: Tue, 23 May 2023 13:52:28 +0800 Message-ID: Subject: Re: [PATCH v3] Support Intel FRED LKGS To: Jan Beulich Cc: "Zhang, Jun" , hjl.tools@gmail.com, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 22, 2023 at 10:47=E2=80=AFPM Jan Beulich via Binutils wrote: > > On 22.05.2023 16:20, Zhang, Jun wrote: > > This patch is the third version about Intel FRED and LKGS instructions. > > please help to review. > > > > Jan,I am new comer, this is my first patch for binutils. > > Maybe we need senior engineer to fix Ew. > > Well, okay, I'll try to deal with that myself then. What I'm puzzled by > though is what this v3 is intended to change / correct comparing to v2. > The one small request about ... > > > --- a/opcodes/i386-opc.tbl > > +++ b/opcodes/i386-opc.tbl > > @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|Check= OperandSize|NoSuf, { Reg32|Reg64 > > axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { = Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > > > > // RAO-INT instructions end. > > + > > +// LKGS instructions. > > ... using singular here and ... > > > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64, = { Reg16|Reg32|Reg64 } > > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf|N= o_qSuf, { Word|Unspecified|BaseIndex } > > + > > +// LKGS instructions end. > > ... here was not fulfilled, in any event. Plus that wouldn't require > re-posting, but simply correcting before/while committing. In case > you don't have commit access (you didn't say so, though) I'm sure > H.J. or I could make this small adjustment while committing for you. > But you'd need to let us know ... Push to trunk on behalf of jun. > > Jan --=20 BR, Hongtao