From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id 580B53943540 for ; Wed, 30 Sep 2020 14:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 580B53943540 Received: by mail-io1-xd44.google.com with SMTP id k6so1916523ior.2 for ; Wed, 30 Sep 2020 07:04:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NmXoYl7Jhfzjodob3bGDq9Yr+WbBaJnxAhL4+pEFLB8=; b=guKViqH0X2C01fGok6NvvYzGnbULL8x53pLwYWZ3/O6pIgiFp3kZT/x19GjfkSj0/D spRbqU69ZIFJ4928dfnLQz6PTWcJ0t9mh0v5+Jcpwz4uEUzUekFJssCVQ7Spr9Q6fXXq LzsyHM/OKBsp4W3B9535Pf3aPrl6Hq8vGUevJHojQY3hCYuODGRykxNSsZ2OU/F2Xobw Po3dsI11da2Ikae48YyssYLnqsoDDT8xNEP6XITUqNt5TCeIC2yEmcJZgacZ8dnlWe9R 4m5/y/5ptVJ9zcXyWfQATzqMwMlz8MQZ+mgfGGdzqtdLXXhYy41/ZTcTLGvkpcTzdoE9 YSfw== X-Gm-Message-State: AOAM533WcMytfNYSU0bVFZKlULA0w9clG7bC9WTA7DHRXulfTtNQf5d9 P/VyxTd4aTQPESNBuFqBcj/r3WQe0x3B+rImskWFHYCOf+U= X-Google-Smtp-Source: ABdhPJw0nsRh8w/xg4gdWJvln4HHeFv9hlFZ+yw74Q+55/PggeJ4lBqHR+gZtXb/IwuQVQ2AzC8heuoey3QpME6/wC8= X-Received: by 2002:a02:6607:: with SMTP id k7mr2060859jac.91.1601474661855; Wed, 30 Sep 2020 07:04:21 -0700 (PDT) MIME-Version: 1.0 References: <87pn647h1h.fsf@redhat.com> <20200929165317.2yebvny6gas4jz5f@gmail.com> <3609c590-8750-a021-92fb-05ff0ba7ca7d@redhat.com> <8176aa1f-3c9b-45ec-b1a3-8e7cf19de47c@redhat.com> In-Reply-To: <8176aa1f-3c9b-45ec-b1a3-8e7cf19de47c@redhat.com> From: "H.J. Lu" Date: Wed, 30 Sep 2020 07:03:46 -0700 Message-ID: Subject: Re: [PATCH] elf: Also check linked-to section for SHT_NOTE section To: Nick Clifton Cc: Binutils , Fangrui Song Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2020 14:04:23 -0000 On Wed, Sep 30, 2020 at 7:01 AM Nick Clifton wrote: > > Hi H.J. > > Thanks for taking an interest in this. > > > Please try this patch. > It did not appear to make a difference. :-( > > I am using an extended test case (attached) but the results are the > same as before: > > % as eliminate.s -o eliminate.o > % ld -e 0 --gc-sections --print-gc-sections eliminate.o > ld: removing unused section '.group' in file 'eliminate.o' > ld: removing unused section '.group' in file 'eliminate.o' > ld: removing unused section '.text' in file 'eliminate.o' > ld: removing unused section '.unused1' in file 'eliminate.o' > ld: removing unused section '.unused2[unused_group]' in file 'eliminate.o' > ld: removing unused section '.unused3[unused_group2]' in file 'eliminate.o' > ld: removing unused section '.gnu.note2[unused_group]' in file 'eliminate.o' > ld: removing unused section '.gnu.note3[unused_group2]' in file 'eliminate.o' > ld: a.out: sh_link of section `.gnu.note1' points to discarded section `.unused1' of `eliminate.o' > ld: final link failed: bad value > > Cheers > Nick Works for me: [hjl@gnu-cfl-2 ld]$ gcc -c eliminate.s [hjl@gnu-cfl-2 ld]$ ./ld-new -e 0 --gc-sections --print-gc-sections eliminate.o ./ld-new: removing unused section '.group' in file 'eliminate.o' ./ld-new: removing unused section '.group' in file 'eliminate.o' ./ld-new: removing unused section '.text' in file 'eliminate.o' ./ld-new: removing unused section '.unused1' in file 'eliminate.o' ./ld-new: removing unused section '.unused2[unused_group]' in file 'eliminate.o' ./ld-new: removing unused section '.unused3[unused_group2]' in file 'eliminate.o' ./ld-new: removing unused section '.gnu.note1' in file 'eliminate.o' ./ld-new: removing unused section '.gnu.note2[unused_group]' in file 'eliminate.o' ./ld-new: removing unused section '.gnu.note3[unused_group2]' in file 'eliminate.o' [hjl@gnu-cfl-2 ld]$ -- H.J.