From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id 8387A384AB50 for ; Tue, 23 Apr 2024 15:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8387A384AB50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8387A384AB50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713886243; cv=none; b=tvOgBhPv4WlN0XeiHF5gf7oDTp4PMiXBPMMpGMeSe3NEBE1xfXLX75IYumcbcac7K+HXxTi02XtT2TJ7NUbYWrWHlnHmXfWIAn7K/DEXlpUDo6EEjfUcfRoZ7+oVm6tSVtZYfZlUDU+7OdE/wywXkMHC3TCbJ9uXdhy3ELpMNCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713886243; c=relaxed/simple; bh=r+RD2vS7oeCgRK6foV9/4FyAIcrCIFGBcksHKcm20p0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Zy9qIxXG2RvcLLsY/5Od+EGCB/w7urLFkQFDEc7Oipw0cslVKl2Jyh8R/8Z9NpQYF8+giz7796VFUxxAncn4XlwyugvQQveQHBh99zD10R2d9SZ41ehUnXieHq9NeL4DffduMuSquZyspXLgJF7sVJk8ceMw1uNTVhbct1d7ANw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso4723574276.0 for ; Tue, 23 Apr 2024 08:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713886240; x=1714491040; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZuutpA1lPjazntguctiF5sJO/AuQFd44GG6/XaB9lC4=; b=Owkb9zEkMFa1bzWJd5LGUavWchkp1sL+iG/XZp9HTuEUDZzUEfQZcBdAE3SJJ7PCqb MnBp++VuTD2k32jEAqdFqwoXtPwg6Zprtp6NcNW8fzrMBSoIM6h6RT7BPRKSFaV3+Rjk zF/QL1e5vp+GlmZ8vDoxktWe3ZjbIXbfJY6+W00eGDTavYSVdvAwbaaJRSvg/zyS3Hoe OlxdV+20Z3UAXZ+8R6OaOveF5dKQ9/VqUjhlzN7kCR72JTs2cFpA6jZW7FBc/NHOh/5u RTqZvLFh4VoJ1AEnCRX0CqrG8k2FUAqLsl0jD+ZjYMtwwK1ZQn1aGDJERYcUDtkQBorQ EdwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713886240; x=1714491040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZuutpA1lPjazntguctiF5sJO/AuQFd44GG6/XaB9lC4=; b=AJTe1bpc9esrl9X2BBIImY94kW/pAaPHkfmx4nQSTJ86TYxsJcRstRIi5HnCD3o4Fl 6sN54cTy5xOz2uDTJoIGvxms2DiY8Z25VPVx1JTknuP99hpewgdtxmQYIuew9/EUDYH+ xGh7fDXWcE9GowwMISJda41fgD5VZGKHvXIqvWm6yFHSfZCmhFfupGB2jZZO1PBJPbo/ qQ9NEbHENBURZRicL9bh2fZne/pTrj/jj9RypdxUppNCtt5OJugAqmvNCLvbHKtEwU70 HTd0JzQwEKkBXrr7DiYCHcwkMdgiTXZQn3jPLrJSA4fYQ0Ljl0YCh6d0laN93UqXhGEp IZdA== X-Gm-Message-State: AOJu0Yxa3mhpmdwcikU9EDYv91pHNbfegVBgkOq4aHzvi1dFfYFv2SHM mTkXnwrVfIgZzU0Vf4u8tp0oI9pOyLwAKPd5VpNkEHfuwrQZeHR9KRYyFgtbSNCTjitiSx1ApMI YA+3mJ439RAxWVBaCAIOXgScZ198BYA== X-Google-Smtp-Source: AGHT+IHzbSH/DqQkPkrr1Sgt1AfQw7PPSu1ZcyOezRDDgZp4rvzRpvpo6xDiJp0/mBpXeLPh7TtB9ncsqzpP9bFUNKo= X-Received: by 2002:a25:ae12:0:b0:dc2:3a05:489 with SMTP id a18-20020a25ae12000000b00dc23a050489mr2614764ybj.14.1713886239707; Tue, 23 Apr 2024 08:30:39 -0700 (PDT) MIME-Version: 1.0 References: <20240423141324.1156583-1-hjl.tools@gmail.com> In-Reply-To: <20240423141324.1156583-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Tue, 23 Apr 2024 08:30:03 -0700 Message-ID: Subject: Re: [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts To: binutils@sourceware.org Cc: amodra@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 23, 2024 at 7:13=E2=80=AFAM H.J. Lu wrote= : > > Use long with bfd_copy_private_symbol_data to fix > > .../binutils/objcopy.c: In > function =E2=80=98copy_object=E2=80=99: > .../binutils/objcopy.c:3383:17: error: comparison of integer expressions = of different signedness: =E2=80=98unsigned int=E2=80=99 and =E2=80=98long i= nt=E2=80=99 [-Werror=3Dsign-compare] > 3383 | for (i =3D 0; i < symcount; i++) > | ^ > > on 32-bit hosts. > > PR binutils/14493 > * objcopy.c (copy_object): Use long with > bfd_copy_private_symbol_data. > --- > binutils/objcopy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > index 634ebae3fc3..e8ca1374935 100644 > --- a/binutils/objcopy.c > +++ b/binutils/objcopy.c > @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_i= nfo_type *input_arch) > symcount =3D filter_symbols (ibfd, obfd, osympp, isympp, symcount)= ; > } > > - for (i =3D 0; i < symcount; i++) > - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])= ) > + for (long s =3D 0; s < symcount; s++) > + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s])= ) > { > status =3D 1; > return false; > -- > 2.44.0 > Tested on Linux/x86-64 and Linux/i686. I am checking it in. --=20 H.J.