From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25311 invoked by alias); 14 Jul 2011 14:56:22 -0000 Received: (qmail 25299 invoked by uid 22791); 14 Jul 2011 14:56:21 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jul 2011 14:55:47 +0000 Received: by qwa26 with SMTP id 26so236320qwa.0 for ; Thu, 14 Jul 2011 07:55:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.216.148 with SMTP id hi20mr1762809qcb.48.1310655346147; Thu, 14 Jul 2011 07:55:46 -0700 (PDT) Received: by 10.229.71.157 with HTTP; Thu, 14 Jul 2011 07:55:46 -0700 (PDT) In-Reply-To: <20110714111802.GZ26365@bubble.grove.modra.org> References: <20110713144443.GR26365@bubble.grove.modra.org> <20110714023910.GS26365@bubble.grove.modra.org> <20110714111802.GZ26365@bubble.grove.modra.org> Date: Thu, 14 Jul 2011 17:16:00 -0000 Message-ID: Subject: Re: ld -z options From: "H.J. Lu" To: Hans-Peter Nilsson , binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00156.txt.bz2 On Thu, Jul 14, 2011 at 4:18 AM, Alan Modra wrote: > On Thu, Jul 14, 2011 at 04:06:03AM -0400, Hans-Peter Nilsson wrote: >> Talking to myself... >> >> On Thu, 14 Jul 2011, Hans-Peter Nilsson wrote: >> > This caused several test-cases to go from PASS to UNRESOLVED for >> > cris-axis-linux-gnu >> >> It seems this would happen for e.g. ia64-*-linux-gnu too. > > Yes. > >> > All preceded by a linker warning ".../ld-new: warning: -z relro >> > ignored." in ld.log. =A0The UNRESOLVED status then cause the >> > check-ld to return error. =A0According to the dejagnu docs, the >> > UNRESOLVED is an indication of an error in the testsuite (likely >> > the unexpected warning). >> >> That's a bug in ld-elf/binutils.exp or the new warning message; >> binutils.exp tests [string match "*not supported*" $link_output] >> =A0 =A0 =A0 =A0 =A0 =A0 =A0|| [string match "*unrecognized option*" $lin= k_output] >> which doesn't match "warning: -z relro ignored.". >> >> Which one should be adjusted? > > Probably the new one. =A0Patch preapproved if you'd like to do it. I checked in this: diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index ee6987f..bc01d77 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-07-14 H.J. Lu + + * ld-elf/binutils.exp (binutils_test): Also check ignored + "-z relro". + 2011-07-14 Alan Modra * ld-scripts/section-flags.exp: Pass --local-store 0:0 for diff --git a/ld/testsuite/ld-elf/binutils.exp b/ld/testsuite/ld-elf/binutil= s.exp index 380bd26..382d50f 100644 --- a/ld/testsuite/ld-elf/binutils.exp +++ b/ld/testsuite/ld-elf/binutils.exp @@ -53,7 +53,8 @@ proc binutils_test { prog_name ld_options test } { if { ![ld_simple_link $ld tmpdir/$test "$ld_options tmpdir/$test.o"] }= { if { [string match "*not supported*" $link_output] - || [string match "*unrecognized option*" $link_output] } { + || [string match "*unrecognized option*" $link_output] + || [string match "*-z relro ignored*" $link_output] } { unsupported "$ld_options is not supported by this target" } else { unresolved "$test_name" --=20 H.J.