From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ian Lance Taylor <iant@google.com>
Cc: binutils@sourceware.org
Subject: Re: PATCH: PR gold/14897: gold is installed as default ld by accident
Date: Mon, 07 Jan 2013 17:06:00 -0000 [thread overview]
Message-ID: <CAMe9rOo6607fqPyKqXk38Fcs0FOQuLfLnLdXMdFWb9Zn0bvMCg@mail.gmail.com> (raw)
In-Reply-To: <20121130150235.GA7366@intel.com>
On Fri, Nov 30, 2012 at 7:02 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> We should install gold as default ld only for --disable-ld or
> --enable-gold=default. Tested with
>
> --enable-gold
> --enable-gold=default
> --enable-gold --disable-ld
>
> OK for trunk and 2.23?
>
> Thanks.
>
> H.J.
> ---
> 2012-11-30 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gold/14897
> * configure.ac (install_as_default): Set to yes only for
> --disable-ld or --enable-gold=default.
> * configure: Regenerated.
> --- a/gold/configure.ac
> +++ b/gold/configure.ac
> @@ -55,16 +55,20 @@ default_ld=
> AC_ARG_ENABLE(ld,
> [[ --enable-ld[=ARG] build ld [ARG={default,yes,no}]]],
> [case "${enableval}" in
> - default)
> - default_ld=ld.bfd
> - ;;
> -esac])
> + no)
> + default_ld=ld.gold
> + ;;
> + esac])
>
> AC_ARG_ENABLE(gold,
> [[ --enable-gold[=ARG] build gold [ARG={default,yes,no}]]],
> [case "${enableval}" in
> - yes|default)
> - if test x${default_ld} = x; then
> + default)
> + install_as_default=yes
> + installed_linker=ld.gold, Ian Lance Taylor <iant@google.com>
> + ;;
> + yes)
> + if test x${default_ld} != x; then
> install_as_default=yes
> fi
> installed_linker=ld.gold
Hi Ian,
Can you take a look at this patch? This problem shows up when
running "make install" under the gold directory. It isn't a problem
when running "make install" under the toplevel directory since
install-ld depends on install-gold.
Thanks.
--
H.J.
next prev parent reply other threads:[~2013-01-07 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:02 H.J. Lu
2013-01-07 17:06 ` H.J. Lu [this message]
2013-01-07 18:41 ` Ian Lance Taylor
2013-01-07 19:32 ` H.J. Lu
2013-01-07 19:48 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOo6607fqPyKqXk38Fcs0FOQuLfLnLdXMdFWb9Zn0bvMCg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).