From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id 1AF9A3858403 for ; Fri, 2 Feb 2024 11:50:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AF9A3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1AF9A3858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706874610; cv=none; b=NqEhosyPRfecA5I1b8fMBd8VtPvV9iWyKs5Pqmtk6ELrIRGQCUGRSGJs9GfR74BdKuSCXmUNhqQjOlRAuRCJjNiPr+5uPiXkAfeR2Miw1LcVuPE4AXDLIc1YhyshpIN81FvtnVfStPb2sVvhruuCJ0ya9xhgbShghNMnOEOgSOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706874610; c=relaxed/simple; bh=4FrZDn31UlDio/G+TDMMzELR8R6Ss2N0NyhTBrChlfA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xTGKkrtd4v8/V9VcDJcLrNu8Ajrh6XxxOBx8bPYXvYkA0aa7reMpJxmaFpLgSg+46crynUSlzArI56O4lCr9S7xkKLnREnZkpHK0eNcFNqe9hRgkHbA0aLGyKnklFdtlTTQ2lMuigSbK6jzlhXYnudVXhDb+8ssTm0td+yd3gdk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-db3a09e96daso1972694276.3 for ; Fri, 02 Feb 2024 03:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706874608; x=1707479408; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2JBWA+8uR2q1R3o27FQlZAnbgei9JZboZwqr3QVUlVA=; b=MlVCWSKYUHOgM9+L1kvBaYbwym/tugqbLAVnZMBxrdxdRaGOk+m6r941BFR6h5LLub y9kIewOn+8HM3FhC3RFYQD9lluIyu3M7qru/ZqA205ZCq1wBbkJ9zbWFPshkNN+nsavT wSLHgKXhcJNTuwWXbc0lY/gSNN5d0MXT7nykPrmt7x6xIagVIrBFamojHThr35JEwQJn agBViEaqK2ztaCsXS9PWJVNadNzI8B9rlbD08yh1/zjPwIsAqNyeV1GDdw88LxykXtEO QoZSl98N8/9G3/cDaOrD7+XOk4lFgJ8kK3Veb8DribLR2tYAAGcYvsW1gtcDyk4ak2Ke LWNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706874608; x=1707479408; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2JBWA+8uR2q1R3o27FQlZAnbgei9JZboZwqr3QVUlVA=; b=gkn7sGSkeEd8+C3xb3JdN/599aZBmP/6lS46frTJXYRbpwIvtXj2E3+Fdw+DL6wPuc hUY1/lhdi4Gldv0/HCO+fKkqkZH17duri2iJnAI9CoNRptbb+3H2s6d7mZ23cdZeRFx2 OSOemBLGInUiWY4/tW0kTqNg9wdvAhBFKYoXreLB0wl6YIrF2YSZOOO2qlt8AOR258hh zm0FMfIr+sK00RlwGr6wTs8abx6uykN8KjZWnzn1SKdl+3QKk9XXIpL8xkb15r+bpP4Q 1eNAvyiTqTq6mt6sb6gJe3RTXs+vKYCGX4P5jepLofbj7WGzYzHHh+lE5z7OtKP9umbB URdg== X-Gm-Message-State: AOJu0YzMvxrwsbR2HNrTmNSPk3bjSUOZiUmVJM/s8HbBbLo1Godf7hdL GLODIpPuiNzyPaSZCOEgWmvYjeFGya3bFHsH8+oBoKIJZGjQ3uppLvgKQeY8L73fDQAZxwalB1Z wTsNaDvrYA5pda5iWR5fsmaunbdZQWRsS X-Google-Smtp-Source: AGHT+IEjg8VmGjwIMDLg39HZT6HLUrX2Xe48CsqJW/2o/lBssUGGTc2uIueCdLrrvjCkSgUb71eLYak4G9LOgOP2HZo= X-Received: by 2002:a25:9782:0:b0:dc6:bb86:ea15 with SMTP id i2-20020a259782000000b00dc6bb86ea15mr7772660ybo.33.1706874608371; Fri, 02 Feb 2024 03:50:08 -0800 (PST) MIME-Version: 1.0 References: <20240202113310.145132-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 2 Feb 2024 03:49:32 -0800 Message-ID: Subject: Re: [PATCH v2] x86: Disallow instructions with length > 15 bytes To: Jan Beulich Cc: wwwhhhyyy333@gmail.com, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 2, 2024 at 3:41=E2=80=AFAM Jan Beulich wrot= e: > > On 02.02.2024 12:33, H.J. Lu wrote: > > --- a/gas/config/tc-i386.c > > +++ b/gas/config/tc-i386.c > > @@ -11780,8 +11780,8 @@ output_insn (const struct last_insn *last_insn) > > { > > j =3D encoding_length (insn_start_frag, insn_start_off, frag_mo= re (0)); > > if (j > 15) > > - as_warn (_("instruction length of %u bytes exceeds the limit = of 15"), > > - j); > > + as_bad (_("instruction length of %u bytes exceeds the limit o= f 15"), > > + j); > > When taking purely a gas perspective, this may be okay. But I'd like > to retain the ability to generate overlong insns (without resorting > to .byte), so there wants to be a way to downgrade the error to a > warning. This is useful in particular when trying to make testcases > for disassemblers or other software decoding insns. > > Jan I am checking it in now and backport it to 2.42 branch. We can add a switch or a directive later to downgrade error to warning. --=20 H.J.