From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 74CB23858002 for ; Tue, 23 Mar 2021 18:33:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 74CB23858002 Received: by mail-oi1-x22b.google.com with SMTP id x2so18044535oiv.2 for ; Tue, 23 Mar 2021 11:33:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xXUSlrlKpVRpBeS8YCLJuyfObmNxBPzeIzv9rvWfWdc=; b=bR4x33I6zoRnCfdBIeuC8cDZrVVIjTc0nUxxQE25REMWpiH2HJ+8W1JuddGIkjxOIw JUvPdi2IrPq/z4HL1x1GmnQEGawhr3NUOZ8ofUzP/CoBBvgTn5fa3JbFXhya0Z3/jszo mX8/YeuY8Vk7OJ+7UlV3HyaYwduHvGumD6oFAV6/B+1gknW66iDpcZ/0nnZV5EP0PDO8 JbzehxK+jNYu2F2Nf4ETdA15cIuRaLe1eU7PC0Qc/QIFKkGrXnGj9q85breDihLhZNk8 vRgHzvvRrFpgIVaVpLlaD69oEBcUY0YlLZN5mfBI3sEcqEleAcOqD4A9qalHJfNujNjr hd7Q== X-Gm-Message-State: AOAM533CIbh5ZGiRwK+SvZzB6/hxwtOo7XRZ5AdIZU4jcRLam/cVa0sD J6DeMm+pEjRKIheJ4ZdVyfLmCaNHQ5r3JRhRM/O8mus4 X-Google-Smtp-Source: ABdhPJz0DALIJ94igq+lyK6i0LVnPGQkOtgW6vY3yXKmZMk/zLfHLIdD8ufCGqbPpLPsfjTgHUzwx08gcfsH49otvVw= X-Received: by 2002:aca:530e:: with SMTP id h14mr4322373oib.79.1616524412951; Tue, 23 Mar 2021 11:33:32 -0700 (PDT) MIME-Version: 1.0 References: <7ba2ee7a-c722-225d-b2eb-d4769de9ad55@suse.com> <66e56e87-11b9-0e9b-7212-a7af318a4eec@suse.com> <53ea9d33-c1e3-10d1-c69d-af00e5b68b69@suse.com> In-Reply-To: <53ea9d33-c1e3-10d1-c69d-af00e5b68b69@suse.com> From: "H.J. Lu" Date: Tue, 23 Mar 2021 11:32:56 -0700 Message-ID: Subject: Re: [PATCH v2] x86: don't use opcode_length to identify pseudo prefixes To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 18:33:34 -0000 On Tue, Mar 23, 2021 at 9:42 AM Jan Beulich wrote: > > This is in preparation of opcode_length going away as a field in the > templates. Identify pseudo prefixes by a base opcode of zero instead: > No real prefix has an opcode of zero. This at the same time allows > dropping a curious special case from i386-gen. > > Since most attributes are identical for all pseudo prefixes, take the > opportunity and also template them. > > gas/ > 2021-03-XX Jan Beulich > > * config/tc-i386.c (parse_insn): Recognize pseudo prefixes by > base_opcode and extension_opcode. > > opcodes/ > 2021-03-XX Jan Beulich > > * i386-gen.c (process_i386_opcode_modifier): Drop IsPrefix > check. > * i386-opc.h (Prefix_*): Move #define-s. > * i386-opc.tbl: Move pseudo prefix enumerator values to > extension opcode field. Introduce pseudopfx template. > * i386-tbl.h: Re-generate. > --- > v2: Introduce PSEUDO_PREFIX and pseudopfx template. > OK. Thanks. -- H.J.