From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 3B3FC385116A for ; Wed, 12 Oct 2022 17:02:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B3FC385116A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x836.google.com with SMTP id g11so5933896qts.1 for ; Wed, 12 Oct 2022 10:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ulPRZbJ7bzpQ6V6+W1EQAfRj/181jvjYO7j9W2FIQrQ=; b=hvsE/6XyyaYAsoUrL8e1I6QnyHDGMgTBDeJ9NaoPHll8fViipZBCGcFg/+BxvjomtW 4Eo5udlHMzT0JN6FOmMgEw0TkLYTcTvtbDlhifdtLAdg5ak8fCU5avIG0DM54KVJLHFj VxmZHeJGnnRlxnTA4dwpbzUakoRfiJq1hoRITrhpkDMrAQU8pjX2UP0eG/5/Sm7DYz9J 9xfY4iC9eh/06J5uVnjk9ieDSXX7v/Xiw2rIhKUdKt8kjPmbkX3B3tiFEheA3P8l+fTb jjB5igX4ubTvAA0hoaqprsn2FA3LSRn6TXPcIwFbpvDx66a5VwiQcLyeLfIBo0zP/dp8 EhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ulPRZbJ7bzpQ6V6+W1EQAfRj/181jvjYO7j9W2FIQrQ=; b=q48suC7eAJU/dEPZJpg7OZ5WbOsHhXtkhS+XltCayJQzYsOPy9bLdTdBtDoTICzgPg iJDvXp48B2JMEHKCfCVxUhkvlm5pAserjMv2XjWURQVPJkgR1+c7fsXylaUaN0m3IL8X Gd23hWGBFKe2iNLRxuy8uh/FxJBfYEFl0wYCTrVmtPZRC0I+AKRJW/uC60iNlDnkdA+i uBz4Jb8Cqfrd3KaYCMI69/357fSq8HAJULqMixT9um5eqiV4JK/D07yK2PW/TFnB56iF 5Us1/+drJIeZNKCFrirLl5yPg8NZe2Cz4jeN2y/RrzrVFCJ5x1bxGIFZlNu8HI20h2zU N8BQ== X-Gm-Message-State: ACrzQf1VcqYSdfjuCpdAKMsOAl3jtiO/oflF3NCs1YXM4tlNmt2s3K4d AInxd1SdHUmQO5yI89qg4ETdcZALqOMmVVLVWoKjheX2 X-Google-Smtp-Source: AMsMyM4K+q4r6K09fNFpk9CPd9roOk8OGALZKnYXYu9Pkk84kyoPdfkdb2isTc3VqCBlB3sGnrFgtoGnpwzGuAgW5pQ= X-Received: by 2002:a05:622a:134b:b0:39a:4442:cbb6 with SMTP id w11-20020a05622a134b00b0039a4442cbb6mr13520135qtk.500.1665594171590; Wed, 12 Oct 2022 10:02:51 -0700 (PDT) MIME-Version: 1.0 References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> <13901424-7999-aeac-c1a2-52baedaa593c@suse.com> In-Reply-To: <13901424-7999-aeac-c1a2-52baedaa593c@suse.com> From: "H.J. Lu" Date: Wed, 12 Oct 2022 10:02:15 -0700 Message-ID: Subject: Re: [PATCH v3 7/7] x86: move bad-use-of-TLS-reloc check To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 12, 2022 at 12:13 AM Jan Beulich wrote: > > On 11.10.2022 19:57, H.J. Lu wrote: > > On Wed, Oct 5, 2022 at 12:25 AM Jan Beulich wrote: > >> > >> Having it in match_template() is unhelpful. Neither does looking for the > >> next template to possibly match make any sense in that case, nor is the > >> resulting diagnostic making clear what the problem is. > >> > >> While moving the check, also generalize it to include all SIMD and VEX- > >> encoded insns. This way an existing conditional can be re-used in > >> md_assemble(). Note though that this still leaves a lof of insns which > >> are also wrong to use with these relocations. > > > > These TLS instruction sequences are generated by compilers. > > The check is only meant to check for invalid master registers. > > The sequence involving a mask register was generated (aiui) by mistake. > Why would it not be possible to see another similar mistake involve an > XMM register, with a legacy, VEX-, or EVEX-encoded insn? We haven't seen it yet. > Anyway - thanks for approving the patch. > > Jan -- H.J.