On Thu, Apr 9, 2020 at 7:44 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi H.J.
>
> > Can you take a look at
> > https://sourceware.org/pipermail/binutils/2020-March/000234.html
>
> Generally the patch looks fine to me, but ... there appear to be some
> linker testsuite regressions for various targets:
>
>   mips-elf:  LD REGRESSION: ld-mips-elf/hash2    [and other mips based targets]
>
>   arm-nto:   LD REGRESSION: Thumb shared library with ARM   [and other arm based targets]
>              LD REGRESSION: Mixed ARM/Thumb shared library
>              LD REGRESSION: Mixed ARM/Thumb dynamic application
>              LD REGRESSION: Mixed ARM/Thumb arch5 dynamic application

Fixed.

> A quick look suggests that these are all due to readelf's output
> changing slightly and the tests not expecting the new format.
>
> Could you take a look and tweak the tests as necessary please ?
>
> Cheers
>   Nick
>
> PS.  Hmm, just noticed that you had already patched the ld-mips-elf/hash2
> test, so I am wondering why it is failing.  The entry in ld.log looks like
> this:
>
>   Executing on host: sh -c {readelf  -d -s -D tmpdir/dump > tmpdir/dump.out 2>dump.tmp}  /dev/null  (timeout = 300)
>   spawn [open ...]
>
>   extra regexps in ld/testsuite/ld-mips-elf/hash2.d starting with "^ +[0-9]+: +[0-9a-f]+ +[0-9]+ +FUNC +GLOBAL +DEFAULT +([1-9]|PRC) __start$"
>   EOF from tmpdir/dump.out
>   FAIL: ld-mips-elf/hash2
>
> Is it possible that your revision of the original patch now makes this test fail ?
>

readelf never outputs PRC.  It outputs PRC[0xff02].   It is
fixed in this updated version.  OK for master?

-- 
H.J.