From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id DD9F13858D1E for ; Thu, 18 Aug 2022 15:30:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD9F13858D1E Received: by mail-qk1-x72a.google.com with SMTP id f4so1355754qkl.7 for ; Thu, 18 Aug 2022 08:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=BYk+JbPTcrz5B8Ev/MS3sOYU0rs2Oae4mHgnOTXKMys=; b=YL9/m6PLmWsj9FNdxgArUnn3RLETy3XFzCdBC6V61Q09ozXkIOMvysb8gZTrHfIEQF +XnXZVOYpvgpR4o7HYatyO84JaTROWAsZf9xRqTj6ag45rkA+RbjVxkTEThVUa4vVPso xolOvbbZgU5s3aN/bJYys7xv+Svc28mmzcq09gWV5x0D+TjLYOzVBTBi3yqvgNaHY2ZM ZnAkoaVw7/5ApNc1sVudafqLgCJYnEogknteAEMv5C6VhA4QjLnl2TAZd0xU2ecFuU6x UxZhbg4zmCm8KuQ7WF3nysTkZuMJBdp5iw9yTib/pJhHNGeaLJEycNG+kESZFexzAsaA vszA== X-Gm-Message-State: ACgBeo3h5GTjXmK3L7k81JG8W4cDszZUfCIN5g2M/E6FYlArqywn0GW/ o3vTVTc7f2QxTJkBfftJE1/ozmA0vrRW4cO2ySM= X-Google-Smtp-Source: AA6agR5Aa6mRR5ma48OFzq0Pjk5fWYl1/pNHl4Fl0AKzibazd4CGaeE/cbtfE7STuoImfRKGlQw+jfXRVuW7Sr4afFs= X-Received: by 2002:a05:620a:254d:b0:6ab:84b8:25eb with SMTP id s13-20020a05620a254d00b006ab84b825ebmr2477920qko.383.1660836644180; Thu, 18 Aug 2022 08:30:44 -0700 (PDT) MIME-Version: 1.0 References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> <8e4dc724-3516-6ec7-5a6b-70ed70e3e237@suse.com> <6db15eed-88f1-cfaa-9650-bc15b18f665d@suse.com> In-Reply-To: <6db15eed-88f1-cfaa-9650-bc15b18f665d@suse.com> From: "H.J. Lu" Date: Thu, 18 Aug 2022 08:30:08 -0700 Message-ID: Subject: Re: [PATCH 3/7] x86: move / quiesce pre-386 non-16-bit warning To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 15:30:47 -0000 On Thu, Aug 18, 2022 at 12:21 AM Jan Beulich wrote: > > On 17.08.2022 21:21, H.J. Lu wrote: > > On Tue, Aug 16, 2022 at 12:31 AM Jan Beulich wrote: > >> > >> Emitting this warning for every insn, including ones having actual > >> errors, is annoying. Introduce a boolean variable to emit the warning > >> just once on the first insn after .arch may have changed the things, and > >> move the warning to output_insn(). (I didn't want to go as far as > >> checking whether the .arch actually turned off the i386 bit, but doing > >> so would be an option.) > >> --- > >> Otoh I wonder whether switching to a pre-386 architecture shouldn't > >> automatically move to CODE_16BIT: Us emitting operand- or address-size > >> prefixes violates the architecture specification. Alternatively we > >> could outright reject such .arch directives when not already in 16-bit > >> mode. > > Mind me asking - no opinion here? We shouldn't change the current behavior to avoid any surprises. > > OK. > > Thanks. > > Jan -- H.J.