From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id CC8C63857C45 for ; Tue, 6 Dec 2022 03:40:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC8C63857C45 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x236.google.com with SMTP id n205so15514303oib.1 for ; Mon, 05 Dec 2022 19:40:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vlgHj8csgglrDF0GnAEfc0rzIWVIkAPlT+ZSBPSoWqc=; b=YmVPr+R27uzFtSk9xk7HbNbW82UodRDVQhGR+i79GVdwrM5L4Mg4LdoscbbbmkaNUh qTpg3iwf1GbIyTt5g0CZ2wWsEqVKuWz7BQQkYu0pnzvVhE+LZy207PuZ1O5vkdTFi+m5 GBfnPZnn/fhwflGrU9qx8jpYwl7ZnW2JcC+KihRUsnhXlnPnBe2Z/UZ1g30dPZ7c7Tze +WyquuY97+ffFeA0KC75LxJ2dUI6oU2ShukpG3wlZ8erXyKmIgERGm34s9sI1N8P/soT YyR10erylFIFjCLXZzJBsr3YwMBN9Zo7Hgu8ywFu6QjTGYrmLcCgNbODU5U3TstxK6JO AVGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vlgHj8csgglrDF0GnAEfc0rzIWVIkAPlT+ZSBPSoWqc=; b=dDxcNF96RqZ9sWKlgJwGwdYI1HY7ww0UMU47sNS14FpcBQmlMNopj2ACLVF4PWpkq/ zsV8Pj2M6iwmUM2HJowkMolYES9JVg2hpnDqoN8/1EANeKKSmUcPqwkOeHSfo6oldeus 57AArlpS8jWJElLLCvkm7LznX0KIePzcPhuDP4TnoIZK8etFIAxZFZrTAxJRzeR5LFNO BeuSdO2jpwmNbwLcwXAaML2H/GFUnGvYXDMxWygak9x2DKYJWKONKYcr+fXh7bzbi1UD XTa+zgw+rSL5RAEgBGa78YeOxf90FXq17Tyitx0e18VeqyZlFz/47smNTvlHctZzms5T CVcg== X-Gm-Message-State: ANoB5pniOHVw9uZOc3TLJM7OAy7A7FT6ECun8xqWwKTzh1JqEBEbM+AU zRmiO8rQF5z1bV3049WH7kIUwnGG3pjTkcqgmhE= X-Google-Smtp-Source: AA0mqf48s83iSP/D/gfmyRrb2GDwTnfvuG3YHg5j384qvn0647Yc3oitAhmhpyGggaP8C7kOwruz30TmyaQpCzoX5qw= X-Received: by 2002:a05:6808:22a0:b0:35b:c6c4:7a33 with SMTP id bo32-20020a05680822a000b0035bc6c47a33mr15143765oib.266.1670298007030; Mon, 05 Dec 2022 19:40:07 -0800 (PST) MIME-Version: 1.0 References: <20221205025311.73743-1-haochen.jiang@intel.com> <18459a42-b4a4-00b0-b00d-04ce01b1de34@suse.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 5 Dec 2022 19:39:31 -0800 Message-ID: Subject: Re: [PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler To: "Jiang, Haochen" Cc: "Beulich, Jan" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 5, 2022 at 5:36 PM Jiang, Haochen wrote: > > > > Another reason for removing this check is because xh_mode with > > > broadcast usage should not indicate the vex.w bit. Instead it should > > > be handled by a W table entry. > > > > There are no broadcast insns using xh_mode, and you can't really mean > > embedded broadcast (because EVEX.W needs to be properly encoded > > there). > > Hence I don't follow what you're talking about here. > > Maybe this part is a little misleading. I will delete that in commit message. > What I actually mean is just like what you commented. > > I suppose using a W table entry in the future to encode here if not using > something like %XH. If vex.w == 1 check is removed, disassembler will display the wrong instruction. > Haochen > > > > > The code change is okay, but if the above is to become the commit > > message, the raised question will need addressing first. > > > > Jan -- H.J.