From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 9B614385840D for ; Tue, 23 Apr 2024 16:13:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B614385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B614385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713888841; cv=none; b=LFflBtozDJ9LUZqo4TSqQR5Rmvh4AGzeHxM5HguCvT5M5JC/xHR3LTzmU1xw/PLEcoaykvkvgSk9SyDXAOO7/Vg/38cm7mC9iZhKYWw1FaB2lZ7sopaDJDXazRJF8U9pXTA7pEuxPSRTaElh3OOc8Rb/3RcO7i1UFaiPK18QrxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713888841; c=relaxed/simple; bh=XkXrn557crRmv2Jt1qG+l+/bs6bGXEFxnDniLcnzzcU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=iuRKY+CfNzeL9scWuT0fhFASgM32MleP/iBDWyM2X8Sf8bZUe+WXZ0UGbnO78AEyl6G/GOl8Sbc9Ck3rgIIhdtbtDp7JIKFt1m+1YQhPx1cG69gVAoVGEZ1h1xyWhgEzxUnV3PIjAbP1qXAKNuhrVFJSG6khSfArwdW7VUPLazY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-dc6dcd9124bso5496353276.1 for ; Tue, 23 Apr 2024 09:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713888837; x=1714493637; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dVKLv/6CpIkTIK0VJsLkv8AtCcVWmkFlFzz6bBpGwng=; b=f7fc9PxvDdQ1osL81lqnlO3DXSS9pnjHgrakaIMPIywn5g1RIAKiKeZUsPUS3SthX4 WHIB/dSRq+340ed6BjddhMNrTxuUTF/S299N0PGsNuqEJFcfwelsJF4JrJefecuWgulF FaprHgsA67KVqdeAv6ghmVrTEJIhYBXQ+f115YE2JPZeenq4UXWbl9gbKg/S8c+56UEi pYrp0a7+fTWGqUezITJfkZtwujLNYIciwXHAvqYSWWf9yMvGNRUsOOO1059tPtihLKns d8x/e+rL0Frzibc4tsVkkOgdTss3qVobRo9qJ5nYZv4kkkPFrmFW/vbK2zQCWKDalBXt unjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713888837; x=1714493637; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dVKLv/6CpIkTIK0VJsLkv8AtCcVWmkFlFzz6bBpGwng=; b=w7ZeVFc+u9yUaU8KxN1gmyyMAYga7xvaIbQki6miRnhbpCeN9A0Tqgl2zSsaQEVY1A FXwuS/+TSzkS4nfG6eFOEIjefkeoHD20QucN5/C7GOwE7f0APwAAe8KXZ7meU3iXAKsS PgZBIrDpB8O/Q0wqUrwjvZLN9rsny/l53V4UgWqr/n54f8zrLQ16SP5PzkDSD3KXOx7w w2ANmN/a3am480deqdQCQDGRnJxmAtfg51Q+zgmDXuTZaIGx9ngp1I+THXMdDnakEPkA 1m/y4E18E6HlJP01mLpWtv3D+VchPbO7lK1KSR3lvVws5YVMK0fgDECTKOFSGxNvDXBk o4nA== X-Gm-Message-State: AOJu0YzVG0JwY6WnK0Bt8ICAN/AP+RFlD8PxCQytie88QxS+QWCdjvA1 kupEfTz+ue67ek/L6AKkBMSEyM4YbsJPmzJliMQPcRAGBCXUpyzevzUVoaDar4w282knPlORnek AdJyb3RpEntJlXwyww+Ozw5Apnn0= X-Google-Smtp-Source: AGHT+IEu8VC+OQidXoV60/fMr1msVLaZCB/2S6Avn/P3MRyP81hfrO3zT3NnF1pHePp7r45wP2La7bkHwAXx7LqIu0k= X-Received: by 2002:a25:830b:0:b0:ddd:6964:40c with SMTP id s11-20020a25830b000000b00ddd6964040cmr6075ybk.50.1713888836835; Tue, 23 Apr 2024 09:13:56 -0700 (PDT) MIME-Version: 1.0 References: <20240418122856.190234-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 23 Apr 2024 09:13:20 -0700 Message-ID: Subject: Re: [PATCH] elf: Strip unreferenced weak undefined symbols To: Alexandre Oliva Cc: binutils@sourceware.org, hainque@adacore.com Content-Type: multipart/mixed; boundary="0000000000004e29f90616c5d739" X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004e29f90616c5d739 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 21, 2024 at 10:50=E2=80=AFPM Alexandre Oliva wr= ote: > > Thanks again for the patch. > > Olivier pointed out that a comment you moved had a duplicate word, and > suggested removing it. Ok to install? > > From: Olivier Hainque > Date: Mon, 22 Apr 2024 05:30:38 +0000 > > Remove duplicate word. > > for bfd/ChangeLog > > PR ld/31652 > * elflink.c (_bfd_elf_link_output_relocs): Drop duplicate word. > --- > bfd/elf-vxworks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bfd/elf-vxworks.c b/bfd/elf-vxworks.c > index 36e5540f9c04..5d91913f097f 100644 > --- a/bfd/elf-vxworks.c > +++ b/bfd/elf-vxworks.c > @@ -186,7 +186,7 @@ elf_vxworks_emit_relocs (bfd *output_bfd, > library. We are creating a definition in the output > file but it does not come from any of our normal (.o= ) > files. ie. a PLT stub. Normally this would be a > - relocation against against SHN_UNDEF with the VMA of > + relocation against SHN_UNDEF with the VMA of > the PLT stub. This upsets the VxWorks loader. > Convert it to a section-relative relocation. This > gets some other symbols (for instance .dynbss), but > -- > 2.25.1 > I am checking in this as an obvious fix. --=20 H.J. --0000000000004e29f90616c5d739 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-bfd-Remove-duplicate-word-in-elf-vxworks.c.patch" Content-Disposition: attachment; filename="0001-bfd-Remove-duplicate-word-in-elf-vxworks.c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvcl4bya0 RnJvbSA5YjQ0MWM0MTVjNTU2ZTYwOGUyMmNiOWQxNmI1MDA5OTJhOTcyYjBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGl2aWVyIEhhaW5xdWUgPGhhaW5xdWVAYWRhY29yZS5jb20+ CkRhdGU6IE1vbiwgMjIgQXByIDIwMjQgMDI6NTA6MjggLTAzMDAKU3ViamVjdDogW1BBVENIXSBi ZmQ6IFJlbW92ZSBkdXBsaWNhdGUgd29yZCBpbiBlbGYtdnh3b3Jrcy5jCgoJUFIgbGQvMzE2NTIK CSogZWxmLXZ4d29ya3MuYyAgKGVsZl92eHdvcmtzX2VtaXRfcmVsb2NzKTogRHJvcCBkdXBsaWNh dGUgd29yZC4KLS0tCiBiZmQvZWxmLXZ4d29ya3MuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2JmZC9lbGYtdnh3b3Jr cy5jIGIvYmZkL2VsZi12eHdvcmtzLmMKaW5kZXggMzZlNTU0MGY5YzAuLjVkOTE5MTNmMDk3IDEw MDY0NAotLS0gYS9iZmQvZWxmLXZ4d29ya3MuYworKysgYi9iZmQvZWxmLXZ4d29ya3MuYwpAQCAt MTg2LDcgKzE4Niw3IEBAIGVsZl92eHdvcmtzX2VtaXRfcmVsb2NzIChiZmQgKm91dHB1dF9iZmQs CiAJCSAgICAgbGlicmFyeS4gIFdlIGFyZSBjcmVhdGluZyBhIGRlZmluaXRpb24gaW4gdGhlIG91 dHB1dAogCQkgICAgIGZpbGUgYnV0IGl0IGRvZXMgbm90IGNvbWUgZnJvbSBhbnkgb2Ygb3VyIG5v cm1hbCAoLm8pCiAJCSAgICAgZmlsZXMuIGllLiBhIFBMVCBzdHViLiAgTm9ybWFsbHkgdGhpcyB3 b3VsZCBiZSBhCi0JCSAgICAgcmVsb2NhdGlvbiBhZ2FpbnN0IGFnYWluc3QgU0hOX1VOREVGIHdp dGggdGhlIFZNQSBvZgorCQkgICAgIHJlbG9jYXRpb24gYWdhaW5zdCBTSE5fVU5ERUYgd2l0aCB0 aGUgVk1BIG9mCiAJCSAgICAgdGhlIFBMVCBzdHViLiAgVGhpcyB1cHNldHMgdGhlIFZ4V29ya3Mg bG9hZGVyLgogCQkgICAgIENvbnZlcnQgaXQgdG8gYSBzZWN0aW9uLXJlbGF0aXZlIHJlbG9jYXRp b24uICBUaGlzCiAJCSAgICAgZ2V0cyBzb21lIG90aGVyIHN5bWJvbHMgKGZvciBpbnN0YW5jZSAu ZHluYnNzKSwgYnV0Ci0tIAoyLjQ0LjAKCg== --0000000000004e29f90616c5d739--