From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Binutils <binutils@sourceware.org>, Michael Matz <matz@suse.de>
Subject: Re: [committed, PATCH] Remove Disp16|Disp32 from 64-bit direct branches
Date: Mon, 18 May 2015 11:22:00 -0000 [thread overview]
Message-ID: <CAMe9rOoWCn0xMZ5+n1MKDGdpXjqk9G0XUh1fp-HBaRE2Vn7kkg@mail.gmail.com> (raw)
In-Reply-To: <5559AB3F020000780007AE54@mail.emea.novell.com>
On Mon, May 18, 2015 at 12:05 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 15.05.15 at 18:52, <hjl.tools@gmail.com> wrote:
>> * i386-opc.tbl: Add direct call/jmp with Disp16|Disp32 for AMD64.
>> Mark direct call/jmp without Disp16|Disp32 as Intel64.
>
> I had hoped that you wouldn't add back Disp32 to the AMD case, and
This is what I checked in.
> perhaps also that CpuAMD64 and CpuIntel64 would imply Cpu64 (as
> their names already suggest).
They are just a bit. Make them to implement Cpu64 means adding more
codes to x86 assembler without any benefit. If you can share with me
what you have in mind, I will see what I can do.
--
H.J.
----
* i386-opc.tbl: Remove Disp32 from AMD64 direct call/jmp.
* i386-init.h: Regenerated.
---
opcodes/ChangeLog | 5 +++++
opcodes/i386-opc.tbl | 4 ++--
opcodes/i386-tbl.h | 4 ++--
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index d3f914c..ef05d2d 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-18 H.J. Lu <hongjiu.lu@intel.com>
+
+ * i386-opc.tbl: Remove Disp32 from AMD64 direct call/jmp.
+ * i386-init.h: Regenerated.
+
2015-05-15 H.J. Lu <hongjiu.lu@intel.com>
PR binutis/18386
diff --git a/opcodes/i386-opc.tbl b/opcodes/i386-opc.tbl
index 56eddbf..42dcb56 100644
--- a/opcodes/i386-opc.tbl
+++ b/opcodes/i386-opc.tbl
@@ -319,7 +319,7 @@ shrd, 2, 0xfad, None, 2, Cpu386,
Modrm|CheckRegSize|No_bSuf|No_sSuf|No_ldSuf, {
// Control transfer instructions.
call, 1, 0xe8, None, 1, CpuNo64,
JumpDword|DefaultSize|No_bSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Disp16|Disp32 }
-call, 1, 0xe8, None, 1, Cpu64|CpuAMD64,
JumpDword|DefaultSize|No_bSuf|No_lSuf|No_sSuf|No_ldSuf|NoRex64|BNDPrefixOk,
{ Disp16|Disp32|Disp32S }
+call, 1, 0xe8, None, 1, Cpu64|CpuAMD64,
JumpDword|DefaultSize|No_bSuf|No_lSuf|No_sSuf|No_ldSuf|NoRex64|BNDPrefixOk,
{ Disp16|Disp32S }
call, 1, 0xe8, None, 1, Cpu64|CpuIntel64,
JumpDword|DefaultSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_ldSuf|NoRex64|BNDPrefixOk,
{ Disp32S }
call, 1, 0xff, 0x2, 1, CpuNo64,
Modrm|DefaultSize|No_bSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Reg16|Reg32|Word|Dword|Unspecified|BaseIndex|Disp8|Disp16|Disp32|JumpAbsolute
}
call, 1, 0xff, 0x2, 1, Cpu64,
Modrm|DefaultSize|No_bSuf|No_lSuf|No_sSuf|No_ldSuf|NoRex64|BNDPrefixOk,
{ Reg16|Reg64|Word|Qword|Unspecified|BaseIndex|Disp8|Disp32|Disp32S|JumpAbsolute
}
@@ -331,7 +331,7 @@ lcall, 2, 0x9a, None, 1, CpuNo64,
JumpInterSegment|DefaultSize|No_bSuf|No_sSuf|N
lcall, 1, 0xff, 0x3, 1, 0,
Modrm|DefaultSize|No_bSuf|No_sSuf|No_qSuf|No_ldSuf, {
Unspecified|BaseIndex|Disp8|Disp16|Disp32|Disp32S|JumpAbsolute }
jmp, 1, 0xeb, None, 1, CpuNo64,
Jump|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Disp8|Disp16|Disp32|Disp32S }
-jmp, 1, 0xeb, None, 1, Cpu64|CpuAMD64,
Jump|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Disp8|Disp16|Disp32|Disp32S }
+jmp, 1, 0xeb, None, 1, Cpu64|CpuAMD64,
Jump|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Disp8|Disp16|Disp32S }
jmp, 1, 0xeb, None, 1, Cpu64|CpuIntel64,
Jump|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Disp8|Disp32S }
jmp, 1, 0xff, 0x4, 1, CpuNo64,
Modrm|No_bSuf|No_sSuf|No_qSuf|No_ldSuf|BNDPrefixOk, {
Reg16|Reg32|Word|Dword|Unspecified|BaseIndex|Disp8|Disp16|Disp32|JumpAbsolute
}
jmp, 1, 0xff, 0x4, 1, Cpu64,
Modrm|No_bSuf|No_lSuf|No_sSuf|No_ldSuf|NoRex64|BNDPrefixOk, {
Reg16|Reg64|Word|Qword|Unspecified|BaseIndex|Disp8|Disp32|Disp32S|JumpAbsolute
}
next prev parent reply other threads:[~2015-05-18 11:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 21:23 H.J. Lu
2015-05-12 10:41 ` Jan Beulich
2015-05-12 11:54 ` H.J. Lu
2015-05-12 12:20 ` Jan Beulich
2015-05-12 12:37 ` H.J. Lu
2015-05-12 13:03 ` Jan Beulich
2015-05-12 13:37 ` H.J. Lu
2015-05-12 13:49 ` Michael Matz
2015-05-12 13:57 ` H.J. Lu
2015-05-12 14:31 ` Michael Matz
2015-05-12 14:49 ` H.J. Lu
2015-05-12 15:14 ` Michael Matz
2015-05-12 15:21 ` H.J. Lu
2015-05-12 15:32 ` Michael Matz
2015-05-12 14:59 ` Jan Beulich
2015-05-12 15:03 ` H.J. Lu
2015-05-12 15:09 ` Jan Beulich
2015-05-12 15:11 ` H.J. Lu
2015-05-12 15:17 ` Jan Beulich
2015-05-12 15:37 ` Michael Matz
2015-05-12 15:43 ` H.J. Lu
2015-05-12 15:47 ` Michael Matz
2015-05-12 16:00 ` H.J. Lu
2015-05-12 16:03 ` Michael Matz
2015-05-12 16:08 ` H.J. Lu
2015-05-13 6:18 ` Jan Beulich
2015-05-13 11:35 ` H.J. Lu
2015-05-13 12:27 ` Jan Beulich
2015-05-13 13:15 ` H.J. Lu
2015-05-13 12:34 ` Michael Matz
2015-05-13 13:32 ` H.J. Lu
2015-05-13 16:50 ` Maciej W. Rozycki
2015-05-13 16:53 ` H.J. Lu
2015-05-15 6:39 ` Jan Beulich
2015-05-15 16:52 ` H.J. Lu
2015-05-18 7:05 ` Jan Beulich
2015-05-18 11:22 ` H.J. Lu [this message]
2015-05-18 11:48 ` Jan Beulich
2015-05-18 12:18 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoWCn0xMZ5+n1MKDGdpXjqk9G0XUh1fp-HBaRE2Vn7kkg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=macro@linux-mips.org \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).