From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 6A56D3858022 for ; Thu, 14 Jan 2021 20:37:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A56D3858022 Received: by mail-oo1-xc2f.google.com with SMTP id j8so1691802oon.3 for ; Thu, 14 Jan 2021 12:37:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=uQprGAf6xlqsY9y5rGelg9W3Rs5jA4hos0PHoByXOiU=; b=SULGW/79FM8blCLCfaoecF+pZjTygQreIT+hKTIBy5KhT5hgl3n0pmoCRVOGH1p6BK pjOjLnQALc/L6Dpk5IqsaH9aYmef0+fvGt9w/9qtpHShDTtcLbcXY6Y2Nxhl/guaMjIy BE94o/0VFxI8OOioBRhK/5HGEVjVId9wrPb3kQt+UUdQpxdGim+O6PFGIvBoX5rhXt6N cqH/k/gBIkf7R3IpRhM8AMO7JoNM224PaoF8S2G4s3g1+YDd8N+pBbgK6AzPwzROCWWk CJzlwkpEdEBESXD8udr4PoPOl2OTFfPa0ri5ZHY7EOPQ7M8B/SGgaOIFuBcuUkt0mZbl HMuQ== X-Gm-Message-State: AOAM530TLH4GLV2N+wTHwrxLjsbMRFrricoX49n6cOd64hKuPkRX4h3k rBTBP+puEqS2GImtobxEkTL6TBL7dCb/e7hmO3g= X-Google-Smtp-Source: ABdhPJwcVkXmC60LuxhsTW8eocoa/AzWiEcr5WxgELFRMLHanEKBCI3cwE5o734yH2K1nEqm9m3mUrQPYBH0nxbbtjA= X-Received: by 2002:a05:6820:100e:: with SMTP id v14mr5875000oor.58.1610656644867; Thu, 14 Jan 2021 12:37:24 -0800 (PST) MIME-Version: 1.0 References: <20210113124155.3240078-1-hjl.tools@gmail.com> <20210114060002.GI6938@vapier> <20210114202730.GL6938@vapier> In-Reply-To: <20210114202730.GL6938@vapier> From: "H.J. Lu" Date: Thu, 14 Jan 2021 12:36:48 -0800 Message-ID: Subject: Re: [PATCH] bfin: Skip non SEC_ALLOC section for R_BFIN_FUNCDESC To: Nick Clifton , Alexandre Oliva , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3030.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 20:37:26 -0000 On Thu, Jan 14, 2021 at 12:27 PM Mike Frysinger wrote: > > On 14 Jan 2021 05:28, H.J. Lu via Binutils wrote: > > On Wed, Jan 13, 2021 at 10:00 PM Mike Frysinger wrote: > > > On 13 Jan 2021 04:41, H.J. Lu via Binutils wrote: > > > > Linker should never generate dynamic relocations for relocations in > > > > non-SEC_ALLOC section which has no impact on run-time behavior. Such > > > > relocations should be resolved to 0. > > > > > > does elf32-frv.c need the same fix ? kind of looks like it. > > > > Yes. FRV maintainers need to take a look. > > well, didn't you merge this ? :) > frv: Don't generate dynamic relocation for non SEC_ALLOC sections > > > There are many code/bug duplications in FDPIC support. > > They should be merged. > > to be fair, Blackfin copied FRV :). we owe a ton to FRV wrt FDPIC in the > toolchain & kernel. > > i took a look a while ago about trying to factor things out at least in > gdb, but it got so invasive, and i didn't have FRV to verify against, > that i ended up shelving it. > > i'd feel similarly about such large refactors in bfd. not sure how to > even structure it. would we create files like fdpic.c/fdpic32.c ? > -mike Take a look at elfxx-x86.[ch] to see how I merged common parts of i386 and x86-64. -- H.J.