From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 79DDF3858C39 for ; Wed, 3 Aug 2022 17:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79DDF3858C39 Received: by mail-pg1-x52f.google.com with SMTP id r186so15664239pgr.2 for ; Wed, 03 Aug 2022 10:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EH4/Osznik+Sg9Qkf9ckkCeo5+8aa+Ginf2fdFnmA/4=; b=mMIenmotk98BaeRZh3LLk/AaIaOH8VJAickK2psxzpiS1I0QjGp+tpNzJIK8twVFXj cOhDs1uSfU0EcvlBDJxGTLI9UYYBorib6kcymz3QetBENmcXHvpNOz7cNzvX6fV7A4G6 RjKvV3z22yXJbd8Madv1KGmc59ChBN50mm5SPINIJSfTg3Tvlr/4PXLzDHxIwiDjDoEt bnb9ORdJKH8C80yEJbmf0/O6yHdhCHWVlV6dcBt5Q5s/JJXi+mTdc3m0PyISbMIrcTjv xQ6P/5jPh++K6g5rCZzYuFjdo4GelaTD2mSutTdCilqrnAK1TLzlBIXg0OXdPtlgttSn alEg== X-Gm-Message-State: ACgBeo1HttMyR0ADqGr226U/IuqdAoSXT96KFjabnir693WuYsv9eV/b d6VLN+C16jqhZR/u58NRqYW/bYkEb+74EXMx6BQ3uFZiskA= X-Google-Smtp-Source: AA6agR72u7hd+T5omJRWqrLtaDKvTKv8g0C+qic5SY2tyJuMswhOVdmkenS1EuADaH7EMCkOq8CvNDy9norCta1gYXk= X-Received: by 2002:a05:6a00:158a:b0:52e:5e04:6bf with SMTP id u10-20020a056a00158a00b0052e5e0406bfmr646502pfk.64.1659546438433; Wed, 03 Aug 2022 10:07:18 -0700 (PDT) MIME-Version: 1.0 References: <20220801231122.2503979-1-hjl.tools@gmail.com> <8e49a184-c4f1-7156-044b-5940a2b1a204@suse.com> In-Reply-To: <8e49a184-c4f1-7156-044b-5940a2b1a204@suse.com> From: "H.J. Lu" Date: Wed, 3 Aug 2022 10:06:42 -0700 Message-ID: Subject: Re: [PATCH] elf: Reset alignment for each PT_LOAD segment To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 17:07:20 -0000 On Wed, Aug 3, 2022 at 1:45 AM Jan Beulich wrote: > > On 02.08.2022 01:11, H.J. Lu via Binutils wrote: > > --- a/bfd/elf.c > > +++ b/bfd/elf.c > > @@ -5439,7 +5439,7 @@ assign_file_positions_for_load_sections (bfd *abfd, > > file_ptr off; /* Octets. */ > > bfd_size_type maxpagesize; > > bfd_size_type p_align; > > - bool p_align_p = false; > > + bool p_align_p; > > Wouldn't it be helpful / good practice to also move the two variables Good point. > into the loop's scope (and then using initializers in favor of > assignments)? Okay preferably with that adjustment. > > Jan This is the patch I am checking in: https://sourceware.org/pipermail/binutils/2022-August/122191.html Thanks. -- H.J.