From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115325 invoked by alias); 2 Apr 2019 12:32:23 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 115107 invoked by uid 89); 2 Apr 2019 12:32:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:8356656, H*i:sk:8356656, HX-Languages-Length:2064 X-HELO: mail-oi1-f196.google.com Received: from mail-oi1-f196.google.com (HELO mail-oi1-f196.google.com) (209.85.167.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Apr 2019 12:32:21 +0000 Received: by mail-oi1-f196.google.com with SMTP id a6so6908851oie.5 for ; Tue, 02 Apr 2019 05:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bQBnxSuyvz/I4yD7WMHk63DI6VuoRkEyvIHJZb3AdIM=; b=Hk5tz0Sv5TYmBz+wGBWpYN1ljlRP1o1RLTCQkvz2kK4f0X1G6zRbXzC4SlSeS5O9z7 rBJIZFo/YExj/YzoapOYE0U6OA+MtNoTuQ1iLTL0pDyLxxah3hPMgxY3s2Yp5UmKVoaM dJOaSGV59WqxSJWiwoK4yNM6YdIsCvJT38WE7/jAnaVtjSy/HcWI+bMAbb0e+C+hnMaV od8ePSx/i8xN3Ox8zKdU79bTyrW5PZwLluG6pTZPpphfSYmdAKk6vGgllndUIs3JQPTa WhK9B6geutzONklxuTZTPZtUk83EpuLNHtsDOuspFudtLe793QTgzcd/23bN6db0k8jY I5vg== MIME-Version: 1.0 References: <27c4cd1c-2126-6e31-3faa-a7c31a4e67e1@arm.com> <8356656c-d50f-8be0-cdfa-8c4c6a4c5313@arm.com> In-Reply-To: <8356656c-d50f-8be0-cdfa-8c4c6a4c5313@arm.com> From: "H.J. Lu" Date: Tue, 02 Apr 2019 12:32:00 -0000 Message-ID: Subject: Re: [PATCH, BFD, AArch64, x86] Improve warning for --force-bti. To: Sudakshina Das Cc: "nickc@redhat.com" , "binutils@sourceware.org" , nd , Ramana Radhakrishnan , Richard Earnshaw Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00005.txt.bz2 On Tue, Apr 2, 2019 at 2:05 AM Sudakshina Das wrote: > > Hi HJ > > On 01/04/2019 20:26, H.J. Lu wrote: > > On Thu, Mar 21, 2019 at 9:25 AM Sudakshina Das wrote: > >> > >> Hi Nick > >> > >> On 21/03/2019 15:14, Nick Clifton wrote: > >>> Hi Sudi, > >>> > >>>> *** bfd/ChangeLog *** > >>>> > >>>> 2019-xx-xx Sudakshina Das > >>>> > >>>> * elf-bfd.h (struct elf_backend_data): Add argument to > >>>> merge_gnu_properties. > >>>> * elf-properties.c (elf_merge_gnu_properties): Add argument to > >>>> itself and while calling bed->merge_gnu_properties. > >>>> (elf_merge_gnu_property_list): Update the calls for > >>>> elf_merge_gnu_properties. > >>>> * elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update handling > >>>> of --force-bti warning and add argument. > >>>> * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties): Add > >>>> warning. > >>>> * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Add argument. > >>>> * elfxx-x86.h (_bfd_x86_elf_merge_gnu_properties): Likewise in > >>>> declaration. > >>>> > >>>> *** ld/ChangeLog *** > >>>> > >>>> 2019-xx-xx Sudakshina Das > >>>> > >>>> * testsuite/ld-aarch64/aarch64-elf.exp: Add new test. > >>>> * testsuite/ld-aarch64/bti-plt-1.s: Add .ifdef for PAC note section. > >>>> * testsuite/ld-aarch64/bti-plt-6.d: Update warning. > >>>> * testsuite/ld-aarch64/bti-plt-7.d: Likewise. > >>>> * testsuite/ld-aarch64/bti-warn.d: New test. > >>> > >>> Approved - please apply. > >> > >> Thanks for the approval. Committed as > >> 4e5391148d51c58785aad637f1a92d47b91b3ae6 > >> > >> Sudi > >> > > > > Isn't --force-bti for ELF only? Shouldn't it use "-z force-bti"? > > Sorry I was not aware of any elf specific meaning given to -z. Is this a > convention? I can not seem to find any particular documentation for it. > This is the convention. See how PARSE_AND_LIST_ARGS_CASE_Z is used. You can also define PARSE_AND_LIST_OPTIONS to update "ld --help". -- H.J.