public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry
@ 2020-04-25 15:24 H.J. Lu
  2020-05-01 15:51 ` H.J. Lu
  0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2020-04-25 15:24 UTC (permalink / raw)
  To: binutils

Increment plt_offset after setting the reserved TLSDESC PLT entry.

	PR gold/25872
	* x86_64.cc (Output_data_plt_x86_64_bnd::do_write): Increment
	plt_offset after setting the reserved TLSDESC PLT entry.
	(Output_data_plt_x86_64_ibt<size>::do_write): Likewise.
---
 gold/x86_64.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gold/x86_64.cc b/gold/x86_64.cc
index b094e4bd3b..a0247b5707 100644
--- a/gold/x86_64.cc
+++ b/gold/x86_64.cc
@@ -2764,6 +2764,7 @@ Output_data_plt_x86_64_bnd::do_write(Output_file* of)
       this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
 			       tlsdesc_got_offset, plt_offset);
       pov += this->get_plt_entry_size();
+      plt_offset += plt_entry_size;
     }
 
   // Write the additional PLT.
@@ -2859,6 +2860,7 @@ Output_data_plt_x86_64_ibt<size>::do_write(Output_file* of)
       this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
 			       tlsdesc_got_offset, plt_offset);
       pov += this->get_plt_entry_size();
+      plt_offset += plt_entry_size;
     }
 
   // Write the additional PLT.
-- 
2.25.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry
  2020-04-25 15:24 [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry H.J. Lu
@ 2020-05-01 15:51 ` H.J. Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2020-05-01 15:51 UTC (permalink / raw)
  To: Binutils

On Sat, Apr 25, 2020 at 8:24 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Increment plt_offset after setting the reserved TLSDESC PLT entry.
>
>         PR gold/25872
>         * x86_64.cc (Output_data_plt_x86_64_bnd::do_write): Increment
>         plt_offset after setting the reserved TLSDESC PLT entry.
>         (Output_data_plt_x86_64_ibt<size>::do_write): Likewise.
> ---
>  gold/x86_64.cc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gold/x86_64.cc b/gold/x86_64.cc
> index b094e4bd3b..a0247b5707 100644
> --- a/gold/x86_64.cc
> +++ b/gold/x86_64.cc
> @@ -2764,6 +2764,7 @@ Output_data_plt_x86_64_bnd::do_write(Output_file* of)
>        this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
>                                tlsdesc_got_offset, plt_offset);
>        pov += this->get_plt_entry_size();
> +      plt_offset += plt_entry_size;
>      }
>
>    // Write the additional PLT.
> @@ -2859,6 +2860,7 @@ Output_data_plt_x86_64_ibt<size>::do_write(Output_file* of)
>        this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
>                                tlsdesc_got_offset, plt_offset);
>        pov += this->get_plt_entry_size();
> +      plt_offset += plt_entry_size;
>      }
>
>    // Write the additional PLT.
> --
> 2.25.3
>

I am checking in this patch.

-- 
H.J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry
  2020-05-01 16:02 [PATCH] gold: Update ver_test_pr16504.sh H.J. Lu
@ 2020-05-01 16:02 ` H.J. Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2020-05-01 16:02 UTC (permalink / raw)
  To: binutils

Increment plt_offset after setting the reserved TLSDESC PLT entry.

	PR gold/25872
	* x86_64.cc (Output_data_plt_x86_64_bnd::do_write): Increment
	plt_offset after setting the reserved TLSDESC PLT entry.
	(Output_data_plt_x86_64_ibt<size>::do_write): Likewise.
---
 gold/x86_64.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gold/x86_64.cc b/gold/x86_64.cc
index b094e4bd3b..a0247b5707 100644
--- a/gold/x86_64.cc
+++ b/gold/x86_64.cc
@@ -2764,6 +2764,7 @@ Output_data_plt_x86_64_bnd::do_write(Output_file* of)
       this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
 			       tlsdesc_got_offset, plt_offset);
       pov += this->get_plt_entry_size();
+      plt_offset += plt_entry_size;
     }
 
   // Write the additional PLT.
@@ -2859,6 +2860,7 @@ Output_data_plt_x86_64_ibt<size>::do_write(Output_file* of)
       this->fill_tlsdesc_entry(pov, got_address, plt_address, got_base,
 			       tlsdesc_got_offset, plt_offset);
       pov += this->get_plt_entry_size();
+      plt_offset += plt_entry_size;
     }
 
   // Write the additional PLT.
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-01 16:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-25 15:24 [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry H.J. Lu
2020-05-01 15:51 ` H.J. Lu
2020-05-01 16:02 [PATCH] gold: Update ver_test_pr16504.sh H.J. Lu
2020-05-01 16:02 ` [PATCH] gold: Increment plt_offset after setting TLSDESC PLT entry H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).