From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 7760A3856DC1 for ; Thu, 28 Jul 2022 15:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7760A3856DC1 Received: by mail-pj1-x1034.google.com with SMTP id h21-20020a17090aa89500b001f31a61b91dso2762366pjq.4 for ; Thu, 28 Jul 2022 08:17:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=giWV7i9+liMegWW8Lzc9+siFSZSoBc4F19oaOgioimQ=; b=jk1oaleWpnRxydYQFqIAys0n3kJZdxbE1mowgupnjEo3qAOc7NJzTGFY/2g2Wath2h kbyXrboEHRwQjCatRfQ0PmBY2G/B9rwK85XWC8YfmuXVtLQvtI+8ZGGrd7qKYj0nIpjC 715chRjRauzKb9WshzKpZ9HbIRkBfnLA5amfTEkLx58J1OlUk1YQ65xg21fm0uZh30ui 10Uk29KnIq9L+ejn7byQ6gGoqZAmrRGYM4AyH0g48zk7E7HKop/Bgxs2LBZqZ9O1M7Ok IQ5Tt+nTJ3ntuENg5cC2WAFHcwp6mAAe0eNwDRKOMhx4rEGME/URbCRHxP17dKWE4luq FMsQ== X-Gm-Message-State: AJIora/2Ck+hwpOCT383WXo0m7YJKhFm+34fSdr4X75tCjh9xhp4i9lN 3MsIrX9Yl87oaTges+O/KBPMHzYydVXFAb+G2z8= X-Google-Smtp-Source: AGRyM1vTzVCADD3QdvMuiUoYD/C7TdYrI4SHaoF1vJ2b2pgW2ceBKxcAUf/slj4cpsyrXF00VzMLvsoeGUIJkOzA77s= X-Received: by 2002:a17:902:a502:b0:15e:c251:b769 with SMTP id s2-20020a170902a50200b0015ec251b769mr27279125plq.115.1659021451482; Thu, 28 Jul 2022 08:17:31 -0700 (PDT) MIME-Version: 1.0 References: <649aee92-1caa-f420-2806-7d8ff74854ed@suse.com> In-Reply-To: <649aee92-1caa-f420-2806-7d8ff74854ed@suse.com> From: "H.J. Lu" Date: Thu, 28 Jul 2022 08:16:55 -0700 Message-ID: Subject: Re: your change "x86: Also pass -P to $(CPP) when processing i386-opc.tbl" To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 15:17:33 -0000 On Thu, Jul 28, 2022 at 5:33 AM Jan Beulich wrote: > > H.J., > > the description there talks about dealing with \ uses for line > continuation. -P, however, is about the suppression of line markers. > In recent work I've been wondering why i386-gen gives far off line > numbers in error diagnostics, making it sometimes quite difficult to > spot what is actually wrong. Furthermore i386-gen.c specifically has > code to consume the line markers. > > Can you please explain to me what your change really was about? And > can you please propose an alternative way of having i386-gen give > useful diagnostics (unless you agree with reverting that change of > yours)? > Here it is: https://sourceware.org/pipermail/binutils/2022-July/122060.html -- H.J.