From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28770 invoked by alias); 30 Jul 2012 16:10:43 -0000 Received: (qmail 28580 invoked by uid 22791); 30 Jul 2012 16:10:42 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_05,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 16:10:29 +0000 Received: by vbkv13 with SMTP id v13so5424194vbk.0 for ; Mon, 30 Jul 2012 09:10:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.240.228 with SMTP id wd4mr10073745vdc.95.1343664628567; Mon, 30 Jul 2012 09:10:28 -0700 (PDT) Received: by 10.58.179.79 with HTTP; Mon, 30 Jul 2012 09:10:28 -0700 (PDT) In-Reply-To: <500ECADF0200007800090386@nat28.tlf.novell.com> References: <500ECADF0200007800090386@nat28.tlf.novell.com> Date: Mon, 30 Jul 2012 16:10:00 -0000 Message-ID: Subject: Re: [PATCH] x86: don't allow invalid operand combinations for VGATHER From: "H.J. Lu" To: Jan Beulich Cc: binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00288.txt.bz2 On Tue, Jul 24, 2012 at 7:18 AM, Jan Beulich wrote: > The VGATHER group of instructions requires that all three involved > xmm/ymm registers are distinct. This patch adds code to check for this, > and at once eliminates a superfluous check for not using PC-relative > addressing for these instructions (the fact that an index register is > required here already excludes valid PC-relative addresses). > The assembler should only check the operands which can't be encoded. It should shouldn't check if operands are functional correct. However, I don't mind to issue an error which is controlled by a command line option. Thanks. -- H.J.