From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id E111B3858C52 for ; Thu, 19 Jan 2023 21:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E111B3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x232.google.com with SMTP id r9so2855500oie.13 for ; Thu, 19 Jan 2023 13:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9lSiEuVt8MX9DDDpbtCDkvQptW5cs+PGspxDUwzrYVM=; b=FnG8gt0JBKLf3/J4EcKMKaLpE3//D0O5hk+52ElO6RUY+qeQdBAYn45oun6pd+Zfre PXkOw+s0Itt0+RQ0L/t8w7m5kA6zZS56C3wLVI8l5Xo+hHFO8wUdZBZ+cacjiT/ouHgC TyRgu/NVw6xIhWG4sFCqai0tMmmWJ4M9plMcnW1TJWOf150ggO6lNYbnmtWGZusLkB2C bDuuM6njyeQEw7/er25m+iMbEY1mwPEW4jJ1I+H3P1poUhD2Y/oR4MIbcxJJAFOsNMk6 5NchcA2SpVQpAg6BU9PUVEXjOHLGUUWUqjlQhdB5ukSIM8+Wga6yZikSwik4RniE+CXq gLkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9lSiEuVt8MX9DDDpbtCDkvQptW5cs+PGspxDUwzrYVM=; b=AJw/PEYy/NsjIy5+LNqUpYPjLABrdngxhSOp7eGWlvUPsnE3n2MC05PLN1tiPLSwhn Vcjjj4yNM3aks5E2uXayaDvggLPLEfy8GJ5liUbr7NdI+OHdMvowY404G6vklUdh85A5 cP1NDym6KjVPYiBLvcuC+I0Grlgyqg0cHyv3l7Z0qldLMnHveugPrcMMB/gAgee5V8Sq sIrn2gvXs5rQry6pAiNZ/a/djyOjK13y0wUv7L/BJOUeNHvW9RUgVYb92Q1SHPuNCMgj FYpsSJLebORHeA2rfmUs4WLWcwN+Cne7O1wo80DK3n6jd/KcZd9xeI9AQpcUzrjTsYxs oqAA== X-Gm-Message-State: AFqh2krMprrczI8rrDQSUZ3RROERrugRS4dLiDeVwNI7/OwJmUR39hqt SQwqezPt3NbUoTK1kvU0FkMI2y7+4hVq4l3Mk+/lneY9 X-Google-Smtp-Source: AMrXdXuCILZBX6H54xUH5LGmCjpSwPVB+NJW+R3un7Px0EMFUa3eJypiD3YoTAO4Y6OwM8K90qsiT3VPFKmSxPgGP1M= X-Received: by 2002:aca:ac12:0:b0:364:a686:4444 with SMTP id v18-20020acaac12000000b00364a6864444mr935000oie.298.1674165376063; Thu, 19 Jan 2023 13:56:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Thu, 19 Jan 2023 13:55:39 -0800 Message-ID: Subject: Re: [PATCH] i386: Don't emit unsupported TLS relocs on Solaris [PR13671] To: Rainer Orth Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 17, 2023 at 3:25 AM Rainer Orth wrote: > > As detailed in PR ld/13671, gld can emit R_386_TLS_TPOFF32 relocs which > the Solaris/x86 ld.so.1 doesn't know about, so the resulting executables > won't run. > > The following patch, which H.J. provided in the PR, fixes this. > > Tested on i386-pc-solaris2.11 (both with the binutils testsuite and a > full gcc bootstrap) and i686-pc-linux-gnu. > > Already approved by H.J. in the PR, but it's probably best if someone > double-checks the ChangeLog entry. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2023-01-17 H.J. Lu > > bfd: > PR ld/13671 > * elf32-i386.c (elf_i386_tls_transition): Only emit R_386_TLS_LE, > R_386_TLS_IE on Solaris. > (elf_i386_relocate_section): Only use R_386_TLS_GD->R_386_TLS_LE > transition on Solaris. > I checked it in. Thanks. -- H.J.