From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 339DB3858CDA for ; Thu, 1 Dec 2022 18:17:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 339DB3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x229.google.com with SMTP id e205so2865579oif.11 for ; Thu, 01 Dec 2022 10:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PMTruhkskAuuRNEnps04oWiPj929d1j/fTCsSwgpUUU=; b=EmGgHD+H3/bEWGjqHrnG8E1y8aAyFYqYSo4i6c41lnahwcehREuItp1Gx4nKbuRSM6 7HK3aOPZLxfyYowS6JSP7dIHG6jA81QlZqC8hqdAXmyhi4Mq9NOT/1EUVfNQdnHvwcaj hnAbSTcJcikxvm80iTwHJZZgeQy5p+BSHLqP0DE6aJLTeXra67YIJPrqPehJ8T6Ve7I2 I1RYKWePZL9sE29u9s6kpnf/TH4420acr5Qpw92ukCQsk3PNWvCt5E97oBbj+lHxGCnu 0cX+fIoPhtfZW7IBXa9SaTxSpAueJMSX+vu6/0WkRFUJtYYQYKoeyEVTPSmQhEm3DWZO 2f2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PMTruhkskAuuRNEnps04oWiPj929d1j/fTCsSwgpUUU=; b=054FIvFxTiu7VTP/jqClY+l9i4G9smcGw3WXplDGRrqRuBxjIRqNvh8j7cIDJ/a7Q4 3XjiOk8UplGDmlVoOAgbcVenE8iVjU2LgaOzO/6rZzEDPKUkeGaVDXmJg9hxYTilXVFO /bMzjrYtk/No0uiHBPSYKY16IC1Pl1bV8fYzED0BUnvuodbNylgwIZ4NLPG0eXR8g3Hw 47Z23w928Qze3+zKphSP4MCKzYlg1CUAo2XzMNpz8OpFaLbRCWjkH121z7DR/wKwiY5a 3W9mV0YJbfZXBWZGqwSEtRfh4FDCmi17Lc2zIrZO4bUw7DC/clBUnyFjJfoLz0fEk4mu 3pzg== X-Gm-Message-State: ANoB5pkI8R12tNx4vuRP2GX4SUdFwfrYFSk2hKlxb2NM1p22rlpx58vY ZQFDy/f9F2hti74BOxC+g0vrpn7h35AO4d10/1Q= X-Google-Smtp-Source: AA0mqf670FaHSDmZs1S7lak29lWD2bGsa8MeRkiVgCdZO27e4DnDW4MEZ//CtvVY9BFbt0yJX/DpTaQKI9osk+A+lsQ= X-Received: by 2002:a05:6808:22a0:b0:35b:c6c4:7a33 with SMTP id bo32-20020a05680822a000b0035bc6c47a33mr6412958oib.266.1669918634358; Thu, 01 Dec 2022 10:17:14 -0800 (PST) MIME-Version: 1.0 References: <20221201162038.421271-1-hjl.tools@gmail.com> <411154b1-3dd3-d4dd-9d58-eb8b80d680fb@suse.com> In-Reply-To: <411154b1-3dd3-d4dd-9d58-eb8b80d680fb@suse.com> From: "H.J. Lu" Date: Thu, 1 Dec 2022 10:16:38 -0800 Message-ID: Subject: Re: [PATCH] opcodes: Make i386-init.h depend on i386-tbl.h To: Jan Beulich Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 1, 2022 at 9:08 AM Jan Beulich wrote: > > On 01.12.2022 17:20, H.J. Lu via Binutils wrote: > > i386-gen will generate both i386-tbl.h and i386-init.h in one go. Since > > both i386-tbl.h and i386-init.h depend on i386-gen, it leads to a race > > condition for i386-gen. > > This is not true - the use of a pattern rule was specifically introduced > (not very long ago) to signal to make the creation of multiple files by > a single command / rule. What you describe would happen if this rule > wasn't a pattern one. You are in fact ... I > > Make i386-init.h depend on i386-tbl.h to avoid > > the race condition. > > ... proposing to re-introduce the original problem (just in the > opposite direction) - see commit 79d635fc64ba. > > Jan You are right. I found my mistake. This patch is withdrawn. Thanks. -- H.J.