From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id 221463858D33 for ; Tue, 20 Feb 2024 16:53:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 221463858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 221463858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708448018; cv=none; b=WYLQ17hML4zBi+4BCTndP/oBBNp5VT6IpI0Pw8/ZgPWoxnoSXNirFcfsn99AxtRkLu92gjKnP2zRnV1+Qsy/MSeI99gI/n/MdlIJQikgLeshuQxQ/BWCvLBy5FHy17qpl9R4TtgjBTGxst+ASGpVcM5dHpN2Yf4d6m4UfLshZ2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708448018; c=relaxed/simple; bh=DEHDoi7gfZCqiHUde7YKsz4VRqUqHcJ0RVviycj4D4s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=j1gEjw/U0iiVgWukyGl3tYrXAlNqhG4ZZtDiHb4mIrssaRGUXjvGBbqbYyDnzroRYEk00MoTtHc3f1tVo2lgjCm8q4zbCGPo29GrALHIAGC5Ba2x2fWEQT/+TLHXrz37ZN/6ltpqWZyU2qTRsHYDCg09h1wh2itlDvKP5cCMe4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-dcc73148611so6501363276.3 for ; Tue, 20 Feb 2024 08:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708448015; x=1709052815; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BgOGMkk6TR7Um2X1CflSdF9synbdSiDAKYdvxz0aL60=; b=cIV1CsN0uD7cZ4V0eH7hzwyX/1lnGJo6xz+myZoC7MIG8Ho3BEhSThoP1BjyfGhIGv riFtq19EYJSiinNoEZhSHCtf8vAAMihOYiNd3qpdtf3sUHXhjVucsJ/h8YrG0nlSFu/m jL4LGmmQnvxhvG59rFjUbUfIZMj9mngjZ4hxfFpuL0rjkcKnR2afqVPi4SShKQt75ply 0W2tJRW7nQHFc4BNi5EwhVRUPo83BzuIkkDOSA6Xodur+Oh3uHMDMePNu5AI70ZurIvj VBDfG67/Ms8XzoWozugoNIV6i6mZyBCOxZDXcEybKkZb1XF2aAbxATDgPpAH7tXRNJSk /ilg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708448015; x=1709052815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BgOGMkk6TR7Um2X1CflSdF9synbdSiDAKYdvxz0aL60=; b=tQF0omDpquzu3x6fYSRXobchhV9jGv05/G8awDEWjHaQNSNED1xLJ260MYqg+HneX1 iyrCNq79Iyzs8iaMCjOKnU0A85jQHfBo6T947ZrKvgc/rnG3RnANbdayD9Wbsydy/hJf WTeWNLDwBBLW/1XORg5/d0tI6l+UE7yaFh1veSTfbzbfbZhvGaGpKrLXrFWedf8i7m3m UB0FE5PiaHqtNt4G77+OjNODCOa48epA4tfnZg00Mtk8JsLO38RgY6lkCgxEOwcuFUpz wy+uzeZ5Kzxh+/JAZMCsvJkD59sugpB4ZcMlgRT1vIT8sLwJu7XfEwZXE4f+20Cexn3G ykvQ== X-Forwarded-Encrypted: i=1; AJvYcCXjEG+AaRkLDf57rRzxb5dGALstBWW7gyD6uKLdGC4x5FQLK8gDfloCO8PjMyUAcbCH5pOcqcIz5oOKFKTlWu1CgSybnRubVQ== X-Gm-Message-State: AOJu0YyjOTl8V665Pa2JxwkvzMNtoPQ0WE7zugL090orWIEZiwzrgTY8 xexOSjczXFnRnaluitJ1oQEnhfBLqugZ//rtXk3XG7lnXp10KNNS0b6iIK/EyNI7MIfaF44miUw tbUnkX+/oX7OusiVx74yGHEbTkCU= X-Google-Smtp-Source: AGHT+IE+YlMli4eZ6quRejMli0gKEqTdVDbA5Nq+X5D3ntOocSoPzF2A/LYZtSZQXCXduuYoQ9obLG3RDqTsp+Lx8Oo= X-Received: by 2002:a25:29c2:0:b0:dcd:aee6:fa9 with SMTP id p185-20020a2529c2000000b00dcdaee60fa9mr15522419ybp.53.1708448014850; Tue, 20 Feb 2024 08:53:34 -0800 (PST) MIME-Version: 1.0 References: <3098e797-3749-40ee-802c-ea8a6f63914c@suse.com> <8a7e7a43-37d4-425c-8166-6ba8b758f0f4@suse.com> <80e6789c-a103-247f-859a-2061b7190fe8@suse.de> In-Reply-To: <80e6789c-a103-247f-859a-2061b7190fe8@suse.de> From: "H.J. Lu" Date: Tue, 20 Feb 2024 08:52:58 -0800 Message-ID: Subject: Re: [PATCH 2/4] x86/APX: respect {vex}/{vex3} To: Michael Matz Cc: Jan Beulich , "Cui, Lili" , Binutils Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 20, 2024 at 8:00=E2=80=AFAM Michael Matz wrote: > > Hello, > > On Tue, 20 Feb 2024, Jan Beulich wrote: > > > On 20.02.2024 11:12, Cui, Lili wrote: > > >> On 18.02.2024 08:55, Cui, Lili wrote: > > >>>> --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s > > >>>> +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s > > >>>> @@ -207,3 +207,13 @@ > > >>>> vtestpd (%r27),%ymm6 > > >>>> vtestps (%r27),%xmm6 > > >>>> vtestps (%r27),%ymm6 > > >>>> +# {vex} > > >>>> + {vex} and %eax, %eax > > >>>> + {vex} and %r8, %r8 > > >>>> + {vex} and %r16, %r16 > > >>>> + {vex} and %eax, %eax, %eax > > >>>> + {vex} and %r8, %r8, %r8 > > >>>> + {vex} and %r16, %r16, %r16 > > >>>> + {vex} andn %eax, %eax, %eax > > >>>> + {vex} andn %r8, %r8, %r8 > > >>> > > >>> These two test cases are valid. > > >> > > >> ... reflects exactly this fact. > > >> > > > > > > Normally we don't put valid test cases into invalid test case file, r= ight? > > > > Depends, I would say (and I think you'll find other examples). I view i= t as > > pretty relevant here. > > I think the test filename should be different then, also for other cases > where this is the case. That, or at least a comment next to the insns > that those are _not_ invalid (referring to the .d file to see that is not > self-describing). Without any other indication I'd say instructions in a > file named "*inval.s" should _all_ be invalid, always. Agreed. --=20 H.J.