From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id CCCC43858D3C for ; Wed, 29 Dec 2021 19:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCCC43858D3C Received: by mail-pj1-x1034.google.com with SMTP id a11-20020a17090a854b00b001b11aae38d6so20765579pjw.2 for ; Wed, 29 Dec 2021 11:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Id8RWfcLwEL10lEzJ2ceI8V0PYONqhUTXA7AxdlEu0=; b=mD/yvqkjQnW8upYgzKLWcUkxWU1fJO+D5EKiZTgiPy2NcKLeG8CRH7qh/o6kKW4YrB j1VNMs6vOOGSajm4knl33eqWgD02ScY9thHWxVTRh79pAJ3arWwMBIpEeNX4zbt4Km0J RtKosmPmYLwkE2kPGC2OgPdJ1pWp/7AKBeFHvReVHgMkyVahrzWkXNBB/BNX9SFMdGgP 7N/qdfHUBHIal6hq9sivivdv0POXnaqdL9PixLCTqoCaQUlaxziQwmXGTXct4RDe0KsZ nwstjvAq40H6M51dQI9p7SBFXIp1GTO3TisfQOlH0ERyDPA1+hixyjo+DE19XNH0DYef LjyA== X-Gm-Message-State: AOAM530KTLn53yKILksGi7Xqe6mPfjgFU+jJ7Hhw2Hc9DUrZrPmwBcnX tDGdU+CRhbhE95gJny3ja2FrMj4ut98nIaijxc8= X-Google-Smtp-Source: ABdhPJyycCGGKHcxW0nmkHdbwFRrpuWVNiR7negpzPWC2F0Cteo9a8OhrjOWwj+mAwxdKYSH10a5g2KiiInocaXXkjE= X-Received: by 2002:a17:903:191:b0:148:e4d3:e8a9 with SMTP id z17-20020a170903019100b00148e4d3e8a9mr27728396plg.101.1640806926886; Wed, 29 Dec 2021 11:42:06 -0800 (PST) MIME-Version: 1.0 References: <20211225035418.598861-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 29 Dec 2021 11:41:31 -0800 Message-ID: Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible To: Alan Modra Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2021 19:42:09 -0000 On Tue, Dec 28, 2021 at 4:43 PM Alan Modra wrote: > > On Fri, Dec 24, 2021 at 07:54:18PM -0800, H.J. Lu via Binutils wrote: > > Changes in v3: > > > > 1. To enable this linker optimization, the backend must define ELF_P_ALIGN > > to ELF_MINPAGESIZE. > > All this means is that you're only breaking x86 binaries for those > with older glibc who might be running with page size larger than 4k. Correct. > If this isn't so, what am I missing? > > Also, please check for fallout in future. > > alpha-linux +FAIL: ld-elf/pr26936 > alpha-linux +FAIL: ld-elf/seg > alpha-linux +FAIL: rgn-at5 > alpha-netbsd +FAIL: ld-elf/pr26936 > alpha-unknown-freebsd4.7 +FAIL: ld-elf/pr26936 > arc-elf +FAIL: ld-elf/pr26936 > arc-linux-uclibc +FAIL: ld-elf/pr26936 > arc-linux-uclibc +FAIL: ld-elf/seg > arc-linux-uclibc +FAIL: rgn-at5 > arm-nacl +FAIL: ld-elf/pr26936 > avr-elf +FAIL: ld-scripts/pr23571 > cr16-elf +FAIL: ld-scripts/pr23571 > cris-linux +FAIL: ld-elf/pr26936 > cris-linux +FAIL: ld-elf/seg > cris-linux +FAIL: rgn-at5 > crisv32-linux +FAIL: ld-elf/pr26936 > crisv32-linux +FAIL: ld-elf/seg > crisv32-linux +FAIL: rgn-at5 > crx-elf +FAIL: ld-scripts/pr23571 > frv-linux +FAIL: ld-elf/pr26936 > frv-linux +FAIL: ld-elf/seg > frv-linux +FAIL: rgn-at5 > h8300-elf +FAIL: ld-scripts/pr23571 > h8300-linux +FAIL: ld-scripts/pr23571 > ia64-elf +FAIL: ld-elf/pr26936 > ia64-freebsd5 +FAIL: ld-elf/pr26936 > ia64-linux +FAIL: ld-elf/pr26936 > ia64-linux +FAIL: ld-elf/seg > ia64-linux +FAIL: rgn-at5 > ia64-netbsd +FAIL: ld-elf/pr26936 > ip2k-elf +FAIL: ld-scripts/pr23571 > lm32-linux +FAIL: ld-elf/pr26936 > lm32-linux +FAIL: ld-elf/seg > lm32-linux +FAIL: rgn-at5 > loongarch64-linux +FAIL: ld-elf/seg > loongarch64-linux +FAIL: rgn-at5 > m32c-elf +FAIL: ld-scripts/pr23571 > m32r-elf +FAIL: ld-scripts/pr23571 > m68k-elf +FAIL: ld-elf/pr26936 > m68k-linux +FAIL: ld-elf/pr26936 > m68k-linux +FAIL: ld-elf/seg > m68k-linux +FAIL: rgn-at5 > moxie-elf +FAIL: ld-scripts/pr23571 > nds32le-linux +FAIL: ld-elf/pr26936 > nds32le-linux +FAIL: ld-elf/seg > nds32le-linux +FAIL: rgn-at5 > or1k-linux +FAIL: ld-elf/pr26936 > or1k-linux +FAIL: ld-elf/seg > or1k-linux +FAIL: rgn-at5 > pru-elf +FAIL: pru_irq_map special section for host > pru-elf +FAIL: ld-scripts/pr23571 > score-elf +FAIL: ld-elf/pr26936 > shle-unknown-netbsdelf +FAIL: ld-elf/pr26936 > sh-nto +FAIL: ld-scripts/pr23571 > sh-rtems +FAIL: ld-scripts/pr23571 > sparc64-linux +FAIL: ld-elf/pr26936 > sparc64-linux +FAIL: ld-elf/seg > sparc64-linux +FAIL: rgn-at5 > sparc-elf +FAIL: ld-elf/pr26936 > sparc-linux +FAIL: ld-elf/pr26936 > sparc-linux +FAIL: ld-elf/seg > sparc-linux +FAIL: rgn-at5 > sparc-sun-solaris2 +FAIL: ld-elf/pr26936 > spu-elf +FAIL: ld-scripts/pr23571 > tilegx-linux +FAIL: ld-elf/pr26936 > tilegx-linux +FAIL: ld-elf/seg > tilegx-linux +FAIL: rgn-at5 > tilepro-linux +FAIL: ld-elf/pr26936 > tilepro-linux +FAIL: ld-elf/seg > tilepro-linux +FAIL: rgn-at5 > visium-elf +FAIL: ld-scripts/pr23571 > xstormy16-elf +FAIL: ld-scripts/pr23571 I adjusted these tests in the v3 patch: https://sourceware.org/pipermail/binutils/2021-December/119047.html -- H.J.