public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: "H.J. Lu via Binutils" <binutils@sourceware.org>,
	GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Set TESTS to gdb.dwarf2/*.exp for PGO build training
Date: Mon, 11 Jan 2021 14:51:29 -0800	[thread overview]
Message-ID: <CAMe9rOoyS2gC1R5hC0ViLMTBriEmQNRfvcGpuHxn5n2USiGozw@mail.gmail.com> (raw)
In-Reply-To: <87o8hv9og0.fsf@tromey.com>

On Mon, Jan 11, 2021 at 1:02 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> ">" == H J Lu via Binutils <binutils@sourceware.org> writes:
>
> >> When configured with --enable-pgo-build, set TESTS to gdb.dwarf2/*.exp
> >> for PGO build training.
>
> >>      * Makefile.in (TESTS): Set to gdb.dwarf2/*.exp for PGO build
> >>      training.
>
> This doesn't seem like a particularly good test to me.
> From my perspective, gdb.dwarf2 is largely DWARF corner cases.

Any suitable GDB tests can be used for PGO training.

-- 
H.J.

  reply	other threads:[~2021-01-11 22:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 15:27 [PATCH 0/2] Enable PGO/LTO build in GDB H.J. Lu
2021-01-09 15:27 ` [PATCH 1/2] Set TESTS to gdb.dwarf2/*.exp for PGO build training H.J. Lu
2021-01-11 21:02   ` Tom Tromey
2021-01-11 22:51     ` H.J. Lu [this message]
2021-01-09 15:27 ` [PATCH 2/2] gnulib: Support variables from the top level Makefile H.J. Lu
2021-01-11 21:03   ` Tom Tromey
2021-01-11 22:49     ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOoyS2gC1R5hC0ViLMTBriEmQNRfvcGpuHxn5n2USiGozw@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).