From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by sourceware.org (Postfix) with ESMTPS id 409A83858416 for ; Thu, 25 Jan 2024 17:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 409A83858416 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 409A83858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706203612; cv=none; b=X654zdLj0R7+ClMfPXU5tOG2V/BNtLcVOvn3mBFfqhT8iahd96bNmAx4/4gtUGH3o1URBjI1WXLMJi+wc1ky7oWWwze6Rlds0h0o+M32NnVkaZ/h+NnhFPUeaXcZq6HxBLdvGLVcn60t8/WE88/IvLCF1qeuB3FPI7WSuUj/T+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706203612; c=relaxed/simple; bh=pLEFzRHLxkoAnfGDg//ytmUmC2mZvquLsb96f/HSz9g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=j/qUMWFIvoyBYbhGMtFmwUjOWhQDeV2IcR/2a11iKOrRC3Bt7v4U4ZHyTFzRSf++ZIdUJwHC4yDukye6Dj/yJL4ile815ju4o7tQAGR1KTUDOXflIMx8A8eryrAz0jxMIEnfIGAA6BGP0OkHW3GTtoomvEO60HLu6tNm9/Rae7M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-dc2501ed348so777297276.0 for ; Thu, 25 Jan 2024 09:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706203609; x=1706808409; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0UcahkONki7LQYZ/4p+o6AGdzProM5CPLnAccoWAosE=; b=EfXa9IKTLjWxZAw4Uxlx7sjbFXAPiDnkCAD/wICYWVClRN+HbV2yUY/1YEIUG5xh7E bfcBa7C4FRn8rgVNVsfCtlUa9AdnOR5HR0iGBeHMnPKmPiKc2+RKRCxQnrbGKkAU++MY WVTf0u3ORBFVxeCGQE6JXQeZYsGulL3LP1TzbyRNhUSL+XozY4D8ZwQuztzINLoM2YMz thx6feozyBgRFpje5aa8eSqnLXzb7KCPVMNlxISavtAkSPWfZnzpYLscT5AVKw1eQmGD ro5vWG2wG6py5x7IInIiccm5KHUkdy6VoC5QWocBD09Q7qYudORjGiod8DRyJMPrPY0k cUQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706203609; x=1706808409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0UcahkONki7LQYZ/4p+o6AGdzProM5CPLnAccoWAosE=; b=ERv+k4d8/88Hb4g4Clpwej4PHdqgQOlaeCdW216riTjn/gP2AQ0ezXGnJv3of92eJU 5VvfT64Oucmi0SIulvMzIBNWcIToOdxBr5+Cp4yzKobqbpeCksiJJ1195DkzZbxlWBKn 5A4G2KQ4XiE4oPkot+iN8Z1pPgfhOpLgEJQCT3hEc04i2D6HxzlY4+2Nk4dgxuxuo60l ZeqLpdX/67onacqXA3UMvoePVMsVb904CjI53bYeAlaFlpqY5WJTTUTN/hs3jLps3xmV NW4+VMqCVaqO1p7mTwVTEgQfMKJrkCbcPB2+h7vt8C0fVAbOu2S6DeP7PEC66SlvHUA0 X5Tg== X-Gm-Message-State: AOJu0YyTSqiqK581mzLaavIUWM+ImP2k56okK4XskjeJBLQs8Qi0xfdC 9XrGhXeHQDSnRbp08VNvpo5r2y++tWMoX033JQAa2pAm/Rn/kTu+nDjDWo2u8NJimc7VEMxwl6a nVCtj+v1EIWLodsI7XF/eUz215f4aGFet X-Google-Smtp-Source: AGHT+IG1brJSY3EdYprs/4KHqcroxo3JFGV86sHMAQ9MZE9zxcVwFvKYPQynL7VCI2MSVWxwCLzw0NtM1J2qM3HTaoQ= X-Received: by 2002:a25:b296:0:b0:dc2:4d8f:2276 with SMTP id k22-20020a25b296000000b00dc24d8f2276mr189620ybj.5.1706203609440; Thu, 25 Jan 2024 09:26:49 -0800 (PST) MIME-Version: 1.0 References: <20240125154319.788647-1-hjl.tools@gmail.com> In-Reply-To: <20240125154319.788647-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Thu, 25 Jan 2024 09:26:13 -0800 Message-ID: Subject: Re: [PATCH] ld: Always call output_unknown_cmdline_warning To: binutils@sourceware.org Cc: nickc@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jan 25, 2024 at 7:43=E2=80=AFAM H.J. Lu wrote= : > > Call output_unknown_cmdline_warning if there are no input files so that > > $ ld -z bad-option > > reports > > ld: warning: -z bad-option ignored > ld: no input files > > instead of > > ld: no input files > > PR ld/31289 > * ldmain.c (main): Call output_unknown_cmdline_warning if there > are no input files. > --- > ld/ldmain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ld/ldmain.c b/ld/ldmain.c > index 3b4ad144a2f..9ae541a5d82 100644 > --- a/ld/ldmain.c > +++ b/ld/ldmain.c > @@ -471,6 +471,7 @@ main (int argc, char **argv) > { > if (version_printed || command_line.print_output_format) > xexit (0); > + output_unknown_cmdline_warnings (); > einfo (_("%F%P: no input files\n")); > } > > -- > 2.43.0 > I am checking in this. --=20 H.J.