From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com
 [IPv6:2607:f8b0:4864:20::335])
 by sourceware.org (Postfix) with ESMTPS id 5590D38708A0
 for <binutils@sourceware.org>; Thu, 14 Jan 2021 13:29:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5590D38708A0
Received: by mail-ot1-x335.google.com with SMTP id w3so5107037otp.13
 for <binutils@sourceware.org>; Thu, 14 Jan 2021 05:29:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dEuvHM0H2pB5E8h4Nw+xoDA+W5NVMUjHYhF1FM47HDk=;
 b=dia2Hjya/FeoF7mnPsfBcATYy4em+WrsGPwpoipGuAV7wjqXxCiCasD8K+recMfcg5
 /sGnaN9UcQH5HNV5ifqr4Hf+2I83dUTS+TOF9u2pB7wmxbZn8dKsoBRE7q0o7bcfnN35
 TPDx13coaLbFS2IAP5hKU7d8pbuNW+Az+PL71XDMD5+TnYv7BnOiE+gx+enM1sg8T4Vt
 TdSdTonP2yjM9/R8tJ2BWMhQsbdx6wO7SiIeWW7/WPP0G3XffXrTK6lm9fbMX7C9dxoC
 lapxVybpEeuF0OVVKAT/P4OdfakomY/M48MbC+Jhz6JDixyzydrzafnHaJnot+lXWkfs
 JXUA==
X-Gm-Message-State: AOAM5338fhubfI52cMBddnRahBayCf8qW0+vhRVm8HyuAOZawtqcV4t8
 or0dtEAdjgQnrT+EAKDwfZ0NAW0Zp7Wp75EXbyM=
X-Google-Smtp-Source: ABdhPJzbdeOe8rorbbUhQr70/pP+qRAHYBhtBriiBq2P80jszLT1D+0nlrQYKaBS4FigHkQaISRdAAFrm3rZ58l+V/Q=
X-Received: by 2002:a05:6830:1d71:: with SMTP id
 l17mr4518306oti.269.1610630964852; 
 Thu, 14 Jan 2021 05:29:24 -0800 (PST)
MIME-Version: 1.0
References: <20210113124155.3240078-1-hjl.tools@gmail.com>
 <20210114060002.GI6938@vapier>
In-Reply-To: <20210114060002.GI6938@vapier>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 14 Jan 2021 05:28:48 -0800
Message-ID: <CAMe9rOp1yTuuSTRcJDO_xYmgnxpmGPjajgbH_0P2Gz2P0KTk7A@mail.gmail.com>
Subject: Re: [PATCH] bfin: Skip non SEC_ALLOC section for R_BFIN_FUNCDESC
To: "H.J. Lu" <hjl.tools@gmail.com>, Nick Clifton <nickc@redhat.com>, 
 Alexandre Oliva <oliva@adacore.com>
Cc: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2021 13:29:26 -0000

On Wed, Jan 13, 2021 at 10:00 PM Mike Frysinger <vapier@gentoo.org> wrote:
>
> On 13 Jan 2021 04:41, H.J. Lu via Binutils wrote:
> > Linker should never generate dynamic relocations for relocations in
> > non-SEC_ALLOC section which has no impact on run-time behavior.  Such
> > relocations should be resolved to 0.
>
> does elf32-frv.c need the same fix ?  kind of looks like it.

Yes.  FRV maintainers need to take a look.   There are many code/bug
duplications in FDPIC support.   They should be merged.

> otherwise, lgtm, thanks
> -mike

Fixed on master.  Nick, is it OK for 2.36 branch?

-- 
H.J.