From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 646AF3852C41 for ; Thu, 17 Nov 2022 17:02:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 646AF3852C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x635.google.com with SMTP id f18so6638436ejz.5 for ; Thu, 17 Nov 2022 09:02:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/VBwmMskyPGQpKREGpsMRJo5mVvF2fPGJKLW4RwzfqA=; b=OqFTI3SqT65chkYGDTfFMEiTWJ+kUp0Ixapw0SA5gsVc3peCfqttAZZa28Nm3QOJ9a 7oR6P4IXpk+wBJEq3csD6kKYENX3MslSeTbP4UEAHTJw+MFIb2bB0dldhfqHRk0dQcnY xxmo+MkAm7AV36b/UPYjykW+v931e2rfk0I7xL3JikJ/1ZE6413Yg90gC4wx3lRv2U+f hPzWuiNXUlBvUIvaCP0J/Quu2FCSr6WmOJAL6Pmzdi9GgEb9SdkEcclgsmOcdxbdM3ZL S5ixKExMAO/XUlBZ3PCrPJGebvWNNTehIUlNtM82OPbI+MRe2T3OwpbhptURI8CnuGWI BtQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/VBwmMskyPGQpKREGpsMRJo5mVvF2fPGJKLW4RwzfqA=; b=6/CkeqIqtOe5bkFATn/DqtPJEJ9WuUq/AG6j7eUZN2Bs6E3+f8Kv+lyvC/q/NuO/eA OliWuzkAJspRhDPEu795EG5kNMJcnf3IGgUkQpOcFlUhMgiBo/2STdgB0e7hgzT0v+pM 5d5QG66DXUaGKtaK4OFIAQ0ER+jlduEHXT5jugXzHIQLEK/sDwuurFMz282Ekz3kskBQ bI/wtmdITqnZV6oL+xK5HYIlIaMYy3z482coLtrnNCaculF3ew0Opzu2I9OyoLSmlMdi RFmZKNQOPj7VJ/fz8z6TeVvZKOWKtrgzWJMOoPntAiK2k1hNv967LGnutAOB0bCQzca6 FDGQ== X-Gm-Message-State: ANoB5pmV7j5Z6TeqQxLdfjE7QR/A3wnGBA37lgC5e7KE3HwCph+AFeE1 IuinkK5ChS0ca46RFLp5bOKdTCiybD9HAAekmZb2EfLO X-Google-Smtp-Source: AA0mqf5+7gah13VIm9AgftR/THg1TMwLFM9Q9tppnZ+s4vhc3gcva67XchFe9LA0+HE4Ye5JSATbrL/ogE1kWwrqFmw= X-Received: by 2002:a17:906:2894:b0:7aa:7c3f:8603 with SMTP id o20-20020a170906289400b007aa7c3f8603mr2887759ejd.322.1668704529174; Thu, 17 Nov 2022 09:02:09 -0800 (PST) MIME-Version: 1.0 References: <5c07cdb4-ec26-c7bf-087a-4d0c75ef8549@suse.com> <1d94f66d-eb94-d148-0b7d-f4de8c3873e2@suse.com> <7593a96c-6895-9636-22ef-0a18bd5e5d1b@suse.com> In-Reply-To: <7593a96c-6895-9636-22ef-0a18bd5e5d1b@suse.com> From: "H.J. Lu" Date: Thu, 17 Nov 2022 09:01:30 -0800 Message-ID: Subject: Re: [PATCH 2/2] x86: break gas dependency on libopcodes To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 17, 2022 at 8:59 AM Jan Beulich wrote: > > On 17.11.2022 17:55, H.J. Lu wrote: > > On Thu, Nov 17, 2022 at 8:53 AM Jan Beulich wrote: > >> > >> On 17.11.2022 17:48, H.J. Lu wrote: > >>> On Thu, Nov 17, 2022 at 5:29 AM Jan Beulich wrote: > >>>> --- a/gas/configure.ac > >>>> +++ b/gas/configure.ac > >>>> @@ -420,7 +420,7 @@ changequote([,])dnl > >>>> > >>>> # Do we need the opcodes library? > >>>> case ${cpu_type} in > >>>> - vax | tic30) > >>>> + vax | tic30 | i386) > >>>> ;; > >>> > >>> This change isn't needed to move i386_seg_prefixes to gas. > >> > >> Correct, but it is needed to fulfill the purpose of the patch as per > >> its title. Otherwise an unused NEEDED entry remains in gas'es .dynamic. > > > > This patch should be a standalone patch. > > I'll split, but I'm nevertheless curious as to why: With it in a separate It should be the first patch, not the last. > patch, there'll be an intermediate bogus state - gas will require > libopcodes.so for no reason. Personally I'd consider such a (minor) bug. > > Jan -- H.J.