From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id 62FD03858C98 for ; Thu, 4 Apr 2024 13:39:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62FD03858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62FD03858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712237949; cv=none; b=sRbnDghTLNnetRtqdMCUijGErPGHjMugY8djqsWT9kPZyt7vPAuaSQ0LKb6w/eT19m1UJfP1cgp70/a80TdW9cyVoXqSt2UWhNLC1392ZhaFPYnRhnPQSmyYIFRX4OB6wES1aHs2Jns/oqpcmeie68k2SrT2rs+a9uIBUpgg8z0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712237949; c=relaxed/simple; bh=/YlR3ePuz/6X/Hkx4knj+1BzhtPpp07VSPOlX8ZmmJw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=DR83wYrMRDFnzRl4mV8JYpndYDcVRfbb6FZphirbX9Sx1vMsna9GVScOd/yapc9pMLopOA99fJFbScVF4LRrofwKfwiI7UtMcHBdTxpGfHhSO4i6fhaPA/h1Be5udsBFGoHJGyXDlJxV+fwDCDxvtLuokohIE6TZHWhIF+0Exus= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-6154a3df493so16215937b3.1 for ; Thu, 04 Apr 2024 06:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712237947; x=1712842747; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qbmNv8iAFiYU+efqmWTkbniY95OG/n2la5ZdOEjfxd4=; b=XiZO3UY5bkP5fCSsw7pEjbBq2mUlQihCGrZ1NLW2k9S+4EYYQKZVKb1cN+rKOM3P19 JMK4q+gYFnB0aHFKowUGg/hzw1Xu0Y7qwiJH6zGtEtlsV6W6gsn4ZR1XX00pjvYR17uV L0w3wWQNBcb7A3OnaImvYGRPSSDoRm2U3wbZzUiB4uVZjpOEDPLs2askO2k5Ov8Tiujv iB2NwaSlE83Si+oRNMcFEosboqDMqVMHsbipbfdO69i7PhKc8abjO+G7gEHLZZqvE+yW npkc/6zdjHcsLDW5j9Gjuwe11ah6DM2Hd2UnwDLm981xo4O8PjASFhHY1Pvjuo08qTLY 3M7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712237947; x=1712842747; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qbmNv8iAFiYU+efqmWTkbniY95OG/n2la5ZdOEjfxd4=; b=INxG/F7RLVKlnTFWJ3U9OzJC9iSBp1QW+fNIJPXkwBVKUgMYn0alUNVtEVF3cRCtyT pAjtZl5rqNI5GfdxmkQTOVLlluBj2AciLzdF9QT3dhweDmCoXSuMRpESRbJ0L3hYqd/e SoGW9C3oUGLWmWpXPexVaW00LycUo3QxjbwtfrEKDFiqwo+bgiV2zbDXvCxMaLC2drx4 L2mxhWTNtwE3fauyXk06QurkqRwm19NHPNxY/O8ugbtQBSNvL+iVQgza2g0QVfjbB380 uMw98IS2py9I81AFNQ6BB1X92zOKaPyRuZrGroKztSagicmi/Bg2hiGJXx3KyOvFOyXO 2H9Q== X-Gm-Message-State: AOJu0YwRG7/cOG4t7TzMtqYW4QTsKi7dsrkBsq7vLTUW4UaGDFDxeNNv 7HO8fqAFScFHShmghkvDQL5pMA6GmKMvVdsLwjrOvd0yp34WE4sbO9wJdsZevUJilazARXp8mVn Il7L0FYDD+xYaOCnufZyH+hpqzxFeMzcrJaQ= X-Google-Smtp-Source: AGHT+IERII6LTlM+6Rmc7qlOLQnWG9A4IqGxMqOSitrQ/eRYnrwXoVG3t1cyWvmqncYHTNUiPYYwkn1jNF5HGdx/0BI= X-Received: by 2002:a25:e4c2:0:b0:dcc:6894:4ac0 with SMTP id b185-20020a25e4c2000000b00dcc68944ac0mr172534ybh.20.1712237946725; Thu, 04 Apr 2024 06:39:06 -0700 (PDT) MIME-Version: 1.0 References: <20240404013433.613048-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 4 Apr 2024 06:38:30 -0700 Message-ID: Subject: Re: [PATCH] bfd_mmap_local: Check offset and size To: Alan Modra Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 4, 2024 at 12:20=E2=80=AFAM Alan Modra wrote= : > > On Wed, Apr 03, 2024 at 06:34:33PM -0700, H.J. Lu wrote: > > Update bfd_mmap_local to return NULL if offset + size > the file size. > > > > * libbfd.c (bfd_mmap_local): Validate offset and size against > > the file size. > > --- > > bfd/libbfd.c | 13 +++++-------- > > 1 file changed, 5 insertions(+), 8 deletions(-) > > > > diff --git a/bfd/libbfd.c b/bfd/libbfd.c > > index 34197b75b5e..400a5a47d2a 100644 > > --- a/bfd/libbfd.c > > +++ b/bfd/libbfd.c > > @@ -1072,18 +1072,15 @@ static void * > > bfd_mmap_local (bfd *abfd, size_t rsize, int prot, void **map_addr, > > size_t *map_size) > > { > > - if (!_bfd_constant_p (rsize)) > > + ufile_ptr filesize =3D bfd_get_file_size (abfd); > > + ufile_ptr offset =3D bfd_tell (abfd); > > + if ((offset + rsize) > filesize) > > Doesn't need parens around "offset + rsize" here. Also, can this > expression ever overflow? If so it would be better written as > > if (filesize < offset > || filesize - offset < rsize) The v2 patch: https://sourceware.org/pipermail/binutils/2024-April/133372.html --=20 H.J.