From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com
 [IPv6:2607:f8b0:4864:20::735])
 by sourceware.org (Postfix) with ESMTPS id 4C63A38582A2
 for <binutils@sourceware.org>; Wed, 17 Aug 2022 19:20:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C63A38582A2
Received: by mail-qk1-x735.google.com with SMTP id b9so5557614qka.2
 for <binutils@sourceware.org>; Wed, 17 Aug 2022 12:20:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=CeoXPztq9ROAJs6aUz2Ims2CS/j7xbdbK+zjhzuxRzE=;
 b=3tVENx62to8JAXH803Dgaqq10wL8Bh3My3WH/qW4evQSfxQ6sGy0VCsbe5pw83cJZ7
 Xu3mc8jimSWY49pBsNRm98lFBPDDkX7Sl9AqJEzzX+HoawARQo4bYg++930/5MwzUh3d
 M95cQ0W6jM0Twn8Rcry/OoQFr5JaaoKYE+p2/BFB5967Oyx3NtdsxCQPVghmAmA4ojeE
 iAYSs1c9sVF3eHqFi1zHXn1Wz7jqdCWdndMuzJeVNjc/NzeBBnea1MKAlk2kRv5LIj2v
 MuIq1+0LsOE8JOz4MfwByCxiEpldxhOVaz4FvFzv5HB24CPMyq6OVR3oO3Dr5I13Nv1J
 XnJg==
X-Gm-Message-State: ACgBeo0wvKJ/WsklzE2vRpiAmmYkxqpDAJdVUkByhyyi/3/T2/HQtW90
 XaTnfPQgt+1fb77uV/LM/6A/KKvYqRRz+icv81d4OE9T
X-Google-Smtp-Source: AA6agR4u3wFKSLX63uzAqNWstWI6u98W8y01/Ol79d6NVSIt8Tiykb8cUV6jT1Bt8vQS2fq10oe9wfvDxkGRsxFgo6A=
X-Received: by 2002:a05:620a:2699:b0:6b8:c299:23c2 with SMTP id
 c25-20020a05620a269900b006b8c29923c2mr18943974qkp.768.1660764021559; Wed, 17
 Aug 2022 12:20:21 -0700 (PDT)
MIME-Version: 1.0
References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com>
 <bb970033-2262-07b7-a378-14c7b7b54361@suse.com>
In-Reply-To: <bb970033-2262-07b7-a378-14c7b7b54361@suse.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 17 Aug 2022 12:19:45 -0700
Message-ID: <CAMe9rOp6UwLL5p2pJ-MqRmE5BJk6JYsLkX1jomPc-fP_r=BO-g@mail.gmail.com>
Subject: Re: [PATCH 2/7] x86: insert "no error" enumerator in i386_error
 enumeration
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3018.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2022 19:20:25 -0000

On Tue, Aug 16, 2022 at 12:30 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> The value of zero would better not indicate any error, but rather hit
> the abort() at the top of the consuming switch().
>
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -226,6 +226,7 @@ union i386_op
>
>  enum i386_error
>    {
> +    no_error, /* Must be first.  */
>      operand_size_mismatch,
>      operand_type_mismatch,
>      register_type_mismatch,
>

OK.

Thanks.

-- 
H.J.