From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] bfd: Don't check non-thin archive member file size
Date: Mon, 27 Dec 2021 05:31:13 -0800 [thread overview]
Message-ID: <CAMe9rOp7pBpCJQu2XAPm5gCkJsy8v1jJHTwTpEGO+z3Kt8ZvPg@mail.gmail.com> (raw)
In-Reply-To: <YcljmQy8lsidp7EI@squeak.grove.modra.org>
On Sun, Dec 26, 2021 at 10:56 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Fri, Dec 24, 2021 at 03:46:04PM -0800, H.J. Lu via Binutils wrote:
> > There is no need to check member file size for thin archive member.
>
> Does it hurt to check against the file size recorded in the archive
> header? Did someone report a "bug", perhaps that a thin archive
> member file was updated without running ar, and then hit an error?
>
While debugging a GCC bootstrap bug, I copied a .o file without running
ar on a thin archive. Other linkers didn't complain. There is no need to.
--
H.J.
next prev parent reply other threads:[~2021-12-27 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 23:46 H.J. Lu
2021-12-27 6:56 ` Alan Modra
2021-12-27 13:31 ` H.J. Lu [this message]
2021-12-28 8:19 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOp7pBpCJQu2XAPm5gCkJsy8v1jJHTwTpEGO+z3Kt8ZvPg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).