From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27198 invoked by alias); 18 Feb 2015 12:56:30 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 27179 invoked by uid 89); 18 Feb 2015 12:56:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ob0-f181.google.com Received: from mail-ob0-f181.google.com (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 18 Feb 2015 12:56:28 +0000 Received: by mail-ob0-f181.google.com with SMTP id vb8so1383510obc.12; Wed, 18 Feb 2015 04:56:27 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.103.234 with SMTP id fz10mr18463616oeb.11.1424264187097; Wed, 18 Feb 2015 04:56:27 -0800 (PST) Received: by 10.76.134.102 with HTTP; Wed, 18 Feb 2015 04:56:26 -0800 (PST) In-Reply-To: <20150218120841.GD23529@adacore.com> References: <20150107144548.GX5432@adacore.com> <20150218120841.GD23529@adacore.com> Date: Wed, 18 Feb 2015 12:56:00 -0000 Message-ID: Subject: Re: ping #3: [RFA] Add --with-libz-prefix option in config/zlib.m4 From: "H.J. Lu" To: Joel Brobecker Cc: GCC Patches , Binutils , GDB Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00242.txt.bz2 On Wed, Feb 18, 2015 at 4:08 AM, Joel Brobecker wrote: > Yay? Nay? > > Thank you. > > On Wed, Jan 07, 2015 at 06:45:48PM +0400, Joel Brobecker wrote: >> Hello, >> >> This patch enhances config/zlib.m4 to introduce an extra option >> --with-libz-prefix which allows us to provide the location of >> the zlib library we want to use during the build. >> >> config/ChangeLog: >> >> * zlib.m4 (AM_ZLIB): Add --with-libz-prefix option support. >> >> I didn't see any file in the GCC project that uses this macro, >> so for the GCC repository, the change to zlib.m4 is it. But >> I am also attaching to this email a copy of the patch that >> will be applied to the binutils-gdb.git repository, with all >> configury using this macro being re-generated - mostly for info, >> also as a heads-up to both binutils and GDB. >> >> This was tested by regenerating all autoconf/automake files in >> the binutils-gdb project, and rebuilding GDB, using the following >> combinations: >> >> --with-zlib (system zlib used) >> --with-libz-prefix=/zlib/prefix (specific zlib linked in) >> --with-zlib --with-libz-prefix=/zlib/prefix (specific zlib linked in) >> >> --without-zlib (zlib support turned off) >> --without-zlib --with-zlib-prefix (zlib support turned off) >> >> --with-zlib (no system zlib available, configure fails with expected error) >> --with-zlib --with-libz-prefix=/invalid/zlib/prefix >> (no system zlib, configure fails with same error) >> >> OK to commit? Why do you want to turn off zlib? On Linux/x86, zlib is required for assembler. At least, you should issue an error when --without-libz is used in binutils for Linux/x86 target. I guess someone has asked it before. Why can't zlib be made the same as --with-mpc=PATH specify prefix directory for installed MPC package. Equivalent to --with-mpc-include=PATH/include plus --with-mpc-lib=PATH/lib --with-mpc-include=PATH specify directory for installed MPC include files --with-mpc-lib=PATH specify directory for the installed MPC library It is more flexible than your patch. If you have some existing packages which use your scheme, you can translate the configure command line options to this one. -- H.J.