From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 76F713860742 for ; Mon, 21 Nov 2022 16:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76F713860742 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32d.google.com with SMTP id 46-20020a9d0631000000b00666823da25fso7700355otn.0 for ; Mon, 21 Nov 2022 08:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=A4hFvT2+hHWnCmB7QXkosn8mv0kRZpjO+jP/jCjmBm0=; b=An91rcnK6VeuVlRJBY+3HmT29kFq7IqQzKMmnX9HYeyvfVebY2ykLoszZAwECPUXdx YbQZ9k9MUTwINQBLSMr9L9ea9xoZcU6cHakQQ4bnfeW69r8ptzkHsOqRSIATByzeeDs+ +7zREUzC2iINT6LH8XCXR16pspcMSzMD7PpRFBJIOpBiIUSAMLKlAW2cUCt6HTCmmSbF WYnKthPr9PRkFSxr67ShZ8wzPvSHFq26L0MRTEDIvoHIMA4en6m150CXq70oG+f605ug PmcvHIGg9KR4uNzJuQHlW7/e7mA8ZPisSNFZO0kxpmObPAoG4nkQRSfzlvXplJiWOEGg GpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A4hFvT2+hHWnCmB7QXkosn8mv0kRZpjO+jP/jCjmBm0=; b=Pmc0mhrXSajVJ+bfJAIPglcG/NsqOZDGspyzWAsjSY2JrzAlSsCTh+0UOqHrMme4Sh N7Tya/Pd8Ia4BWSKQ7xW2T786J7CQnLvKD52lKkarBVVZpF31vfOR2yHFR2SvpGohEam oHdS3APUSBrhDWlOIqU28Xc8weBS8nA9u9RD694FEaun8Jj6cbZy3rK9p0iPIyRVdvL/ /11F92NgCcgEqgRz4Gk6324ibHOIJsj/E5k3yrTEgV4z3Wyy6kzL+wNVg3FMtHf+Kcwj S5wrREWY/vorrUG89UC1Ls+JM5HGgAPaHxsRBTnkYBysn6Gnkf6pywTWs/+kx0eCGJEp JhxA== X-Gm-Message-State: ANoB5pks+MeMg7jYAcSyQDXDvnM2ryLIcgRVexuhjhpHzjMpJ98tV97E NzRN+bg3NNNsaP1s1VQEW28q3ro4VgEIl/yXtNnub8+cqSE= X-Google-Smtp-Source: AA0mqf497Tey2QOikBU42nyFaxCS1HIcU/2C3CHX3L9SUWXY9b8nRQ1CdwGB4C8XCXVMyyTW0AKkkNasVQnDNsPyTT0= X-Received: by 2002:a05:6830:1e24:b0:66d:3169:9092 with SMTP id t4-20020a0568301e2400b0066d31699092mr9964516otr.52.1669049069744; Mon, 21 Nov 2022 08:44:29 -0800 (PST) MIME-Version: 1.0 References: <7a1ee76a-5b54-32a6-6301-a1741b5c1883@suse.com> <9d95d33c-7f9a-a64b-7ac0-9ee96f0b99f5@suse.com> In-Reply-To: <9d95d33c-7f9a-a64b-7ac0-9ee96f0b99f5@suse.com> From: "H.J. Lu" Date: Mon, 21 Nov 2022 08:43:53 -0800 Message-ID: Subject: Re: [PATCH v2 3/4] x86: break gas dependency on libopcodes To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 21, 2022 at 8:32 AM Jan Beulich wrote: > > On 21.11.2022 17:26, H.J. Lu wrote: > > On Fri, Nov 18, 2022 at 1:13 AM Jan Beulich wrote: > >> > >> gas doesn't use anything from libopcodes anymore - suppress linking in > >> that library. > >> --- > >> v2: New, split off from larger earlier patch. > >> > >> --- a/gas/configure > >> +++ b/gas/configure > >> @@ -12263,7 +12263,7 @@ _ACEOF > >> > >> # Do we need the opcodes library? > >> case ${cpu_type} in > >> - vax | tic30) > >> + vax | tic30 | i386) > >> ;; > >> > >> *) > >> --- a/gas/configure.ac > >> +++ b/gas/configure.ac > >> @@ -420,7 +420,7 @@ changequote([,])dnl > >> > >> # Do we need the opcodes library? > >> case ${cpu_type} in > >> - vax | tic30) > >> + vax | tic30 | i386) > >> ;; > >> > >> *) > >> > > > > We need to add some dependencies on i386-opc.tbl and i386-reg.tbl for > > --enable-maintainer-mode to check if i386-tbl.h and i386-init.h are up to > > date. It doesn't need to regenerate i386-tbl.h. An error message should be > > sufficient. > > This isn't needed here, but in patch 2, where I'm already adjusting > existing dependencies. Since I'm not modifying any toplevel files, the > building of opcodes/ still ought to be happening before the building of > gas/, so I don't see why any further changes should be necessary. Please > clarify if you see any such reason. > Since gas no longer depends on libopcodes, one may change i386-opc.tbl and run "make" in gas. It is more reliable than the fake dependency in opcodes. -- H.J.