From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by sourceware.org (Postfix) with ESMTPS id 5CFC93858C62 for ; Wed, 12 Oct 2022 17:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CFC93858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf30.google.com with SMTP id o67so10849698qvo.13 for ; Wed, 12 Oct 2022 10:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PZ7QOwV7dRtUvWErHmT/WRL+rSzvgDuj+Ppuke2ki+U=; b=D2C/0bEgiJ500ScEUr7ujoxCET9h6L6hHULukAuT0X76lliZ1aYXdfoNKZ7X4kkgQQ ZoCuj4Y+DaftNEZjQY7gYidlsqAZER+Nis+Bb+KRnL2pEVDamIufs0jhDN8ti5f5/Af2 Q6Yt6w2cm1koVOBUKcfYzgykSYD0ziYbj3CLzMvuuNV1qJgp3A6KV+9T3QniOHJ2Kk/w +a0CZ3TMzoB0vBB4BaGLkiAfX8tYvSDidKM8uYq4yu1sWeTeXcnSZPQpIU/H0EM2U9EJ z2xwA6P1Q7+Y9WFA1OOgWBiM3lL9Os1wMHbhJH69FWohvmOIADBcmAuc9n1rUuHeEX36 Yh3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PZ7QOwV7dRtUvWErHmT/WRL+rSzvgDuj+Ppuke2ki+U=; b=7VtI4U3xqvaniF1WRa5HEqZ+nRis/3V/BsdUJUV/y0PmxOC8Tl8IoaUK3h6E8jImiw 7fNskezLA8lA5W6patFG4Z90CpirO4B48/GsG1273TmRaDrSSowmyAiPkcryRpKwa0D5 5ssLtGLB7DUdpJDklCz6IKMRPw7vARrCtSJDlgweFNzYNUy3uA2dn8P0ViTknA1Wb0Wg ApIe3iHBs+dLUJGw7lKsP0k98Nr16PVSg93dD8Ioyo5E70iRfyjoAENdLsDTFergUH1c LZD/dp3IJehc0s1xD46aK6W97gEhhqShWVuyLsB++FnAlMq2x0YKv5vNh4B4O+oqyQIf YbvA== X-Gm-Message-State: ACrzQf1YUq5HhLsVpriESQ28eeoFolv2T9Spi/ks6xAyEFiZMpKwudY7 A2RyjKPMrRgW59OORF99CjM3WxZu4zm08EIl51bHqrRD X-Google-Smtp-Source: AMsMyM4v4sqhlwzgzEU78/ohtCXA5idsHvIWTPmha8nxgQcJjRbBYFT/9TSv7dYAapBjrYlY6CAmdwjNqtEegHy37rg= X-Received: by 2002:a05:6214:c42:b0:4b4:2d1:c752 with SMTP id r2-20020a0562140c4200b004b402d1c752mr13498340qvj.28.1665594652663; Wed, 12 Oct 2022 10:10:52 -0700 (PDT) MIME-Version: 1.0 References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> <2981100a-17bf-623c-27fc-0da08279c3ff@suse.com> In-Reply-To: <2981100a-17bf-623c-27fc-0da08279c3ff@suse.com> From: "H.J. Lu" Date: Wed, 12 Oct 2022 10:10:16 -0700 Message-ID: Subject: Re: [PATCH v3 4/7] x86-64: further re-work insn/suffix recognition to also cover MOVSL To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 12, 2022 at 12:08 AM Jan Beulich wrote: > > On 11.10.2022 19:44, H.J. Lu wrote: > > On Wed, Oct 5, 2022 at 12:24 AM Jan Beulich wrote: > >> > >> PR gas/29524 > >> In order to make MOVSL{,Q} behave similarly to MOVSB{W,L,Q} and > >> MOVSW{L,Q} we need to defer parse_insn()'s emitting of errors unrelated > >> to prefix parsing. Utilize i.error just like match_template() does. > > > > Since movs{b,w,l,q} are string instructions, integer sign extensions > > require a suffix to specify the destination size. This is different from other > > integer instructions. Since only the new assembler allows the implicit suffix, > > it won't be easy to use. We should improve error messages, but allowing > > new syntax doesn't help much. > > It is an earlier change making most of this consistent with MOVZ*; it is MOVZ is different. There are no MOVZ string instructions. MOVS has different meanings in ISA. MOVS difference from MOVZ in assembly syntax should be expected. > only logical to extend this to the long-to-quad sign-extending insn. As > with any fixes to prior misbehavior - of course one needs to play by the > rules of the older assembler for a number of years. But projects raise > their baselines, and hence at some point projects with an "avoid suffixes > if possible" policy could switch. > > Jan -- H.J.