From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] x86: Mark cvtpi2ps and cvtpi2pd as MMX
Date: Wed, 19 Feb 2020 14:10:00 -0000 [thread overview]
Message-ID: <CAMe9rOpEPn39D5+gN++gc7SrQPOiyLXKdq=X-7NccLHUmjMQfg@mail.gmail.com> (raw)
In-Reply-To: <e0627cd4-29cc-e535-e7c4-70958bd63341@suse.com>
On Wed, Feb 19, 2020 at 5:53 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 19.02.2020 14:46, H.J. Lu wrote:
> > On Wed, Feb 19, 2020 at 5:40 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 19.02.2020 14:14, H.J. Lu wrote:
> >>> On Wed, Feb 19, 2020 at 5:04 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>>> On 19.02.2020 13:58, H.J. Lu wrote:
> >>>>> --- a/gas/config/tc-i386.c
> >>>>> +++ b/gas/config/tc-i386.c
> >>>>> @@ -8636,7 +8636,9 @@ output_insn (void)
> >>>>> x86_feature_2_used |= GNU_PROPERTY_X86_FEATURE_2_X87;
> >>>>> if (i.has_regmmx
> >>>>> || i.tm.base_opcode == 0xf77 /* emms */
> >>>>> - || i.tm.base_opcode == 0xf0e /* femms */)
> >>>>> + || i.tm.base_opcode == 0xf0e /* femms */
> >>>>> + || i.tm.base_opcode == 0xf2a /* cvtpi2ps */
> >>>>> + || i.tm.base_opcode == 0x660f2a /* cvtpi2pd */)
> >>>>
> >>>> While for the former I agree, the latter - as pointed out
> >>>> elsewhere - does explicitly _not_ switch into MMX mode when
> >>>> the source operand is in memory.
> >>>
> >>> They are still MMX instructions even with memory operand.
> >>
> >> Not exactly, see CVTPI2PD's description in the SDM.
> >
> > They are MMX in term of pure SSE.
>
> As per your suggested doc patch "pure SSE" means "not touching MMX
> registers or state". This is the case for CVTPI2PD.
I will exclude cvtpi2ps and cvtpi2pd explicitly.
--
H.J.
next prev parent reply other threads:[~2020-02-19 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 12:58 H.J. Lu
2020-02-19 13:05 ` Jan Beulich
2020-02-19 13:15 ` H.J. Lu
2020-02-19 13:40 ` Jan Beulich
2020-02-19 13:47 ` H.J. Lu
2020-02-19 13:53 ` Jan Beulich
2020-02-19 14:10 ` H.J. Lu [this message]
2020-02-19 14:19 ` Jan Beulich
2020-02-19 14:23 ` H.J. Lu
2020-02-19 14:36 ` Jan Beulich
2020-02-19 14:46 ` H.J. Lu
2020-02-19 14:58 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpEPn39D5+gN++gc7SrQPOiyLXKdq=X-7NccLHUmjMQfg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).