From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 471BF3858403 for ; Mon, 24 Oct 2022 19:16:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 471BF3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x235.google.com with SMTP id r22so14020731ljn.10 for ; Mon, 24 Oct 2022 12:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=StUlCVUrcTEYZSNdWydiGF74fkG/tKXgOocj31WR4lY=; b=iyb/57aNzDKohUDfwrcH2cS1qZKuXgdaHJHyIJvCKhQhzf5Rq+hw9cngeklJ8HlRUV PAMVswAYeb9k+GoITccj0mnU9RgDxsQLLvVYAt9CrSW8BdGKK9rES0nXgVo2aLWOHoxp qt+mrLQ77vJuD7h4AmLlLDgZEVONIzalVmcdnquX9DKAQPTi59IJZvZBbM1mQBImUKzz BeDkc08M0I4YkSiHb6o+oJ1n5x6pU54PiIKlw+JLJEa0HBidaHTCarVnGxlweNLW6mk7 qJqGaSHhs6j0JJ5bjmb64R176wSPfoxvXkcD6QJQUPcFfUG5CEVRMKO4Fs2x1rX1spR1 0tZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=StUlCVUrcTEYZSNdWydiGF74fkG/tKXgOocj31WR4lY=; b=wYiXMgKtj/qF7raLuoTvjJjqOtnEbziI+ADPT2jmD0IEoyZp5q+chjK0Kllolgml0L o8WIthKnGySRPP/fgWLrZ5ZqiWTcvxsRI1APSAI7DVtPqWkzUKvU0MlKB0NGJcstpRfZ ladd8RhaXKnc4mY+oIQVw+voVtPFVxkSBj7VeDCnIDmnoLVCrZTrV5Uwl7feYGfapLwl Mxe5qmwANZmY4Ly/wzFccqFRAUwbnARSXxzWQwbspBrwHgysgM2hYPWwGnwcXqnZ7Oid DBcKWOIEPaO6Skuv7a0ipl/1DVtTNkNrPYcbwWiYTu/712gNP2kGlfrXu7noS9O+hue9 2dJA== X-Gm-Message-State: ACrzQf3/IaZ3r82aaZHeE/0GtZJDENzYXrg9eZcF5T2SiEsTCIJ7YYPq vXbcbXd6sEIIMviqv0kZ7JpJyqW+68OAmWr9RaY= X-Google-Smtp-Source: AMsMyM6mwM7b3QPibhh7oPksvwiijE8+NT61xk8h8XqJNywVaXQ2vdHA7i5rc0jvhk2nXiJX8LWQ+2okN4+HkG7xqrk= X-Received: by 2002:a2e:9794:0:b0:277:a8e:eb6 with SMTP id y20-20020a2e9794000000b002770a8e0eb6mr2595838lji.257.1666638964877; Mon, 24 Oct 2022 12:16:04 -0700 (PDT) MIME-Version: 1.0 References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-9-haochen.jiang@intel.com> <9d80838e-6b6a-339c-820d-90e3da899384@suse.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 24 Oct 2022 12:15:28 -0700 Message-ID: Subject: Re: [PATCH 08/10] Support Intel MSRLIST To: "Jiang, Haochen" Cc: "Beulich, Jan" , "Hu, Lin1" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Oct 23, 2022 at 10:56 PM Jiang, Haochen wrote: > > > -----Original Message----- > > From: Jan Beulich > > Sent: Monday, October 17, 2022 3:20 PM > > To: Jiang, Haochen > > Cc: hjl.tools@gmail.com; Hu, Lin1 ; > > binutils@sourceware.org > > Subject: Re: [PATCH 08/10] Support Intel MSRLIST > > > > On 14.10.2022 11:12, Haochen Jiang wrote: > > > From: "Hu, Lin1" > > > > > > gas/ChangeLog: > > > > > > * NEWS: Support Intel MSRLIST. > > > * config/tc-i386.c: Add msrlist. > > > * doc/c-i386.texi: Document .msrlist and nomsrlist. > > > * testsuite/gas/i386/i386.exp: Add MSRLIST tests. > > > * testsuite/gas/i386/x86-64-lockbad-1.l: Add msrlist. > > > * testsuite/gas/i386/x86-64-lockbad-1.s: Ditto. > > > * testsuite/gas/i386/msrlist-inval.l: New test. > > > * testsuite/gas/i386/msrlist-inval.s: Ditto. > > > * testsuite/gas/i386/x86-64-msrlist-intel.d: Ditto. > > > * testsuite/gas/i386/x86-64-msrlist.d: Ditto. > > > * testsuite/gas/i386/x86-64-msrlist.s: Ditto. > > > > > > opcodes/ChangeLog: > > > > > > * i386-dis.c (X86_64_0F01_REG_0_MOD_3_RM_6_P_1): New. > > > (X86_64_0F01_REG_0_MOD_3_RM_6_P_3): Ditto. > > > (prefix_table): New entry for msrlist. > > > (x86_64_table): Add X86_64_0F01_REG_0_MOD_3_RM_6_P_1 > > > and X86_64_0F01_REG_0_MOD_3_RM_6_P_3. > > > * i386-gen.c (cpu_flag_init): Add CPU_MSRLIST_FLAGS > > > and CPU_ANY_MSRLIST_FLAGS. > > > * i386-init.h: Regenerated. > > > * i386-opc.h (CpuMSRLIST): New. > > > (i386_cpu_flags): Add cpumsrlist. > > > * i386-opc.tbl: Add MSRLIST instructions. > > > * i386-tbl.h: Regenerated. > > > --- > > > gas/NEWS | 2 + > > > gas/config/tc-i386.c | 1 + > > > gas/doc/c-i386.texi | 3 + > > > gas/testsuite/gas/i386/i386.exp | 3 + > > > gas/testsuite/gas/i386/msrlist-inval.l | 3 + > > > gas/testsuite/gas/i386/msrlist-inval.s | 7 + > > > gas/testsuite/gas/i386/x86-64-lockbad-1.l | 100 +- > > > gas/testsuite/gas/i386/x86-64-lockbad-1.s | 4 + > > > gas/testsuite/gas/i386/x86-64-msrlist-intel.d | 14 + > > > gas/testsuite/gas/i386/x86-64-msrlist.d | 14 + > > > gas/testsuite/gas/i386/x86-64-msrlist.s | 11 + > > > opcodes/i386-dis.c | 17 + > > > opcodes/i386-gen.c | 5 + > > > opcodes/i386-init.h | 516 +- > > > opcodes/i386-opc.h | 3 + > > > opcodes/i386-opc.tbl | 7 + > > > opcodes/i386-tbl.h | 7844 +++++++++-------- > > > 17 files changed, 4350 insertions(+), 4204 deletions(-) create mode > > > 100644 gas/testsuite/gas/i386/msrlist-inval.l > > > create mode 100644 gas/testsuite/gas/i386/msrlist-inval.s > > > create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist-intel.d > > > create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.d > > > create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.s > > > > See some of the comments to patch 7, which apply here equally. > > Changes are quite same as patch 7. > > In tc-i386.c, we changed ANY_MSRLIST to MSRLIST. Please also remove CPU_ANY_MSRLIST_FLAGS since it isn't used. > Removed lockbad testcases. > > Removed not needed allow_index_reg. > > Haochen > > > > > Jan > -- H.J.