From: "H.J. Lu" <hjl.tools@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Binutils Development <binutils@sourceware.org>
Subject: Re: [PATCH 3/5] remove deleted BFDs from the archive cache
Date: Thu, 16 Aug 2012 20:38:00 -0000 [thread overview]
Message-ID: <CAMe9rOpLRwAzwNe8G1QUDwG7gCpV7BEi_QF_vmgr5Tf8o+p=JQ@mail.gmail.com> (raw)
In-Reply-To: <87ipcioepw.fsf@fleche.redhat.com>
On Thu, Aug 16, 2012 at 11:48 AM, Tom Tromey <tromey@redhat.com> wrote:
> HJ> Do you have testcases for those problems?
>
> Just running valgrind using a test program.
>
> Tom> If you mean reverting the patches, I don't agree with it, but that is up
> Tom> to you.
>
> HJ> I don't think it is a bad idea.
>
> Here's a reversion patch.
> I couldn't find a ChangeLog for one of the patches, the one Nick
> committed.
>
> I'll open some bugs.
>
> If you check this in, please let me know so I can revert the gdb patch.
> Thanks.
>
> Tom
>
> 2012-08-16 Tom Tromey <tromey@redhat.com>
>
> * archive.c, libbfd-in.h, libbfd.h, opncls.c: Revert patches
> relating to archive handling:
> 2012-08-16 Tom Tromey <tromey@redhat.com>
> 2012-08-09 Alan Modra <amodra@gmail.com>
> Tom Tromey <tromey@redhat.com>
>
I checked in a testcase for
http://www.sourceware.org/bugzilla/show_bug.cgi?id=14481
If we revert it now, we get a regression.
--
H.J.
next prev parent reply other threads:[~2012-08-16 20:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:55 Tom Tromey
2012-08-03 16:12 ` Alan Modra
2012-08-03 20:56 ` Tom Tromey
2012-08-08 22:47 ` Tom Tromey
2012-08-09 10:35 ` Alan Modra
2012-08-15 20:14 ` H.J. Lu
2012-08-15 21:30 ` Tom Tromey
2012-08-16 14:47 ` Alan Modra
2012-08-16 16:31 ` H.J. Lu
2012-08-16 18:14 ` Tom Tromey
2012-08-16 18:33 ` H.J. Lu
2012-08-16 18:45 ` Tom Tromey
2012-08-16 18:49 ` H.J. Lu
2012-08-16 18:55 ` Tom Tromey
2012-08-16 20:33 ` Tom Tromey
2012-08-16 20:38 ` H.J. Lu [this message]
2012-08-16 21:11 ` H.J. Lu
2012-08-16 21:35 ` H.J. Lu
2012-08-17 1:01 ` Alan Modra
2012-08-17 1:06 ` H.J. Lu
2012-08-17 2:44 ` Alan Modra
2012-08-17 4:56 ` Hans-Peter Nilsson
2012-08-17 5:04 ` Alan Modra
2012-08-17 5:08 ` H.J. Lu
2012-08-17 5:30 ` H.J. Lu
2012-08-17 5:42 ` H.J. Lu
2012-08-17 5:45 ` H.J. Lu
2012-08-17 6:01 ` H.J. Lu
2012-08-17 13:10 ` H.J. Lu
2012-08-17 16:50 ` Hans-Peter Nilsson
2012-08-17 16:01 ` Hans-Peter Nilsson
2012-08-17 16:10 ` H.J. Lu
2012-08-17 16:14 ` Hans-Peter Nilsson
2012-08-17 16:13 ` Tom Tromey
2012-08-17 16:26 ` H.J. Lu
2012-08-17 16:51 ` Tom Tromey
2012-08-17 17:11 ` H.J. Lu
2012-08-17 17:22 ` Tom Tromey
2012-08-17 17:22 ` H.J. Lu
2012-08-17 19:03 ` Tom Tromey
2012-08-17 19:13 ` H.J. Lu
2012-08-18 4:37 ` Alan Modra
2012-08-21 9:55 ` Tom Tromey
2012-08-17 1:17 ` Alan Modra
2012-08-17 15:36 ` Tom Tromey
2012-08-17 15:38 ` H.J. Lu
2012-08-17 15:43 ` Tom Tromey
2012-08-17 0:48 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpLRwAzwNe8G1QUDwG7gCpV7BEi_QF_vmgr5Tf8o+p=JQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).