From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 58B94384A804 for ; Thu, 27 Oct 2022 18:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 58B94384A804 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22d.google.com with SMTP id j14so5001863ljh.12 for ; Thu, 27 Oct 2022 11:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HDlWgD6m18epYFtvLIh2gSzV4Y7E9jPvxoYDsvkhZ8A=; b=NezJRdUbNZC/vE+8Dd/bNjqsdKzoCZIYkqk0M2Ukx9XFWFxCE1PXi53GYEEq0q2YRg xuReZiNV9TibCboPaWT2deQfwCW7EhpE5MTxl1fq0KjKbB4jIgKfGCwmZ3ECL7FOOSm+ 62h2+x73E+ERSfU+Bna2JmOMvDL/EkW3YYid3AD3sOmA4tioUunO0gNpjktv+3k3Lbjc SGByjX27BM9G6MV0NDyE9+fw5NAEHTFr74vJBP/IAaR3SwcDszgjN8lB1xkDCUUYuiiG uPiz7QaPQCvHUhyQQ0lB278ft6DAATx1muqcmvD1rmNRsJVorA9HGvvw3W1SpP7Y0U48 8pSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HDlWgD6m18epYFtvLIh2gSzV4Y7E9jPvxoYDsvkhZ8A=; b=KC/1jqIw0hrSB0PJ3eoTrHdXPNW1eJFSEUffOYBX+r0Yt8ogemDhSHEZeopA6n+XuL O9gxa3hYLy7pcnui3iMQ1bRkaqcQoWOnnj4Dl5zzm4NMM1vG2PzeNuIAAAKBIC8bIFw0 O0Pm33wG667pTmJ6ZCqk5Wr1cPDvxM12F6QTCJW9nZpahC4D+BFEbWlDQm+foeIsg/DU EO/kcq7vcRJgSNPmI/y39RCI8UNndUFgSamhEdc8joRPFbDG+xyAe5SXFSpKR8BOA4zx beZohtxRGz2pQkbBPm1ArNg7LI4wDYPOYq/BbTv1+Y1KuyXXcYQ0znbWbE1zjihC4pll piBg== X-Gm-Message-State: ACrzQf0I8oJcqSKHAUM5AFkTiLpYfaP8D9t6y8WuKH1oMIVMpZlI82oY FyuYo8AaRndnwEneBXh3oQaSagjo48PBZzWMhlc= X-Google-Smtp-Source: AMsMyM726J+sPKopRpt72C+tR3yFsZM/GSvdfA1OiUY3+Jg5c7Pa9GKMKrQFBVYr8uF9diXdc265PQ+97JfhKTc/38k= X-Received: by 2002:a2e:9794:0:b0:277:a8e:eb6 with SMTP id y20-20020a2e9794000000b002770a8e0eb6mr8737411lji.257.1666896422644; Thu, 27 Oct 2022 11:47:02 -0700 (PDT) MIME-Version: 1.0 References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-7-haochen.jiang@intel.com> <1e6a7d9c-4b14-821e-cc46-453adbe6f183@suse.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 27 Oct 2022 11:46:26 -0700 Message-ID: Subject: Re: [PATCH 06/10] Support Intel RAO-INT To: Jan Beulich Cc: "Jiang, Haochen" , "binutils@sourceware.org" , "Kong, Lingling" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 26, 2022 at 11:39 PM Jan Beulich wrote: > > On 27.10.2022 05:50, Jiang, Haochen wrote: > >> -----Original Message----- > >> From: Jan Beulich > >> Sent: Wednesday, October 26, 2022 4:57 PM > >> To: Jiang, Haochen > >> Cc: hjl.tools@gmail.com; binutils@sourceware.org; Kong, Lingling > >> > >> Subject: Re: [PATCH 06/10] Support Intel RAO-INT > >> > >> On 26.10.2022 07:16, Jiang, Haochen wrote: > >>>> -----Original Message----- > >>>> From: Jan Beulich > >>>> Sent: Tuesday, October 25, 2022 3:01 PM > >>>> > >>>> On 24.10.2022 07:56, Jiang, Haochen wrote: > >>>>>> -----Original Message----- > >>>>>> From: Jan Beulich > >>>>>> Sent: Friday, October 14, 2022 10:38 PM > >>>>>> > >>>>>> On 14.10.2022 11:12, Haochen Jiang wrote: > >>>>>>> +aadd, 0xf38fc, None, CpuRAOINT, > >>>>>>> > >>>> > >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, > >>>>>>> +Dword|Qword|Unspecified|BaseIndex} > >>>>>>> +aand, 0x660f38fc, None, CpuRAOINT, > >>>>>>> > >>>> > >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, > >>>>>>> +Dword|Qword|Unspecified|BaseIndex} > >>>>>>> +aor, 0xf20f38fc, None, CpuRAOINT, > >>>>>>> > >>>> > >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, > >>>>>>> +Dword|Qword|Unspecified|BaseIndex} > >>>>>>> +axor, 0xf30f38fc, None, CpuRAOINT, > >>>>>>> > >>>> > >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, > >>>>>>> +Dword|Qword|Unspecified|BaseIndex} > >>>>>> > >>>>>> Why IgnoreSize? Instead I think you need CheckRegSize (assuming it > >> does > >>>>>> enough for Intel syntax memory operands - please double check; if not > >>>> this will > >>>>>> need fixing). > >>>>>> > >>>>> > >>>>> For table, we aligned with CMPccXADD and added No_lSuf and No_qSuf > >>>> since > >>>>> the suffixes are not required. > >>>> > >>>> Which, as said, I consider wrong both here and there. > >>> > >>> I still agree with H.J.. Also I suppose the previous usage of suffixes are quite > >>> messy and we should not stick on the confusing code. > >>> > >>> Keeping consistent with SPEC from now on to avoid confusion on that > >> might > >>> be a better solution for future. > >> > >> Same question to you then: Which spec? As said in reply to H.J., the only > >> spec I'm aware of suggests prefixes ought to be used _whenever_ there's a > >> sized memory operand [1]. If we want to deal with the present "mess", I > >> think we ought to simply allow suffixes consistently. Please point out any > >> other messy aspects beyond that. > > > > The default behavior for current ISA is when there is no suffix required, it won't > > mention that. > > What is "current ISA" here? Looking over the whole set of insns which we > support, it's the vast majority which behaves differently from what you > say. It's been several times that I mentioned that we would better > eliminate this inconsistency. > There is no ambiguity in the RAO-INT spec which requires a suffix. No suffix in A&T syntax is different from legacy instructions. But it is consistent with the RAO-INT spec. -- H.J.