From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id AC0563858C33 for ; Tue, 16 Aug 2022 15:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC0563858C33 Received: by mail-qk1-x72f.google.com with SMTP id g16so6209170qkl.11 for ; Tue, 16 Aug 2022 08:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=1mCwNsFR8qHeRbYzxALQwVjor3AO56iix2UfUTKMqf0=; b=CCLkXctjvxjxNqOwnKR1fsPXF6fAQ4usTzIUNC7fsOyecleCLXym+Nk7HZ0WzM4HWV lXS+qGG+7mAoEYp4bLxJje848EoaeA2Z8RAmLB76WfMdAiIFmbtRZsulgt58h0OVx5m6 Jp2G5TGWfcuP8g8Wxus7ERLB2aOzOCzz/NyVmi5toGLaxwXt3sWRIOfzazMQvYE86xwo rToy9ArdK16ydyXwaEOdMNzD3b93lPml+c7Y9mK8m8rHb50fXv0Q4VNEEh9nBDS7fUAj TxW3mJaBBYHhOcJ9z1q+aaSmBjM2wnJ7dq7N6MbvBj7uXlwNqkKLXviFu+SIY1VdLIm1 tkIA== X-Gm-Message-State: ACgBeo16wvCXA4MRLUDnIX4iUz50gPXmLn/Fvwu6jyugt5xDKvbfezeW 5DpxB+S4z2T9V4Ww+7+oSEwQ+BUO7SrIaQ9R3UuMcwtBx48= X-Google-Smtp-Source: AA6agR7vkp8qB7Z9PSWV0LvAVXOo71khF9hri2BuOJCJKKao8XDZ0OqNE/z/KJd03F0p4/Eb3EiGUtihzZZ/959d0e0= X-Received: by 2002:a37:e20e:0:b0:6b6:1f7d:1c98 with SMTP id g14-20020a37e20e000000b006b61f7d1c98mr15267509qki.670.1660665255967; Tue, 16 Aug 2022 08:54:15 -0700 (PDT) MIME-Version: 1.0 References: <451cf788-79c4-a971-fe8f-cb56c04542ef@suse.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 16 Aug 2022 08:53:40 -0700 Message-ID: Subject: Re: [PATCH 08/12] x86: template-ize vector packed dword/qword integer insns To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 15:54:18 -0000 On Tue, Aug 16, 2022 at 12:37 AM Jan Beulich wrote: > > On 11.08.2022 19:23, H.J. Lu wrote: > > On Fri, Aug 5, 2022 at 5:26 AM Jan Beulich wrote: > >> > >> Many of the vector integer insns come in dword/qword element pairs. Most > >> of these pairs follow certain encoding patterns. Introduce a "dq" > >> template to reduce redundancy. > >> > >> Note that in the course of the conversion > >> - a few otherwise untouched templates are moved, so they end up next to > >> their siblings), > >> - drop an unhelpful Cpu64 from the GPR form of VPBROADCASTQ, matching > >> what we already have for KMOVQ - the diagnostic is better this way for > >> insns with multiple forms (i.e. the same Cpu64 attributes on {,V}MOVQ, > >> {,V}PEXTRQ, and {,V}PINSRQ are useful to keep), > >> - this adds benign/meaningless IgnoreSize attributes to the GPR forms of > >> KMOVD and VPBROADCASTD; it didn't seem worth avoiding this. > >> --- > >> For VPCOMPRESS{D,Q} and VPEXPAND{D,Q} the conversion could only be done > >> if we allowed Dword/Qword on the memory operands. Imo permitting this > >> makes sense anyway (as the memory operands aren't full [XYZ]mmword > >> ones), but such a functional change should probably be a separate patch. > > Do you have any view on this and the similar remarks in two other of the > patches in this series? > Since these instructions don't take Dword/Qword memory operands, please leave them alone. -- H.J.