From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 9CD9D3858D1E for ; Mon, 15 Aug 2022 18:10:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CD9D3858D1E Received: by mail-qk1-x734.google.com with SMTP id i24so6086431qkg.13 for ; Mon, 15 Aug 2022 11:10:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=XUUQoQOfU1aWTBX5uYLaHP3pgw/LpGwugOwIaZ5RUVw=; b=SMBJACdXnKg6Pii4gA669U2SeTPfakFVFogLzOYOvzq36df46TqIMx35+WJvMPXSKM LcB0vGwKFQsiX95hV5hjbgLyDBVHQjX0iF+EK4tgeCK5LxJB3HmrjOhGuW77yA/e07ZI 9dfEiNySIL6iyn9ISNTXniP9ttzivlHPQ8JBh/af2ZkJM2cLoucJQe4Yj0778V01JQWU FouvfuzwSSCMIpEiSW80f4VNQLhcIPSI6m1t0miJyJLUo3IAx6ua4L3wToU5frx1xGR6 VCWAGTigE62LleFan7853ny8dAlvudcb1dkQYq65eaxBe0JdDYBeBPfq1/XJiBK6hv0H q8BQ== X-Gm-Message-State: ACgBeo36I8LShrdJYIZGzvsr/8BxiCLay8c6OaS8qzyEOXoCHbo6DBcm YZl5b52cB8Yz7TzNGS5nhGptUhGof9NecDq/ilC2z+p5 X-Google-Smtp-Source: AA6agR6sDjTGC8kt4Ndc8H1n5Dnjk3y+AiYyRGhJ6U7V4wlMnSD4nx1RoO4IAbBvve43TdPoHu5KJlmOxlaOc6MYqiY= X-Received: by 2002:a05:620a:2699:b0:6b8:c299:23c2 with SMTP id c25-20020a05620a269900b006b8c29923c2mr11920946qkp.768.1660587059068; Mon, 15 Aug 2022 11:10:59 -0700 (PDT) MIME-Version: 1.0 References: <12efdcf2-82f2-7683-7f55-3fac382326f9@suse.com> <0f4b7709-8781-2cbc-19f8-e8fdc5f6579c@suse.com> In-Reply-To: <0f4b7709-8781-2cbc-19f8-e8fdc5f6579c@suse.com> From: "H.J. Lu" Date: Mon, 15 Aug 2022 11:10:23 -0700 Message-ID: Subject: Re: x86: limiting the use of No_*Suf To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 18:11:01 -0000 On Fri, Aug 12, 2022 at 6:19 AM Jan Beulich wrote: > > On 12.08.2022 11:30, Jan Beulich via Binutils wrote: > > since you didn't like "x86: imply all No_*Suf when none is set in a > > template" I've been thinking of other ways to limit the excessive use > > of these attributes. One observation is that templates with IsPrefix, > > Broadcast, or Masking set always have all No_Suf also set. > > Therefore the latter could be dropped from those templates (improving > > readability), compensated by > > 1) a respective adjustment to match_template(), or > > 2) a change to i386-gen.c, or > > 3) respective pre-processor macros. > > Do you have any opinion on the general direction of this and, if in > > favor, any preference for one of the three options? > > Actually I had forgotten that we already have precedent of 3), for > AddrPrefixOpReg. So perhaps this can be a hint as to further moves > in that direction ... > > Jan I prefer #3. Thanks. -- H.J.