From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id D1DF53858D3C for ; Mon, 17 Jan 2022 13:45:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1DF53858D3C Received: by mail-pf1-x431.google.com with SMTP id a5so10245050pfo.5 for ; Mon, 17 Jan 2022 05:45:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s7VVYx6tzrKftYUeaDnMGpcT6qS11Ry0aA77FSR1Qsw=; b=z4bM7vRHmpKNcgx80ZdaSuFwjf+Xjcx/PlG/if5sNNanI0GCwHXKRN75nxsF5vMrDD 6p9LeY+yg1KP+YrOtUAT+YLWC3VaBUdhTD51yyxvVEcymEliNss9hKQdgFiGFYjn8bxA ARTKuMOgB7RZrGFw8yZlIPa1ovXFdchIulbLNQgT1vddIrMySKIO+hqkyWP76yWiYH7O g0wCGAu4WzjNB4xSfkyY8g94L7x+fA7Dcmn0N8j+MzookFG2bsLYuEQ5CtzTE6AyXt1V hXxZg2jQw2zAdV5J1zHXAcaLO41V8nakNuUxcH/oW2MrmP2rFegm6BVh5Ug/q4Xs6/Eb u5dg== X-Gm-Message-State: AOAM531RmNDYxgZWiTjydfW4MCiGYcaT0Uy9FcGz9sFviWQSpvHvizRM UnKclF2Y39kzaKyCnZ14Kd5mi1TC+WEFYwEBEY0= X-Google-Smtp-Source: ABdhPJy0TfkDJKB61VrwU0M5HThVlUdw9wvCLOJkrBEeLmCa9T3N7Ypvo1JbV9nTdiDwMdh53lphXfYU+awZLkdseiI= X-Received: by 2002:a63:b24e:: with SMTP id t14mr19219851pgo.381.1642427103880; Mon, 17 Jan 2022 05:45:03 -0800 (PST) MIME-Version: 1.0 References: <20211229193949.146079-1-hjl.tools@gmail.com> <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> <1d8309a8-434c-f4e5-1c48-b16229b16489@suse.com> In-Reply-To: <1d8309a8-434c-f4e5-1c48-b16229b16489@suse.com> From: "H.J. Lu" Date: Mon, 17 Jan 2022 05:44:27 -0800 Message-ID: Subject: [PATCH] ld: Require GCC 8.0 for p_align-1.c tests To: Jan Beulich Cc: Binutils Content-Type: multipart/mixed; boundary="00000000000018c00305d5c75cc7" X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 13:45:06 -0000 --00000000000018c00305d5c75cc7 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 17, 2022 at 2:38 AM Jan Beulich wrote: > > On 14.01.2022 15:14, H.J. Lu wrote: > > On Fri, Jan 14, 2022 at 6:08 AM Jan Beulich wrote: > >> > >> On 14.01.2022 15:02, H.J. Lu wrote: > >>> On Fri, Jan 14, 2022 at 5:40 AM Jan Beulich wrote: > >>>> > >>>> On 14.01.2022 14:03, H.J. Lu wrote: > >>>>> On Fri, Jan 14, 2022 at 12:27 AM Jan Beulich wrote: > >>>>>> > >>>>>> On 29.12.2021 20:39, H.J. Lu via Binutils wrote: > >>>>>>> --- a/ld/testsuite/ld-elf/linux-x86.exp > >>>>>>> +++ b/ld/testsuite/ld-elf/linux-x86.exp > >>>>>>> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \ > >>>>>>> "" \ > >>>>>>> "tmpdir/indirect-extern-access-2.so" \ > >>>>>>> ] \ > >>>>>>> + [list \ > >>>>>>> + "Run p_align-1a without PIE" \ > >>>>>>> + "$NOPIE_LDFLAGS" \ > >>>>>>> + "" \ > >>>>>>> + { p_align-1.c } \ > >>>>>>> + "p_align-1a" \ > >>>>>>> + "pass.out" \ > >>>>>>> + "$NOPIE_CFLAGS" \ > >>>>>>> + ] \ > >>>>>>> + [list \ > >>>>>>> + "Run p_align-1b with PIE" \ > >>>>>>> + "-pie" \ > >>>>>>> + "" \ > >>>>>>> + { p_align-1.c } \ > >>>>>>> + "p_align-1b" \ > >>>>>>> + "pass.out" \ > >>>>>>> + "-fpie" \ > >>>>>>> + ] \ > >>>>>>> + [list \ > >>>>>>> + "Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \ > >>>>>>> + "$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \ > >>>>>>> + "" \ > >>>>>>> + { p_align-1.c } \ > >>>>>>> + "p_align-1c" \ > >>>>>>> + "pass.out" \ > >>>>>>> + "$NOPIE_CFLAGS" \ > >>>>>>> + ] \ > >>>>>>> + [list \ > >>>>>>> + "Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \ > >>>>>>> + "-pie -Wl,-z,max-page-size=0x1000" \ > >>>>>>> + "" \ > >>>>>>> + { p_align-1.c } \ > >>>>>>> + "p_align-1d" \ > >>>>>>> + "pass.out" \ > >>>>>>> + "-fpie" \ > >>>>>>> + ] \ > >>>>>>> ] > >>>>>> > >>>>>> The two PIE variants of this also fail for me on glibc 2.26. Looks > >>>>>> like LOAD segments' alignment isn't being honored there, at least > >>>>>> not if it's as big as it is here. > >>>>>> > >>>>> > >>>>> The PIE alignment needs the kernel fix: > >>>>> > >>>>> commit ce81bb256a224259ab686742a6284930cbe4f1fa > >>>>> Author: Chris Kennelly > >>>>> Date: Thu Oct 15 20:12:32 2020 -0700 > >>>>> > >>>>> fs/binfmt_elf: use PT_LOAD p_align values for suitable start address > >>>> > >>>> Well, then the test needs to be skipped if that fix is not in place. > >>>> After all you're testing binutils behavior here, not kernel or libc one. > >>>> I'm running a variety of (largely up-to-date) kernels on all of my > >>>> systems. But it looks like our kernel folks decided against backporting > >>>> this particular change. And I don't think you expect people to remember > >>>> to run the testsuite only on top of "certain" kernels? > >>> > >>> Care to submit a patch? > >> > >> I have no idea what to check for. I would really expect you to fix such > >> an issue (or really two of them, considering the other problem) recently > >> introduced by you. > > > > What compiler are you using on the broken kernel? > > gcc 7.4.1 > > No idea how that matters, though. Try this. -- H.J. --00000000000018c00305d5c75cc7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ld-Require-GCC-8.0-for-p_align-1.c-tests.patch" Content-Disposition: attachment; filename="0001-ld-Require-GCC-8.0-for-p_align-1.c-tests.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kyiqnfsv0 RnJvbSAwMTIwYmFlNTJjY2RiMDUwMjAzYmQ5MGIzMTBjZGNhOTk5NWU2ZTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMTcgSmFuIDIwMjIgMDU6MzM6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBsZDogUmVx dWlyZSBHQ0MgOC4wIGZvciBwX2FsaWduLTEuYyB0ZXN0cwoKUmVxdWlyZSBHQ0MgOC4wIGZvciBw X2FsaWduLTEuYyB0ZXN0cyB0byBhdm9pZCBHQ0MgYW5kIExpbnV4IGtlcm5lbAp3aGljaCBpZ25v cmUgYWxpZ25lZCBpbiBwX2FsaWduLTEuYy4KCglQUiBsZC8yODY4OQoJUFIgbGQvMjg2OTUKCSog bGQtZWxmL2xpbnV4LXg4Ni5leHA6IFJlcXVpcmUgR0NDIDguMCBmb3IgcF9hbGlnbi0xLmMgdGVz dHMuCi0tLQogbGQvdGVzdHN1aXRlL2xkLWVsZi9saW51eC14ODYuZXhwIHwgNzkgKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyks IDM2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xkL3Rlc3RzdWl0ZS9sZC1lbGYvbGludXgt eDg2LmV4cCBiL2xkL3Rlc3RzdWl0ZS9sZC1lbGYvbGludXgteDg2LmV4cAppbmRleCAyZTBjYmQz N2YxNy4uNmJjMjgwZjNjZGQgMTAwNjQ0Ci0tLSBhL2xkL3Rlc3RzdWl0ZS9sZC1lbGYvbGludXgt eDg2LmV4cAorKysgYi9sZC90ZXN0c3VpdGUvbGQtZWxmL2xpbnV4LXg4Ni5leHAKQEAgLTE4NSw0 NCArMTg1LDUxIEBAIHJ1bl9sZF9saW5rX2V4ZWNfdGVzdHMgW2xpc3QgXAogCSIiIFwKIAkidG1w ZGlyL2luZGlyZWN0LWV4dGVybi1hY2Nlc3MtMi5zbyIgXAogICAgIF0gXAotICAgIFtsaXN0IFwK LQkiUnVuIHBfYWxpZ24tMWEgd2l0aG91dCBQSUUiIFwKLQkiJE5PUElFX0xERkxBR1MiIFwKLQki IiBcCi0JeyBwX2FsaWduLTEuYyB9IFwKLQkicF9hbGlnbi0xYSIgXAotCSJwYXNzLm91dCIgXAot CSIkTk9QSUVfQ0ZMQUdTIiBcCi0gICAgXSBcCi0gICAgW2xpc3QgXAotCSJSdW4gcF9hbGlnbi0x YiB3aXRoIFBJRSIgXAotCSItcGllIiBcCi0JIiIgXAotCXsgcF9hbGlnbi0xLmMgfSBcCi0JInBf YWxpZ24tMWIiIFwKLQkicGFzcy5vdXQiIFwKLQkiLWZwaWUiIFwKLSAgICBdIFwKLSAgICBbbGlz dCBcCi0JIlJ1biBwX2FsaWduLTFjIHdpdGggLVdsLC16LG1heC1wYWdlLXNpemU9MHgxMDAwIHdp dGhvdXQgUElFIiBcCi0JIiROT1BJRV9MREZMQUdTIC1XbCwteixtYXgtcGFnZS1zaXplPTB4MTAw MCIgXAotCSIiIFwKLQl7IHBfYWxpZ24tMS5jIH0gXAotCSJwX2FsaWduLTFjIiBcCi0JInBhc3Mu b3V0IiBcCi0JIiROT1BJRV9DRkxBR1MiIFwKLSAgICBdIFwKLSAgICBbbGlzdCBcCi0JIlJ1biBw X2FsaWduLTFkIHdpdGggLVdsLC16LG1heC1wYWdlLXNpemU9MHgxMDAwIHdpdGggUElFIiBcCi0J Ii1waWUgLVdsLC16LG1heC1wYWdlLXNpemU9MHgxMDAwIiBcCi0JIiIgXAotCXsgcF9hbGlnbi0x LmMgfSBcCi0JInBfYWxpZ24tMWQiIFwKLQkicGFzcy5vdXQiIFwKLQkiLWZwaWUiIFwKLSAgICBd IFwKIF0KIAorIyBSZXF1aXJlIEdDQyA4LjAgdG8gYXZvaWQgR0NDIGFuZCBMaW51eCBrZXJuZWwg d2hpY2ggaWdub3JlIGFsaWduZWQKKyMgYXR0cmlidXRlIGluIHBfYWxpZ24tMS5jLgoraWYgeyBb YXRfbGVhc3RfZ2NjX3ZlcnNpb24gOCAwXSB9IHsKKyAgICBydW5fbGRfbGlua19leGVjX3Rlc3Rz IFtsaXN0IFwKKwlbbGlzdCBcCisJICAgICJSdW4gcF9hbGlnbi0xYSB3aXRob3V0IFBJRSIgXAor CSAgICAiJE5PUElFX0xERkxBR1MiIFwKKwkgICAgIiIgXAorCSAgICB7IHBfYWxpZ24tMS5jIH0g XAorCSAgICAicF9hbGlnbi0xYSIgXAorCSAgICAicGFzcy5vdXQiIFwKKwkgICAgIiROT1BJRV9D RkxBR1MiIFwKKwldIFwKKwlbbGlzdCBcCisJICAgICJSdW4gcF9hbGlnbi0xYiB3aXRoIFBJRSIg XAorCSAgICAiLXBpZSIgXAorCSAgICAiIiBcCisJICAgIHsgcF9hbGlnbi0xLmMgfSBcCisJICAg ICJwX2FsaWduLTFiIiBcCisJICAgICJwYXNzLm91dCIgXAorCSAgICAiLWZwaWUiIFwKKwldIFwK KwlbbGlzdCBcCisJICAgICJSdW4gcF9hbGlnbi0xYyB3aXRoIC1XbCwteixtYXgtcGFnZS1zaXpl PTB4MTAwMCB3aXRob3V0IFBJRSIgXAorCSAgICAiJE5PUElFX0xERkxBR1MgLVdsLC16LG1heC1w YWdlLXNpemU9MHgxMDAwIiBcCisJICAgICIiIFwKKwkgICAgeyBwX2FsaWduLTEuYyB9IFwKKwkg ICAgInBfYWxpZ24tMWMiIFwKKwkgICAgInBhc3Mub3V0IiBcCisJICAgICIkTk9QSUVfQ0ZMQUdT IiBcCisJXSBcCisJW2xpc3QgXAorCSAgICAiUnVuIHBfYWxpZ24tMWQgd2l0aCAtV2wsLXosbWF4 LXBhZ2Utc2l6ZT0weDEwMDAgd2l0aCBQSUUiIFwKKwkgICAgIi1waWUgLVdsLC16LG1heC1wYWdl LXNpemU9MHgxMDAwIiBcCisJICAgICIiIFwKKwkgICAgeyBwX2FsaWduLTEuYyB9IFwKKwkgICAg InBfYWxpZ24tMWQiIFwKKwkgICAgInBhc3Mub3V0IiBcCisJICAgICItZnBpZSIgXAorCV0gXAor ICAgIF0KK30KKwogcHJvYyBlbGZlZGl0X3Rlc3QgeyBvcHRpb25zIHRlc3Qgb3V0cHV0IH0gewog ICAgIGdsb2JhbCBFTEZFRElUCiAgICAgZ2xvYmFsIFJFQURFTEYKLS0gCjIuMzQuMQoK --00000000000018c00305d5c75cc7--