From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 64E163858C53 for ; Fri, 21 Jul 2023 01:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64E163858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5703cb4bcb4so15905427b3.3 for ; Thu, 20 Jul 2023 18:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689902460; x=1690507260; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tsbfpUYqdcuzQTxbPZTbVXob/rCQP25nVme4TWQaLF0=; b=dMWKvLV29J3mB/IKK9weSluBxcDe2ynzHQJMaQyqjqzFLv2pDvd9hJsxptUYuG55FP nBUq8tqDoF/oYsoGV01dA9VYEKJuyiOYzvicHhSR/jU7XjGiiuLCA5gn24ZorTcABr9D QhmvNoZmghs5Wmyy84aHQZy6QG0EHwcGPUMRuZAsWCHcdOfl1Dd/fizMkcwwzhHz9yhw rWXVJcTRCfz0iGZLOSAL+LTxWep2FTeXqmdcn7kuSzHEp4knfhxjd1drlRbLLFZupiMQ qwSZcy8uLkSL158fG5o3UZv+qXgttKfefdN/KDN9+wh87FP+Sbn/M55kZTSQNQqUgZkj foQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689902460; x=1690507260; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tsbfpUYqdcuzQTxbPZTbVXob/rCQP25nVme4TWQaLF0=; b=kwa1e2P3ym3Jk+wC1JS5T0ildfVYE7ImZ6Oli7wcHuLGyJwj7AlA5rDNCKauZb5gQb PuW1W2LRF80eehBqmIhXTeqi0nRCST7FzJVYp4THNZriAd+YRGiUOOdILxByFZe9dM4e 9pnES6kt7Oe9OrA6VzujbcEs8mvcIH1Z3EQiYsSseqRpTfZiHoBAjRw2T4TxJ6ImuCGp B3lpXyrw320O14ieZW2gerMQbnmJkqKgy+7oLLiD8CQhD+S7dsfrBQIdtVu+fYXtpV/V 29tT0kgdo+s2/Nl79flWiS6CAgBradZPZ5gzdywohvja1BkvELjkNEs8txYO82D1cKqj bc/w== X-Gm-Message-State: ABy/qLZp6BwlfSvNTxDbswTD5PTdAUEQ3TVOTAPKefey8b8xM1KH/sT5 QCjmb2EAuxmtdIl7Mz0eANhknlfYr2yO2eQVeJc= X-Google-Smtp-Source: APBJJlGM36IcNQ8oVFbMsUQ79jzcay9d0wwcCylogx5Y3VcdqiYdTUypAzE2MD8ccQRwisV+i3IoDYQRyIYhoEPGk8E= X-Received: by 2002:a0d:f305:0:b0:583:8c60:a766 with SMTP id c5-20020a0df305000000b005838c60a766mr753407ywf.7.1689902460424; Thu, 20 Jul 2023 18:21:00 -0700 (PDT) MIME-Version: 1.0 References: <3f44f9a7-2f4c-d92d-ec19-5023f317357a@suse.com> <7cc1eda0-713d-9172-c3ed-078e0899b0c4@suse.com> <6e5ddbfd-4060-edff-39ba-f3446b210eb5@suse.com> In-Reply-To: <6e5ddbfd-4060-edff-39ba-f3446b210eb5@suse.com> From: "H.J. Lu" Date: Thu, 20 Jul 2023 18:20:24 -0700 Message-ID: Subject: Re: [PATCH 2/2] x86: adjust disassembly of insns operating on selector values To: Jan Beulich Cc: "Jiang, Haochen" , Binutils Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3015.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 17, 2023 at 12:08=E2=80=AFAM Jan Beulich wr= ote: > > On 17.07.2023 04:04, Jiang, Haochen wrote: > >> --- a/gas/testsuite/gas/i386/opcode-suffix.d > >> +++ b/gas/testsuite/gas/i386/opcode-suffix.d > >> @@ -102,7 +102,7 @@ Disassembly of section .text: > >> *[0-9a-f]+: 60[ ]+pushal > >> *[0-9a-f]+: 61[ ]+popal > >> *[0-9a-f]+: 62 90 90 90 90 90[ ]+boundl %edx,-0x6f6f6f70= \(%eax\) > >> - *[0-9a-f]+: 63 90 90 90 90 90[ ]+arpl[ ]+%dx,-0x= 6f6f6f70\(%eax\) > >> + *[0-9a-f]+: 63 90 90 90 90 90[ ]+arpll[ ]+%edx,- > >> 0x6f6f6f70\(%eax\) > >> *[0-9a-f]+: 68 90 90 90 90[ ]+pushl[ ]+\$0x909= 09090 > >> *[0-9a-f]+: 69 90 90 90 90 90 90 90 90 90[ ]+imull[ > >> ]+\$0x90909090,-0x6f6f6f70\(%eax\),%edx > >> *[0-9a-f]+: 6a 90[ ]+pushl[ ]+\$0xffffff90 > >> @@ -248,7 +248,7 @@ Disassembly of section .text: > >> *[0-9a-f]+: fc[ ]+cld > >> *[0-9a-f]+: fd[ ]+std > >> *[0-9a-f]+: ff 90 90 90 90 90[ ]+calll[ ]+\*-0x6f= 6f6f70\(%eax\) > >> - *[0-9a-f]+: 0f 00 90 90 90 90 90[ ]+lldt[ ]+-0x6f6f= 6f70\(%eax\) > >> + *[0-9a-f]+: 0f 00 90 90 90 90 90[ ]+lldtw[ ]+-0x6f6f= 6f70\(%eax\) > > > > H.J. is on vacation till Wednesday but I suppose H.J. has this question= in my patch > > before and he might raise again if he is here. > > > > Is this suffix needed since m16 is the only allowed memory here? > > All suffixes should be appended in suffix-always mode. The question > of whether one can be omitted arises only in the default mode, where > optional suffixes are left off (for clarity / ease of reading). Plus > please recall that the changes here are for consistency, and e.g. in > > *[0-9a-f]+: 8c 90 90 90 90 90[ ]+movw[ ]+%ss,-0x6f6f6f70= \(%eax\) > > the suffix is also present, no matter that only m16 is possible. > > In any event I'm not intending to commit this before the end of the > week, so H.J. will have a chance to voice his opinion. > > Jan Personally, I don't think this change is necessary. But I am not against it. --=20 H.J.