From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20087 invoked by alias); 2 Sep 2012 14:50:49 -0000 Received: (qmail 20067 invoked by uid 22791); 2 Sep 2012 14:50:47 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 Sep 2012 14:50:33 +0000 Received: by vcbfl13 with SMTP id fl13so5372258vcb.0 for ; Sun, 02 Sep 2012 07:50:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.68.110 with SMTP id v14mr7971585vdt.14.1346597432415; Sun, 02 Sep 2012 07:50:32 -0700 (PDT) Received: by 10.58.234.39 with HTTP; Sun, 2 Sep 2012 07:50:32 -0700 (PDT) In-Reply-To: <50427D29.1010205@twiddle.net> References: <503E009B.3080302@linux.vnet.ibm.com> <503E3930.5040603@linux.vnet.ibm.com> <20120829.125208.824114683359549094.davem@davemloft.net> <503F14A3.8070801@linux.vnet.ibm.com> <5040CCC6.4030809@twiddle.net> <50423CF8.7000309@twiddle.net> <50427D29.1010205@twiddle.net> Date: Sun, 02 Sep 2012 14:50:00 -0000 Message-ID: Subject: Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines From: "H.J. Lu" To: Richard Henderson Cc: Andreas Krebbel , David Miller , aj@suse.com, libc-alpha@sourceware.org, Binutils Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00013.txt.bz2 On Sat, Sep 1, 2012 at 2:24 PM, Richard Henderson wrote: > On 2012-09-01 10:21, H.J. Lu wrote: >> It may work for other targets. But x86 doesn't have a relax >> pass. I believe doing it in size_dynamic_sections is more >> sensible. > > It *should* have a relax pass. Especially as that allows one A relax pass won't work properly for x86 without some surgery since lang_relax_sections is called after bfd_elf_size_dynamic_sections which calls elf_x86_64_allocate_dynrelocs to allocate GOT entries and dynamic relocations. After it is done, it is not to easy to undo the damage. > to turn it all off just in case a bug is encountered. > This is a separate issue. X86 backends also optimize TLS relocations. Some compilers generate bad TLS sequences which lead to corrupted output: http://sourceware.org/bugzilla/show_bug.cgi?id=4928 But there is no way to turn off the TLS optimization. It will be nice to move disable_target_specific_optimizations from command_line to link_info so that a backend can check it. -- H.J.