* [2.34][PATCH] Fix dwarf.c build with GCC 10
@ 2020-03-24 12:14 H.J. Lu
2020-03-24 15:18 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2020-03-24 12:14 UTC (permalink / raw)
To: Nick Clifton, Binutils
[-- Attachment #1: Type: text/plain, Size: 127 bytes --]
Hi Nick,
I am seeing the same error on Linux/x86-64 with GCC 10. I'd like to
backport this patch to binutils 2.34.
--
H.J.
[-- Attachment #2: 0001-Fix-dwarf.c-build-with-GCC-10.patch --]
[-- Type: text/x-patch, Size: 1149 bytes --]
From 0cc14d3b95555549dec4416cd7c21375815ea422 Mon Sep 17 00:00:00 2001
From: Nick Clifton <nickc@redhat.com>
Date: Fri, 7 Feb 2020 12:49:42 +0000
Subject: [PATCH] Fix dwarf.c build with GCC 10
Silcence a compile time warning message building the binutils with
gcc-10.
* dwarf.c (display_debug_lines_decoded): Force a NUL termination
of the truncated file name.
(cherry picked from commit e1104d08fe2fbfabcfa98aa00525211e47548bd8)
---
binutils/dwarf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 35842f74b2..6ecfab5d5a 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -4905,6 +4905,11 @@ display_debug_lines_decoded (struct dwarf_section * section,
strncpy (newFileName,
fileName + fileNameLength - MAX_FILENAME_LENGTH,
MAX_FILENAME_LENGTH + 1);
+ /* FIXME: This is to pacify gcc-10 which can warn that the
+ strncpy above might leave a non-NUL terminated string
+ in newFileName. It won't, but gcc's analysis doesn't
+ quite go far enough to discover this. */
+ newFileName[MAX_FILENAME_LENGTH] = 0;
}
else
{
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-24 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 12:14 [2.34][PATCH] Fix dwarf.c build with GCC 10 H.J. Lu
2020-03-24 15:18 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).