[PATCH] Use per instruction prefix control.

[PATCH] Use per instruction prefix control.

[Ilya Tocar]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi,

To deal with problems like
https://sourceware.org/bugzilla/show_bug.cgi?id=17898
We need more fine-grained prefix control than
twobyte_has_mandatory_prefix[256]
Attached patch adds mandatory_prefix field to struct dis386,
which will be used to control allowed/mandatory/forbidden prefixes on
per instruction basis.

Ok for trunk?

[-- Attachment #2: patch.tar.gz --]
[-- Type: application/gzip, Size: 28121 bytes --]

Re: [PATCH] Use per instruction prefix control.

[H.J. Lu]

On Mon, Apr 6, 2015 at 8:46 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> Hi,
>
> To deal with problems like
> https://sourceware.org/bugzilla/show_bug.cgi?id=17898
> We need more fine-grained prefix control than
> twobyte_has_mandatory_prefix[256]
> Attached patch adds mandatory_prefix field to struct dis386,
> which will be used to control allowed/mandatory/forbidden prefixes on
> per instruction basis.
>

A prefix can be optional for an opcode which may be UD
with the other prefixes.  Please remove

#define PREFIX_OPTIONAL 0

and replace

{ "vfpclassss",    { XMask, EXxmm_md, Ib }, PREFIX_OPTIONAL },

with

{ "vfpclassss",    { XMask, EXxmm_md, Ib }, 0 },

OK with this change.

Thanks.

-- 
H.J.

Re: [PATCH] Use per instruction prefix control.

[Ilya Tocar]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On 06 Apr 08:57, H.J. Lu wrote:
> On Mon, Apr 6, 2015 at 8:46 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> > Hi,
> >
> > To deal with problems like
> > https://sourceware.org/bugzilla/show_bug.cgi?id=17898
> > We need more fine-grained prefix control than
> > twobyte_has_mandatory_prefix[256]
> > Attached patch adds mandatory_prefix field to struct dis386,
> > which will be used to control allowed/mandatory/forbidden prefixes on
> > per instruction basis.
> >
> 
> A prefix can be optional for an opcode which may be UD
> with the other prefixes.  Please remove
> 
> #define PREFIX_OPTIONAL 0
> 
> and replace
> 
> { "vfpclassss",    { XMask, EXxmm_md, Ib }, PREFIX_OPTIONAL },
> 
> with
> 
> { "vfpclassss",    { XMask, EXxmm_md, Ib }, 0 },
> 
> OK with this change.
> 
> Thanks.
>
Thanks.

I've committed attached version

[-- Attachment #2: patch.tar.gz --]
[-- Type: application/gzip, Size: 27760 bytes --]

Re: [PATCH] Use per instruction prefix control.

[H.J. Lu]

On Mon, Apr 6, 2015 at 9:35 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> On 06 Apr 08:57, H.J. Lu wrote:
>> On Mon, Apr 6, 2015 at 8:46 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > Hi,
>> >
>> > To deal with problems like
>> > https://sourceware.org/bugzilla/show_bug.cgi?id=17898
>> > We need more fine-grained prefix control than
>> > twobyte_has_mandatory_prefix[256]
>> > Attached patch adds mandatory_prefix field to struct dis386,
>> > which will be used to control allowed/mandatory/forbidden prefixes on
>> > per instruction basis.
>> >
>>
>> A prefix can be optional for an opcode which may be UD
>> with the other prefixes.  Please remove
>>
>> #define PREFIX_OPTIONAL 0
>>
>> and replace
>>
>> { "vfpclassss",    { XMask, EXxmm_md, Ib }, PREFIX_OPTIONAL },
>>
>> with
>>
>> { "vfpclassss",    { XMask, EXxmm_md, Ib }, 0 },
>>
>> OK with this change.
>>
>> Thanks.
>>
> Thanks.
>
> I've committed attached version

Thanks.

-- 
H.J.