From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 79C0E3858D35 for ; Tue, 22 Nov 2022 16:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79C0E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-13bd19c3b68so17834843fac.7 for ; Tue, 22 Nov 2022 08:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9jEiaKpHlBCRUApwjICNzbvxTqQv/5S57FvLSu87+so=; b=m4oerYJtjdDbsovg3qhbc5Y/gEaE5SOj0T1GDz9V+1k3AvtDO123bNofGRoQiFb8o/ LidcBvKLl9ulnlnB0/xpOv/wYQFHdAinTjavElUPuedoHR5yh35dxqyFi57jlnpKtpMY 679k343K0sFz483wADusPMvjoD1Wz3IozFds/S77u9KfYEP3dNCYWzXBZ5Hhoz3+gNog zpL+1wdEJcd1Jkp8L8fX+eT+ocw4RnT4VjhMNDUSFXqok2hq/kDapGMtWlZ4QyUVah3N /wH6+3epryAqbC4A5JiHJcOPlUApEekgnaBukBSgD+vDBjbtuj03Rfo2LlAe4NtBd2Af i84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9jEiaKpHlBCRUApwjICNzbvxTqQv/5S57FvLSu87+so=; b=T+6bqJkUhdtlemAYcRvG4xkuVMwaz3H6nETKo7+1N8p5j6+/BZN/eP4yPf2wspRHii x+hmXzITHzt3fTkPFO2EK/I62YAtmI1dIfxpWbwip/epqTH20P1hdQScu+Hw7LtYI1qq diDOdzlVlgWMgXcs3ep+VTm8LXYSqPFg17QlXwLetufebYE73DcfKBYKxvYozlxQGKja BGx3QjvOxzCdOxWDs+YmTjVfhTkwhYFBj0A/c0kibeqHhMj/M8ki6VRtb4smJ/GF2Si4 nbCqDRVnwafsFx0rCPgLNqYNodpHeBZIPyJPP8vyMMcaAaqVS5XqPnxg6tzAKpOJuWqD P7Jw== X-Gm-Message-State: ANoB5pmWCwLxBuq42K7w8YXLjnRqnrdeYFzlrQqghgDxR1asZ+ZtE7Ts QSYORQR9iX29LkOBByEd+dsa93nK3wjysGglSIU= X-Google-Smtp-Source: AA0mqf4XeoOIqKuruN520t0OJ3bbRLESqjCKVOmnJamAgPWo0/QhI1jOEDl3vRQWEh1OMh9ftV7JJsTzgl9TmZqp6Zc= X-Received: by 2002:a05:6871:4501:b0:13c:5da4:7229 with SMTP id nj1-20020a056871450100b0013c5da47229mr7415839oab.266.1669135168735; Tue, 22 Nov 2022 08:39:28 -0800 (PST) MIME-Version: 1.0 References: <7a1ee76a-5b54-32a6-6301-a1741b5c1883@suse.com> <9d95d33c-7f9a-a64b-7ac0-9ee96f0b99f5@suse.com> <574d21f1-0b60-8683-1a4c-32a368153324@suse.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 22 Nov 2022 08:38:52 -0800 Message-ID: Subject: Re: [PATCH v2 3/4] x86: break gas dependency on libopcodes To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 21, 2022 at 11:15 PM Jan Beulich wrote: > > On 21.11.2022 18:04, H.J. Lu wrote: > > On Mon, Nov 21, 2022 at 8:52 AM Jan Beulich wrote: > >> > >> On 21.11.2022 17:43, H.J. Lu wrote: > >>> On Mon, Nov 21, 2022 at 8:32 AM Jan Beulich wrote: > >>>> > >>>> On 21.11.2022 17:26, H.J. Lu wrote: > >>>>> On Fri, Nov 18, 2022 at 1:13 AM Jan Beulich wrote: > >>>>>> > >>>>>> gas doesn't use anything from libopcodes anymore - suppress linking in > >>>>>> that library. > >>>>>> --- > >>>>>> v2: New, split off from larger earlier patch. > >>>>>> > >>>>>> --- a/gas/configure > >>>>>> +++ b/gas/configure > >>>>>> @@ -12263,7 +12263,7 @@ _ACEOF > >>>>>> > >>>>>> # Do we need the opcodes library? > >>>>>> case ${cpu_type} in > >>>>>> - vax | tic30) > >>>>>> + vax | tic30 | i386) > >>>>>> ;; > >>>>>> > >>>>>> *) > >>>>>> --- a/gas/configure.ac > >>>>>> +++ b/gas/configure.ac > >>>>>> @@ -420,7 +420,7 @@ changequote([,])dnl > >>>>>> > >>>>>> # Do we need the opcodes library? > >>>>>> case ${cpu_type} in > >>>>>> - vax | tic30) > >>>>>> + vax | tic30 | i386) > >>>>>> ;; > >>>>>> > >>>>>> *) > >>>>>> > >>>>> > >>>>> We need to add some dependencies on i386-opc.tbl and i386-reg.tbl for > >>>>> --enable-maintainer-mode to check if i386-tbl.h and i386-init.h are up to > >>>>> date. It doesn't need to regenerate i386-tbl.h. An error message should be > >>>>> sufficient. > >>>> > >>>> This isn't needed here, but in patch 2, where I'm already adjusting > >>>> existing dependencies. Since I'm not modifying any toplevel files, the > >>>> building of opcodes/ still ought to be happening before the building of > >>>> gas/, so I don't see why any further changes should be necessary. Please > >>>> clarify if you see any such reason. > >>>> > >>> > >>> Since gas no longer depends on libopcodes, one may change i386-opc.tbl and > >>> run "make" in gas. > >> > >> Is running make in gas/ a supported operation? > >> > >>> It is more reliable than the fake dependency in opcodes. > >> > >> If the answer to the above is yes, then I may agree here. Except that then > >> I don't see how this dependency is being enforced prior to this series. > >> IOW - aren't you asking to address an unrelated issue? > >> > > > > It didn't work before. Now we have a chance. > > But then please in a separate change, on top of this series. I'm willing > to make such a patch (whether that then finds your approval is a separate > question), but I'd please like to see things unblocked here. > Then please don't add the fake dependency. -- H.J.