From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id E9456385843E for ; Tue, 16 Aug 2022 16:32:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9456385843E Received: by mail-qt1-x82e.google.com with SMTP id x5so8510652qtv.9 for ; Tue, 16 Aug 2022 09:32:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=EGzIbbRdOSlmskQUxlQ1MqcyhPzrEVzk/zGdPkdfFzo=; b=RzSP4kH2I/pTxRz6SKmpk4h0OAmU/4DrkjN2VplLUKHv+GvaD4pOl8PDIXwSEjDito V4KQQ48kToiA7Z41c6wa1BWKs5nsyRc1PIcGL48ltZq2EX6pW3YwgHqizivTQ11BlvFY p0VHCC5DMDShBeCfDg3CHYjHhJLSoRsfBxaCQXHrnRbhubGJiIpmNDpx6PRmC9czqEtS obN7MbHTkBewjKMC27ZrMdN46HFHGjkvOjNssPHRZX4h9/mXavB9bF5IsTTy9KjaQb+t zTacQkzf9vFLgZ4bCySph4McFvrQlyBj+p/DofgxJtwc3CJWxO5f+y2LY5c7PbPoKKAU SLSQ== X-Gm-Message-State: ACgBeo1ySls57OHxD41y7FTS6GNAPHAHVIiVvY3ytTadyOhYgEIAdCuW 6AExoG8dvqzfXK91OWqcV0sjzs9oqhi3ZTUDYdwhV2ym X-Google-Smtp-Source: AA6agR6J8b+Z54VCPhR/RtGMapneZgDodVjBN436PmOb42MArNiCdlBxeHrUHZKgGF8X7zT7EeXQQm+nOp0iTrnVTow= X-Received: by 2002:a05:622a:44c:b0:343:7b8e:2cb with SMTP id o12-20020a05622a044c00b003437b8e02cbmr15984927qtx.617.1660667564433; Tue, 16 Aug 2022 09:32:44 -0700 (PDT) MIME-Version: 1.0 References: <451cf788-79c4-a971-fe8f-cb56c04542ef@suse.com> <467c60f1-75c8-7c09-765d-38b473c4f788@suse.com> In-Reply-To: <467c60f1-75c8-7c09-765d-38b473c4f788@suse.com> From: "H.J. Lu" Date: Tue, 16 Aug 2022 09:32:08 -0700 Message-ID: Subject: Re: [PATCH 08/12] x86: template-ize vector packed dword/qword integer insns To: Jan Beulich Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 16:32:47 -0000 On Tue, Aug 16, 2022 at 9:20 AM Jan Beulich wrote: > > On 16.08.2022 17:53, H.J. Lu wrote: > > On Tue, Aug 16, 2022 at 12:37 AM Jan Beulich wrote: > >> > >> On 11.08.2022 19:23, H.J. Lu wrote: > >>> On Fri, Aug 5, 2022 at 5:26 AM Jan Beulich wrote: > >>>> > >>>> Many of the vector integer insns come in dword/qword element pairs. Most > >>>> of these pairs follow certain encoding patterns. Introduce a "dq" > >>>> template to reduce redundancy. > >>>> > >>>> Note that in the course of the conversion > >>>> - a few otherwise untouched templates are moved, so they end up next to > >>>> their siblings), > >>>> - drop an unhelpful Cpu64 from the GPR form of VPBROADCASTQ, matching > >>>> what we already have for KMOVQ - the diagnostic is better this way for > >>>> insns with multiple forms (i.e. the same Cpu64 attributes on {,V}MOVQ, > >>>> {,V}PEXTRQ, and {,V}PINSRQ are useful to keep), > >>>> - this adds benign/meaningless IgnoreSize attributes to the GPR forms of > >>>> KMOVD and VPBROADCASTD; it didn't seem worth avoiding this. > >>>> --- > >>>> For VPCOMPRESS{D,Q} and VPEXPAND{D,Q} the conversion could only be done > >>>> if we allowed Dword/Qword on the memory operands. Imo permitting this > >>>> makes sense anyway (as the memory operands aren't full [XYZ]mmword > >>>> ones), but such a functional change should probably be a separate patch. > >> > >> Do you have any view on this and the similar remarks in two other of the > >> patches in this series? > > > > Since these instructions don't take Dword/Qword memory operands, please > > leave them alone. > > But they also don't really take [XYZ]mmword operands. They're rather similar > to the S/G insns, don't you agree? They are special cases. I don't think they apply here. -- H.J.